diff options
author | Matias Bjørling <m@bjorling.me> | 2015-11-20 07:47:54 -0500 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2015-11-20 10:33:16 -0500 |
commit | 93e70c1f2883f2db2d6a1f339d0e26f00b138e4e (patch) | |
tree | a85eb5d1f16e4533ae52b5b36be06ebf59bf5dcb /drivers/lightnvm/core.c | |
parent | 480fc0db819d706ea5608545a12d33cf8d5a31ab (diff) |
lightnvm: missing free on init error
If either max_phys_sect is out of bound, the nvm_dev structure is not
freed.
Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/lightnvm/core.c')
-rw-r--r-- | drivers/lightnvm/core.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index bed47e7249a9..f61d325fd978 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c | |||
@@ -313,11 +313,13 @@ int nvm_register(struct request_queue *q, char *disk_name, | |||
313 | "ppalist"); | 313 | "ppalist"); |
314 | if (!dev->ppalist_pool) { | 314 | if (!dev->ppalist_pool) { |
315 | pr_err("nvm: could not create ppa pool\n"); | 315 | pr_err("nvm: could not create ppa pool\n"); |
316 | return -ENOMEM; | 316 | ret = -ENOMEM; |
317 | goto err_init; | ||
317 | } | 318 | } |
318 | } else if (dev->ops->max_phys_sect > 256) { | 319 | } else if (dev->ops->max_phys_sect > 256) { |
319 | pr_info("nvm: max sectors supported is 256.\n"); | 320 | pr_info("nvm: max sectors supported is 256.\n"); |
320 | return -EINVAL; | 321 | ret = -EINVAL; |
322 | goto err_init; | ||
321 | } | 323 | } |
322 | 324 | ||
323 | down_write(&nvm_lock); | 325 | down_write(&nvm_lock); |