diff options
author | Álvaro Fernández Rojas <noltari@gmail.com> | 2015-12-15 15:03:48 -0500 |
---|---|---|
committer | Jacek Anaszewski <j.anaszewski@samsung.com> | 2016-01-04 03:57:39 -0500 |
commit | 93a708dab8175c57977d5eec757dd559128f2353 (patch) | |
tree | 76c89df0e85a1622e9bc06fa90dcf701ef4ccf8c /drivers/leds | |
parent | 42273caa18600faede09be223310aabb8e54182e (diff) |
leds: bcm6358: remove unneded lock when checking initial LED status
This lock isn't really needed, since we're only reading the register and
changes made to other LEDs aren't relevant.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Diffstat (limited to 'drivers/leds')
-rw-r--r-- | drivers/leds/leds-bcm6358.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/leds/leds-bcm6358.c b/drivers/leds/leds-bcm6358.c index a98cc711003d..ab09ea453120 100644 --- a/drivers/leds/leds-bcm6358.c +++ b/drivers/leds/leds-bcm6358.c | |||
@@ -99,7 +99,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg, | |||
99 | void __iomem *mem, spinlock_t *lock) | 99 | void __iomem *mem, spinlock_t *lock) |
100 | { | 100 | { |
101 | struct bcm6358_led *led; | 101 | struct bcm6358_led *led; |
102 | unsigned long flags; | ||
103 | const char *state; | 102 | const char *state; |
104 | int rc; | 103 | int rc; |
105 | 104 | ||
@@ -119,7 +118,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg, | |||
119 | "linux,default-trigger", | 118 | "linux,default-trigger", |
120 | NULL); | 119 | NULL); |
121 | 120 | ||
122 | spin_lock_irqsave(lock, flags); | ||
123 | if (!of_property_read_string(nc, "default-state", &state)) { | 121 | if (!of_property_read_string(nc, "default-state", &state)) { |
124 | if (!strcmp(state, "on")) { | 122 | if (!strcmp(state, "on")) { |
125 | led->cdev.brightness = LED_FULL; | 123 | led->cdev.brightness = LED_FULL; |
@@ -141,7 +139,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg, | |||
141 | } else { | 139 | } else { |
142 | led->cdev.brightness = LED_OFF; | 140 | led->cdev.brightness = LED_OFF; |
143 | } | 141 | } |
144 | spin_unlock_irqrestore(lock, flags); | ||
145 | 142 | ||
146 | bcm6358_led_set(&led->cdev, led->cdev.brightness); | 143 | bcm6358_led_set(&led->cdev, led->cdev.brightness); |
147 | 144 | ||