Input: appletouch - replace GFP_ATOMIC with GFP_KERNEL

atp_open(), atp_recover() and atp_resume() are never called in atomic
context. They call usb_submit_urb() with GFP_ATOMIC, which is not
necessary. GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
index 032d27983b6c..f593ec96c95f 100644
--- a/drivers/input/mouse/appletouch.c
+++ b/drivers/input/mouse/appletouch.c
@@ -810,7 +810,7 @@ static int atp_open(struct input_dev *input)
 {
         struct atp *dev = input_get_drvdata(input);
 
-        if (usb_submit_urb(dev->urb, GFP_ATOMIC))
+        if (usb_submit_urb(dev->urb, GFP_KERNEL))
                 return -EIO;
 
         dev->open = true;
@@ -976,7 +976,7 @@ static int atp_recover(struct atp *dev)
         if (error)
                 return error;
 
-        if (dev->open && usb_submit_urb(dev->urb, GFP_ATOMIC))
+        if (dev->open && usb_submit_urb(dev->urb, GFP_KERNEL))
                 return -EIO;
 
         return 0;
@@ -994,7 +994,7 @@ static int atp_resume(struct usb_interface *iface)
 {
         struct atp *dev = usb_get_intfdata(iface);
 
-        if (dev->open && usb_submit_urb(dev->urb, GFP_ATOMIC))
+        if (dev->open && usb_submit_urb(dev->urb, GFP_KERNEL))
                 return -EIO;
 
         return 0;