IB/qib: Fix module-level leak

The vzalloc()'ed field physshadow is leaked on module unload.

This patch adds vfree after the sibling page shadow is freed.

Reported-by: Dean Luick <dean.luick@intel.com>
Reviewed-by: Dean Luick <dean.luick@intel.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
index fdae42973056..36e048e0e1d9 100644
--- a/drivers/infiniband/hw/qib/qib_init.c
+++ b/drivers/infiniband/hw/qib/qib_init.c
@@ -1350,7 +1350,7 @@ static void cleanup_device_data(struct qib_devdata *dd)
         if (dd->pageshadow) {
                 struct page **tmpp = dd->pageshadow;
                 dma_addr_t *tmpd = dd->physshadow;
-                int i, cnt = 0;
+                int i;
 
                 for (ctxt = 0; ctxt < dd->cfgctxts; ctxt++) {
                         int ctxt_tidbase = ctxt * dd->rcvtidcnt;
@@ -1363,13 +1363,13 @@ static void cleanup_device_data(struct qib_devdata *dd)
                                                PAGE_SIZE, PCI_DMA_FROMDEVICE);
                                 qib_release_user_pages(&tmpp[i], 1);
                                 tmpp[i] = NULL;
-                                cnt++;
                         }
                 }
 
-                tmpp = dd->pageshadow;
                 dd->pageshadow = NULL;
                 vfree(tmpp);
+                dd->physshadow = NULL;
+                vfree(tmpd);
         }
 
         /*