diff options
author | Kees Cook <keescook@chromium.org> | 2013-07-03 18:04:56 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-07-03 19:07:41 -0400 |
commit | 02aa2a37636c8fa4fb9322d91be46ff8225b7de0 (patch) | |
tree | 97c93d17cfcad186d229ef76f96de709eddfea8c /drivers/infiniband/core/sysfs.c | |
parent | 096a8aac6bf4a5a0b2ef812ad76d056bbf3fb2af (diff) |
drivers: avoid format string in dev_set_name
Calling dev_set_name with a single paramter causes it to be handled as a
format string. Many callers are passing potentially dynamic string
content, so use "%s" in those cases to avoid any potential accidents,
including wrappers like device_create*() and bdi_register().
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/infiniband/core/sysfs.c')
-rw-r--r-- | drivers/infiniband/core/sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c index 246fdc151652..99904f7d59e3 100644 --- a/drivers/infiniband/core/sysfs.c +++ b/drivers/infiniband/core/sysfs.c | |||
@@ -813,7 +813,7 @@ int ib_device_register_sysfs(struct ib_device *device, | |||
813 | 813 | ||
814 | class_dev->class = &ib_class; | 814 | class_dev->class = &ib_class; |
815 | class_dev->parent = device->dma_device; | 815 | class_dev->parent = device->dma_device; |
816 | dev_set_name(class_dev, device->name); | 816 | dev_set_name(class_dev, "%s", device->name); |
817 | dev_set_drvdata(class_dev, device); | 817 | dev_set_drvdata(class_dev, device); |
818 | 818 | ||
819 | INIT_LIST_HEAD(&device->port_list); | 819 | INIT_LIST_HEAD(&device->port_list); |