iio: hid-sensor: Return proper error if kmemdup fails

Return -ENOMEM instead of 0 if kmemdup fails.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

4 files changed, 11 insertions, 12 deletions

diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index a95cda0e387f..e67bb912bd19 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -306,10 +306,10 @@ static int __devinit hid_accel_3d_probe(struct platform_device *pdev)
                 goto error_free_dev;
         }
 
-        channels = kmemdup(accel_3d_channels,
-                                        sizeof(accel_3d_channels),
-                                        GFP_KERNEL);
+        channels = kmemdup(accel_3d_channels, sizeof(accel_3d_channels),
+                           GFP_KERNEL);
         if (!channels) {
+                ret = -ENOMEM;
                 dev_err(&pdev->dev, "failed to duplicate channels\n");
                 goto error_free_dev;
         }
diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
index 02ef989b830d..4c8b158e40e1 100644
--- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
+++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
@@ -306,10 +306,10 @@ static int __devinit hid_gyro_3d_probe(struct platform_device *pdev)
                 goto error_free_dev;
         }
 
-        channels = kmemdup(gyro_3d_channels,
-                                        sizeof(gyro_3d_channels),
-                                        GFP_KERNEL);
+        channels = kmemdup(gyro_3d_channels, sizeof(gyro_3d_channels),
+                           GFP_KERNEL);
         if (!channels) {
+                ret = -ENOMEM;
                 dev_err(&pdev->dev, "failed to duplicate channels\n");
                 goto error_free_dev;
         }
diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
index 8e1f69844eea..23eeeef64e84 100644
--- a/drivers/iio/light/hid-sensor-als.c
+++ b/drivers/iio/light/hid-sensor-als.c
@@ -272,10 +272,9 @@ static int __devinit hid_als_probe(struct platform_device *pdev)
                 goto error_free_dev;
         }
 
-        channels = kmemdup(als_channels,
-                                        sizeof(als_channels),
-                                        GFP_KERNEL);
+        channels = kmemdup(als_channels, sizeof(als_channels), GFP_KERNEL);
         if (!channels) {
+                ret = -ENOMEM;
                 dev_err(&pdev->dev, "failed to duplicate channels\n");
                 goto error_free_dev;
         }
diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
index d1b5fb74b9bf..8e75eb76ccd9 100644
--- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
+++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
@@ -307,10 +307,10 @@ static int __devinit hid_magn_3d_probe(struct platform_device *pdev)
                 goto error_free_dev;
         }
 
-        channels = kmemdup(magn_3d_channels,
-                                        sizeof(magn_3d_channels),
-                                        GFP_KERNEL);
+        channels = kmemdup(magn_3d_channels, sizeof(magn_3d_channels),
+                           GFP_KERNEL);
         if (!channels) {
+                ret = -ENOMEM;
                 dev_err(&pdev->dev, "failed to duplicate channels\n");
                 goto error_free_dev;
         }