diff options
author | Matt Ranostay <matt.ranostay@konsulko.com> | 2017-05-04 20:32:19 -0400 |
---|---|---|
committer | Jonathan Cameron <jic23@kernel.org> | 2017-05-07 08:21:55 -0400 |
commit | 9122b54f266ddee09654fe3fbc503c1a60f4a01c (patch) | |
tree | f1f8c7c4c432b9fae188731ccf4e3a887dfa7f5b /drivers/iio/proximity/as3935.c | |
parent | 275292d3a3d62670b1b13484707b74e5239b4bb0 (diff) |
iio: proximity: as3935: fix iio_trigger_poll issue
Using iio_trigger_poll() can oops when multiple interrupts
happen before the first is handled.
Use iio_trigger_poll_chained() instead and use the timestamp
when processed, since it will be in theory be 2 ms max latency.
Fixes: 24ddb0e4bba4 ("iio: Add AS3935 lightning sensor support")
Cc: stable@vger.kernel.org
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio/proximity/as3935.c')
-rw-r--r-- | drivers/iio/proximity/as3935.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c index 2e94e5ad884b..aa4df0dcc8c9 100644 --- a/drivers/iio/proximity/as3935.c +++ b/drivers/iio/proximity/as3935.c | |||
@@ -215,7 +215,7 @@ static irqreturn_t as3935_trigger_handler(int irq, void *private) | |||
215 | 215 | ||
216 | st->buffer[0] = val & AS3935_DATA_MASK; | 216 | st->buffer[0] = val & AS3935_DATA_MASK; |
217 | iio_push_to_buffers_with_timestamp(indio_dev, &st->buffer, | 217 | iio_push_to_buffers_with_timestamp(indio_dev, &st->buffer, |
218 | pf->timestamp); | 218 | iio_get_time_ns(indio_dev)); |
219 | err_read: | 219 | err_read: |
220 | iio_trigger_notify_done(indio_dev->trig); | 220 | iio_trigger_notify_done(indio_dev->trig); |
221 | 221 | ||
@@ -244,7 +244,7 @@ static void as3935_event_work(struct work_struct *work) | |||
244 | 244 | ||
245 | switch (val) { | 245 | switch (val) { |
246 | case AS3935_EVENT_INT: | 246 | case AS3935_EVENT_INT: |
247 | iio_trigger_poll(st->trig); | 247 | iio_trigger_poll_chained(st->trig); |
248 | break; | 248 | break; |
249 | case AS3935_NOISE_INT: | 249 | case AS3935_NOISE_INT: |
250 | dev_warn(&st->spi->dev, "noise level is too high\n"); | 250 | dev_warn(&st->spi->dev, "noise level is too high\n"); |