diff options
author | Jan Luebbe <jlu@pengutronix.de> | 2015-07-08 10:35:06 -0400 |
---|---|---|
committer | Wolfram Sang <wsa@the-dreams.de> | 2015-07-31 07:32:31 -0400 |
commit | 8b06260836ab47abbb5ea49d889660a0ed8adf90 (patch) | |
tree | 743827d5440c9513a0bae63d5f3cc0acf7ea2938 /drivers/i2c/i2c-core.c | |
parent | d12c0aaf3780c5b26b4ea9e795252381f586c063 (diff) |
i2c: core: only use set_scl for bus recovery after calling prepare_recovery
Using set_scl may be ineffective before calling the driver specific
prepare_recovery callback, which might change into a test mode. So
instead of setting SCL in i2c_generic_scl_recovery, move it to
i2c_generic_recovery (after the optional prepare_recovery).
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Acked-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Tested-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/i2c/i2c-core.c')
-rw-r--r-- | drivers/i2c/i2c-core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index e6d4935161e4..8b64cf38beac 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c | |||
@@ -567,6 +567,9 @@ static int i2c_generic_recovery(struct i2c_adapter *adap) | |||
567 | if (bri->prepare_recovery) | 567 | if (bri->prepare_recovery) |
568 | bri->prepare_recovery(adap); | 568 | bri->prepare_recovery(adap); |
569 | 569 | ||
570 | bri->set_scl(adap, val); | ||
571 | ndelay(RECOVERY_NDELAY); | ||
572 | |||
570 | /* | 573 | /* |
571 | * By this time SCL is high, as we need to give 9 falling-rising edges | 574 | * By this time SCL is high, as we need to give 9 falling-rising edges |
572 | */ | 575 | */ |
@@ -597,7 +600,6 @@ static int i2c_generic_recovery(struct i2c_adapter *adap) | |||
597 | 600 | ||
598 | int i2c_generic_scl_recovery(struct i2c_adapter *adap) | 601 | int i2c_generic_scl_recovery(struct i2c_adapter *adap) |
599 | { | 602 | { |
600 | adap->bus_recovery_info->set_scl(adap, 1); | ||
601 | return i2c_generic_recovery(adap); | 603 | return i2c_generic_recovery(adap); |
602 | } | 604 | } |
603 | EXPORT_SYMBOL_GPL(i2c_generic_scl_recovery); | 605 | EXPORT_SYMBOL_GPL(i2c_generic_scl_recovery); |