aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hwtracing/intel_th
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-10-16 10:09:13 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-10-17 02:25:48 -0400
commit73061da07d28ac6724bcd9ce4b51cf51a8b6b40e (patch)
treebda6bd37fb26f21fa47d6e49de3483e124952ed4 /drivers/hwtracing/intel_th
parent1c090575b013cd1f0070567203498704fa61b2fc (diff)
intel_th: Check for NULL instead of ERR_PTR
devm_ioremap() returns NULL on error, it doesn't return an ERR_PTR, which is what the current code does. This patch corrects these checks. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwtracing/intel_th')
-rw-r--r--drivers/hwtracing/intel_th/gth.c4
-rw-r--r--drivers/hwtracing/intel_th/msu.c4
-rw-r--r--drivers/hwtracing/intel_th/pti.c4
-rw-r--r--drivers/hwtracing/intel_th/sth.c8
4 files changed, 10 insertions, 10 deletions
diff --git a/drivers/hwtracing/intel_th/gth.c b/drivers/hwtracing/intel_th/gth.c
index 673d272ee400..2dc5378ccd3a 100644
--- a/drivers/hwtracing/intel_th/gth.c
+++ b/drivers/hwtracing/intel_th/gth.c
@@ -635,8 +635,8 @@ static int intel_th_gth_probe(struct intel_th_device *thdev)
635 return -ENODEV; 635 return -ENODEV;
636 636
637 base = devm_ioremap(dev, res->start, resource_size(res)); 637 base = devm_ioremap(dev, res->start, resource_size(res));
638 if (IS_ERR(base)) 638 if (!base)
639 return PTR_ERR(base); 639 return -ENOMEM;
640 640
641 gth = devm_kzalloc(dev, sizeof(*gth), GFP_KERNEL); 641 gth = devm_kzalloc(dev, sizeof(*gth), GFP_KERNEL);
642 if (!gth) 642 if (!gth)
diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index 80a12384ed20..70ca27e45602 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -1458,8 +1458,8 @@ static int intel_th_msc_probe(struct intel_th_device *thdev)
1458 return -ENODEV; 1458 return -ENODEV;
1459 1459
1460 base = devm_ioremap(dev, res->start, resource_size(res)); 1460 base = devm_ioremap(dev, res->start, resource_size(res));
1461 if (IS_ERR(base)) 1461 if (!base)
1462 return PTR_ERR(base); 1462 return -ENOMEM;
1463 1463
1464 msc = devm_kzalloc(dev, sizeof(*msc), GFP_KERNEL); 1464 msc = devm_kzalloc(dev, sizeof(*msc), GFP_KERNEL);
1465 if (!msc) 1465 if (!msc)
diff --git a/drivers/hwtracing/intel_th/pti.c b/drivers/hwtracing/intel_th/pti.c
index 1e3bbc89825c..57cbfdcc7ef0 100644
--- a/drivers/hwtracing/intel_th/pti.c
+++ b/drivers/hwtracing/intel_th/pti.c
@@ -207,8 +207,8 @@ static int intel_th_pti_probe(struct intel_th_device *thdev)
207 return -ENODEV; 207 return -ENODEV;
208 208
209 base = devm_ioremap(dev, res->start, resource_size(res)); 209 base = devm_ioremap(dev, res->start, resource_size(res));
210 if (IS_ERR(base)) 210 if (!base)
211 return PTR_ERR(base); 211 return -ENOMEM;
212 212
213 pti = devm_kzalloc(dev, sizeof(*pti), GFP_KERNEL); 213 pti = devm_kzalloc(dev, sizeof(*pti), GFP_KERNEL);
214 if (!pti) 214 if (!pti)
diff --git a/drivers/hwtracing/intel_th/sth.c b/drivers/hwtracing/intel_th/sth.c
index e488fccbfdec..56101c33e10f 100644
--- a/drivers/hwtracing/intel_th/sth.c
+++ b/drivers/hwtracing/intel_th/sth.c
@@ -194,16 +194,16 @@ static int intel_th_sth_probe(struct intel_th_device *thdev)
194 return -ENODEV; 194 return -ENODEV;
195 195
196 base = devm_ioremap(dev, res->start, resource_size(res)); 196 base = devm_ioremap(dev, res->start, resource_size(res));
197 if (IS_ERR(base)) 197 if (!base)
198 return PTR_ERR(base); 198 return -ENOMEM;
199 199
200 res = intel_th_device_get_resource(thdev, IORESOURCE_MEM, 1); 200 res = intel_th_device_get_resource(thdev, IORESOURCE_MEM, 1);
201 if (!res) 201 if (!res)
202 return -ENODEV; 202 return -ENODEV;
203 203
204 channels = devm_ioremap(dev, res->start, resource_size(res)); 204 channels = devm_ioremap(dev, res->start, resource_size(res));
205 if (IS_ERR(channels)) 205 if (!channels)
206 return PTR_ERR(channels); 206 return -ENOMEM;
207 207
208 sth = devm_kzalloc(dev, sizeof(*sth), GFP_KERNEL); 208 sth = devm_kzalloc(dev, sizeof(*sth), GFP_KERNEL);
209 if (!sth) 209 if (!sth)