aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/dme1737.c
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2013-01-09 11:09:34 -0500
committerGuenter Roeck <linux@roeck-us.net>2013-01-26 00:03:54 -0500
commit2a844c148e1f714ebf42cb96e1b172ce394c36c9 (patch)
treeeb68eb8438f0470e7a81b022199abe5f6d866879 /drivers/hwmon/dme1737.c
parent142c090184ac7f9763c5d22509405da3486f9801 (diff)
hwmon: Replace SENSORS_LIMIT with clamp_val
SENSORS_LIMIT and the generic clamp_val have the same functionality, and clamp_val is more efficient. This patch reduces text size by 9052 bytes and bss size by 11624 bytes for x86_64 builds. Signed-off-by: Guenter Roeck <linux@roeck-us.net> Acked-by: George Joseph <george.joseph@fairview5.com> Acked-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers/hwmon/dme1737.c')
-rw-r--r--drivers/hwmon/dme1737.c15
1 files changed, 7 insertions, 8 deletions
diff --git a/drivers/hwmon/dme1737.c b/drivers/hwmon/dme1737.c
index 7430f70ae452..c347c94f2f73 100644
--- a/drivers/hwmon/dme1737.c
+++ b/drivers/hwmon/dme1737.c
@@ -277,7 +277,7 @@ static inline int IN_FROM_REG(int reg, int nominal, int res)
277 277
278static inline int IN_TO_REG(int val, int nominal) 278static inline int IN_TO_REG(int val, int nominal)
279{ 279{
280 return SENSORS_LIMIT((val * 192 + nominal / 2) / nominal, 0, 255); 280 return clamp_val((val * 192 + nominal / 2) / nominal, 0, 255);
281} 281}
282 282
283/* 283/*
@@ -293,8 +293,7 @@ static inline int TEMP_FROM_REG(int reg, int res)
293 293
294static inline int TEMP_TO_REG(int val) 294static inline int TEMP_TO_REG(int val)
295{ 295{
296 return SENSORS_LIMIT((val < 0 ? val - 500 : val + 500) / 1000, 296 return clamp_val((val < 0 ? val - 500 : val + 500) / 1000, -128, 127);
297 -128, 127);
298} 297}
299 298
300/* Temperature range */ 299/* Temperature range */
@@ -332,7 +331,7 @@ static inline int TEMP_HYST_FROM_REG(int reg, int ix)
332 331
333static inline int TEMP_HYST_TO_REG(int val, int ix, int reg) 332static inline int TEMP_HYST_TO_REG(int val, int ix, int reg)
334{ 333{
335 int hyst = SENSORS_LIMIT((val + 500) / 1000, 0, 15); 334 int hyst = clamp_val((val + 500) / 1000, 0, 15);
336 335
337 return (ix == 1) ? (reg & 0xf0) | hyst : (reg & 0x0f) | (hyst << 4); 336 return (ix == 1) ? (reg & 0xf0) | hyst : (reg & 0x0f) | (hyst << 4);
338} 337}
@@ -349,10 +348,10 @@ static inline int FAN_FROM_REG(int reg, int tpc)
349static inline int FAN_TO_REG(int val, int tpc) 348static inline int FAN_TO_REG(int val, int tpc)
350{ 349{
351 if (tpc) { 350 if (tpc) {
352 return SENSORS_LIMIT(val / tpc, 0, 0xffff); 351 return clamp_val(val / tpc, 0, 0xffff);
353 } else { 352 } else {
354 return (val <= 0) ? 0xffff : 353 return (val <= 0) ? 0xffff :
355 SENSORS_LIMIT(90000 * 60 / val, 0, 0xfffe); 354 clamp_val(90000 * 60 / val, 0, 0xfffe);
356 } 355 }
357} 356}
358 357
@@ -1282,7 +1281,7 @@ static ssize_t set_pwm(struct device *dev, struct device_attribute *attr,
1282 mutex_lock(&data->update_lock); 1281 mutex_lock(&data->update_lock);
1283 switch (fn) { 1282 switch (fn) {
1284 case SYS_PWM: 1283 case SYS_PWM:
1285 data->pwm[ix] = SENSORS_LIMIT(val, 0, 255); 1284 data->pwm[ix] = clamp_val(val, 0, 255);
1286 dme1737_write(data, DME1737_REG_PWM(ix), data->pwm[ix]); 1285 dme1737_write(data, DME1737_REG_PWM(ix), data->pwm[ix]);
1287 break; 1286 break;
1288 case SYS_PWM_FREQ: 1287 case SYS_PWM_FREQ:
@@ -1450,7 +1449,7 @@ static ssize_t set_pwm(struct device *dev, struct device_attribute *attr,
1450 break; 1449 break;
1451 case SYS_PWM_AUTO_POINT1_PWM: 1450 case SYS_PWM_AUTO_POINT1_PWM:
1452 /* Only valid for pwm[1-3] */ 1451 /* Only valid for pwm[1-3] */
1453 data->pwm_min[ix] = SENSORS_LIMIT(val, 0, 255); 1452 data->pwm_min[ix] = clamp_val(val, 0, 255);
1454 dme1737_write(data, DME1737_REG_PWM_MIN(ix), 1453 dme1737_write(data, DME1737_REG_PWM_MIN(ix),
1455 data->pwm_min[ix]); 1454 data->pwm_min[ix]);
1456 break; 1455 break;