diff options
author | Guenter Roeck <linux@roeck-us.net> | 2017-05-04 02:49:18 -0400 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2017-05-05 18:14:32 -0400 |
commit | af8baf1518d8b3d086ac6d11d8f6acd57e9cab99 (patch) | |
tree | b54d4089f08c2b31be05316d36e76357ff795bd7 /drivers/gpu | |
parent | ad7d0ff3e79a100a24b66e8908a45402c20c3685 (diff) |
drm/amdgpu: Use less generic enum definitions
alpha:allmodconfig fails to build as follows.
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1006:2: error:
expected identifier before '(' token
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1011:28: error:
'NGG_BUF_MAX' undeclared here
The problem is not really the enum definition of NGG_BUF_MAX but PARAM,
which happens to be defined differently for alpha and a couple of other
architectures.
Use less generic defines for NGG enums to solve the problem.
Fixes: bce23e00f3369 ("drm/amdgpu: add NGG parameters")
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu')
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu.h | 8 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 16 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 28 |
3 files changed, 26 insertions, 26 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 8033001b913a..86923c57908b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h | |||
@@ -1004,10 +1004,10 @@ struct amdgpu_ngg_buf { | |||
1004 | }; | 1004 | }; |
1005 | 1005 | ||
1006 | enum { | 1006 | enum { |
1007 | PRIM = 0, | 1007 | NGG_PRIM = 0, |
1008 | POS, | 1008 | NGG_POS, |
1009 | CNTL, | 1009 | NGG_CNTL, |
1010 | PARAM, | 1010 | NGG_PARAM, |
1011 | NGG_BUF_MAX | 1011 | NGG_BUF_MAX |
1012 | }; | 1012 | }; |
1013 | 1013 | ||
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index 1a7830a291d6..96c341670782 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | |||
@@ -545,14 +545,14 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file | |||
545 | adev->gfx.config.double_offchip_lds_buf; | 545 | adev->gfx.config.double_offchip_lds_buf; |
546 | 546 | ||
547 | if (amdgpu_ngg) { | 547 | if (amdgpu_ngg) { |
548 | dev_info.prim_buf_gpu_addr = adev->gfx.ngg.buf[PRIM].gpu_addr; | 548 | dev_info.prim_buf_gpu_addr = adev->gfx.ngg.buf[NGG_PRIM].gpu_addr; |
549 | dev_info.prim_buf_size = adev->gfx.ngg.buf[PRIM].size; | 549 | dev_info.prim_buf_size = adev->gfx.ngg.buf[NGG_PRIM].size; |
550 | dev_info.pos_buf_gpu_addr = adev->gfx.ngg.buf[POS].gpu_addr; | 550 | dev_info.pos_buf_gpu_addr = adev->gfx.ngg.buf[NGG_POS].gpu_addr; |
551 | dev_info.pos_buf_size = adev->gfx.ngg.buf[POS].size; | 551 | dev_info.pos_buf_size = adev->gfx.ngg.buf[NGG_POS].size; |
552 | dev_info.cntl_sb_buf_gpu_addr = adev->gfx.ngg.buf[CNTL].gpu_addr; | 552 | dev_info.cntl_sb_buf_gpu_addr = adev->gfx.ngg.buf[NGG_CNTL].gpu_addr; |
553 | dev_info.cntl_sb_buf_size = adev->gfx.ngg.buf[CNTL].size; | 553 | dev_info.cntl_sb_buf_size = adev->gfx.ngg.buf[NGG_CNTL].size; |
554 | dev_info.param_buf_gpu_addr = adev->gfx.ngg.buf[PARAM].gpu_addr; | 554 | dev_info.param_buf_gpu_addr = adev->gfx.ngg.buf[NGG_PARAM].gpu_addr; |
555 | dev_info.param_buf_size = adev->gfx.ngg.buf[PARAM].size; | 555 | dev_info.param_buf_size = adev->gfx.ngg.buf[NGG_PARAM].size; |
556 | } | 556 | } |
557 | dev_info.wave_front_size = adev->gfx.cu_info.wave_front_size; | 557 | dev_info.wave_front_size = adev->gfx.cu_info.wave_front_size; |
558 | dev_info.num_shader_visible_vgprs = adev->gfx.config.max_gprs; | 558 | dev_info.num_shader_visible_vgprs = adev->gfx.config.max_gprs; |
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 741b56f996c4..0c16b7563b73 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | |||
@@ -890,7 +890,7 @@ static int gfx_v9_0_ngg_init(struct amdgpu_device *adev) | |||
890 | adev->gfx.ngg.gds_reserve_addr += adev->gds.mem.gfx_partition_size; | 890 | adev->gfx.ngg.gds_reserve_addr += adev->gds.mem.gfx_partition_size; |
891 | 891 | ||
892 | /* Primitive Buffer */ | 892 | /* Primitive Buffer */ |
893 | r = gfx_v9_0_ngg_create_buf(adev, &adev->gfx.ngg.buf[PRIM], | 893 | r = gfx_v9_0_ngg_create_buf(adev, &adev->gfx.ngg.buf[NGG_PRIM], |
894 | amdgpu_prim_buf_per_se, | 894 | amdgpu_prim_buf_per_se, |
895 | 64 * 1024); | 895 | 64 * 1024); |
896 | if (r) { | 896 | if (r) { |
@@ -899,7 +899,7 @@ static int gfx_v9_0_ngg_init(struct amdgpu_device *adev) | |||
899 | } | 899 | } |
900 | 900 | ||
901 | /* Position Buffer */ | 901 | /* Position Buffer */ |
902 | r = gfx_v9_0_ngg_create_buf(adev, &adev->gfx.ngg.buf[POS], | 902 | r = gfx_v9_0_ngg_create_buf(adev, &adev->gfx.ngg.buf[NGG_POS], |
903 | amdgpu_pos_buf_per_se, | 903 | amdgpu_pos_buf_per_se, |
904 | 256 * 1024); | 904 | 256 * 1024); |
905 | if (r) { | 905 | if (r) { |
@@ -908,7 +908,7 @@ static int gfx_v9_0_ngg_init(struct amdgpu_device *adev) | |||
908 | } | 908 | } |
909 | 909 | ||
910 | /* Control Sideband */ | 910 | /* Control Sideband */ |
911 | r = gfx_v9_0_ngg_create_buf(adev, &adev->gfx.ngg.buf[CNTL], | 911 | r = gfx_v9_0_ngg_create_buf(adev, &adev->gfx.ngg.buf[NGG_CNTL], |
912 | amdgpu_cntl_sb_buf_per_se, | 912 | amdgpu_cntl_sb_buf_per_se, |
913 | 256); | 913 | 256); |
914 | if (r) { | 914 | if (r) { |
@@ -920,7 +920,7 @@ static int gfx_v9_0_ngg_init(struct amdgpu_device *adev) | |||
920 | if (amdgpu_param_buf_per_se <= 0) | 920 | if (amdgpu_param_buf_per_se <= 0) |
921 | goto out; | 921 | goto out; |
922 | 922 | ||
923 | r = gfx_v9_0_ngg_create_buf(adev, &adev->gfx.ngg.buf[PARAM], | 923 | r = gfx_v9_0_ngg_create_buf(adev, &adev->gfx.ngg.buf[NGG_PARAM], |
924 | amdgpu_param_buf_per_se, | 924 | amdgpu_param_buf_per_se, |
925 | 512 * 1024); | 925 | 512 * 1024); |
926 | if (r) { | 926 | if (r) { |
@@ -949,45 +949,45 @@ static int gfx_v9_0_ngg_en(struct amdgpu_device *adev) | |||
949 | 949 | ||
950 | /* Program buffer size */ | 950 | /* Program buffer size */ |
951 | data = 0; | 951 | data = 0; |
952 | size = adev->gfx.ngg.buf[PRIM].size / 256; | 952 | size = adev->gfx.ngg.buf[NGG_PRIM].size / 256; |
953 | data = REG_SET_FIELD(data, WD_BUF_RESOURCE_1, INDEX_BUF_SIZE, size); | 953 | data = REG_SET_FIELD(data, WD_BUF_RESOURCE_1, INDEX_BUF_SIZE, size); |
954 | 954 | ||
955 | size = adev->gfx.ngg.buf[POS].size / 256; | 955 | size = adev->gfx.ngg.buf[NGG_POS].size / 256; |
956 | data = REG_SET_FIELD(data, WD_BUF_RESOURCE_1, POS_BUF_SIZE, size); | 956 | data = REG_SET_FIELD(data, WD_BUF_RESOURCE_1, POS_BUF_SIZE, size); |
957 | 957 | ||
958 | WREG32_SOC15(GC, 0, mmWD_BUF_RESOURCE_1, data); | 958 | WREG32_SOC15(GC, 0, mmWD_BUF_RESOURCE_1, data); |
959 | 959 | ||
960 | data = 0; | 960 | data = 0; |
961 | size = adev->gfx.ngg.buf[CNTL].size / 256; | 961 | size = adev->gfx.ngg.buf[NGG_CNTL].size / 256; |
962 | data = REG_SET_FIELD(data, WD_BUF_RESOURCE_2, CNTL_SB_BUF_SIZE, size); | 962 | data = REG_SET_FIELD(data, WD_BUF_RESOURCE_2, CNTL_SB_BUF_SIZE, size); |
963 | 963 | ||
964 | size = adev->gfx.ngg.buf[PARAM].size / 1024; | 964 | size = adev->gfx.ngg.buf[NGG_PARAM].size / 1024; |
965 | data = REG_SET_FIELD(data, WD_BUF_RESOURCE_2, PARAM_BUF_SIZE, size); | 965 | data = REG_SET_FIELD(data, WD_BUF_RESOURCE_2, PARAM_BUF_SIZE, size); |
966 | 966 | ||
967 | WREG32_SOC15(GC, 0, mmWD_BUF_RESOURCE_2, data); | 967 | WREG32_SOC15(GC, 0, mmWD_BUF_RESOURCE_2, data); |
968 | 968 | ||
969 | /* Program buffer base address */ | 969 | /* Program buffer base address */ |
970 | base = lower_32_bits(adev->gfx.ngg.buf[PRIM].gpu_addr); | 970 | base = lower_32_bits(adev->gfx.ngg.buf[NGG_PRIM].gpu_addr); |
971 | data = REG_SET_FIELD(0, WD_INDEX_BUF_BASE, BASE, base); | 971 | data = REG_SET_FIELD(0, WD_INDEX_BUF_BASE, BASE, base); |
972 | WREG32_SOC15(GC, 0, mmWD_INDEX_BUF_BASE, data); | 972 | WREG32_SOC15(GC, 0, mmWD_INDEX_BUF_BASE, data); |
973 | 973 | ||
974 | base = upper_32_bits(adev->gfx.ngg.buf[PRIM].gpu_addr); | 974 | base = upper_32_bits(adev->gfx.ngg.buf[NGG_PRIM].gpu_addr); |
975 | data = REG_SET_FIELD(0, WD_INDEX_BUF_BASE_HI, BASE_HI, base); | 975 | data = REG_SET_FIELD(0, WD_INDEX_BUF_BASE_HI, BASE_HI, base); |
976 | WREG32_SOC15(GC, 0, mmWD_INDEX_BUF_BASE_HI, data); | 976 | WREG32_SOC15(GC, 0, mmWD_INDEX_BUF_BASE_HI, data); |
977 | 977 | ||
978 | base = lower_32_bits(adev->gfx.ngg.buf[POS].gpu_addr); | 978 | base = lower_32_bits(adev->gfx.ngg.buf[NGG_POS].gpu_addr); |
979 | data = REG_SET_FIELD(0, WD_POS_BUF_BASE, BASE, base); | 979 | data = REG_SET_FIELD(0, WD_POS_BUF_BASE, BASE, base); |
980 | WREG32_SOC15(GC, 0, mmWD_POS_BUF_BASE, data); | 980 | WREG32_SOC15(GC, 0, mmWD_POS_BUF_BASE, data); |
981 | 981 | ||
982 | base = upper_32_bits(adev->gfx.ngg.buf[POS].gpu_addr); | 982 | base = upper_32_bits(adev->gfx.ngg.buf[NGG_POS].gpu_addr); |
983 | data = REG_SET_FIELD(0, WD_POS_BUF_BASE_HI, BASE_HI, base); | 983 | data = REG_SET_FIELD(0, WD_POS_BUF_BASE_HI, BASE_HI, base); |
984 | WREG32_SOC15(GC, 0, mmWD_POS_BUF_BASE_HI, data); | 984 | WREG32_SOC15(GC, 0, mmWD_POS_BUF_BASE_HI, data); |
985 | 985 | ||
986 | base = lower_32_bits(adev->gfx.ngg.buf[CNTL].gpu_addr); | 986 | base = lower_32_bits(adev->gfx.ngg.buf[NGG_CNTL].gpu_addr); |
987 | data = REG_SET_FIELD(0, WD_CNTL_SB_BUF_BASE, BASE, base); | 987 | data = REG_SET_FIELD(0, WD_CNTL_SB_BUF_BASE, BASE, base); |
988 | WREG32_SOC15(GC, 0, mmWD_CNTL_SB_BUF_BASE, data); | 988 | WREG32_SOC15(GC, 0, mmWD_CNTL_SB_BUF_BASE, data); |
989 | 989 | ||
990 | base = upper_32_bits(adev->gfx.ngg.buf[CNTL].gpu_addr); | 990 | base = upper_32_bits(adev->gfx.ngg.buf[NGG_CNTL].gpu_addr); |
991 | data = REG_SET_FIELD(0, WD_CNTL_SB_BUF_BASE_HI, BASE_HI, base); | 991 | data = REG_SET_FIELD(0, WD_CNTL_SB_BUF_BASE_HI, BASE_HI, base); |
992 | WREG32_SOC15(GC, 0, mmWD_CNTL_SB_BUF_BASE_HI, data); | 992 | WREG32_SOC15(GC, 0, mmWD_CNTL_SB_BUF_BASE_HI, data); |
993 | 993 | ||