diff options
author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2015-09-25 09:37:43 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-09-30 04:20:08 -0400 |
commit | 5e7234c9ccf88c427448fbe147839b4dca82efde (patch) | |
tree | 64a119ea1e4c1848480d4b2819fb98f8042c98d0 /drivers/gpu | |
parent | 3c5f174e383d6eddd9190637cebd005174287996 (diff) |
drm/i915: s/mode/adjusted_mode/ in functions that really get passed the adjusted_mode
Rename the function argument to 'adjusted_mode' whenever the function
only ever gets passed the adjusted_mode.
v2: Update due to intel_dsi.c changes
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu')
-rw-r--r-- | drivers/gpu/drm/i915/i915_drv.h | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_audio.c | 17 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_dsi.c | 22 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_panel.c | 36 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_sdvo.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_sprite.c | 8 |
6 files changed, 47 insertions, 44 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 04d710ff4913..ad37b2591878 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h | |||
@@ -646,7 +646,7 @@ struct drm_i915_display_funcs { | |||
646 | void (*crtc_disable)(struct drm_crtc *crtc); | 646 | void (*crtc_disable)(struct drm_crtc *crtc); |
647 | void (*audio_codec_enable)(struct drm_connector *connector, | 647 | void (*audio_codec_enable)(struct drm_connector *connector, |
648 | struct intel_encoder *encoder, | 648 | struct intel_encoder *encoder, |
649 | struct drm_display_mode *mode); | 649 | const struct drm_display_mode *adjusted_mode); |
650 | void (*audio_codec_disable)(struct intel_encoder *encoder); | 650 | void (*audio_codec_disable)(struct intel_encoder *encoder); |
651 | void (*fdi_link_train)(struct drm_crtc *crtc); | 651 | void (*fdi_link_train)(struct drm_crtc *crtc); |
652 | void (*init_clock_gating)(struct drm_device *dev); | 652 | void (*init_clock_gating)(struct drm_device *dev); |
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index d9876c55fd6f..779f90c1ce69 100644 --- a/drivers/gpu/drm/i915/intel_audio.c +++ b/drivers/gpu/drm/i915/intel_audio.c | |||
@@ -69,17 +69,18 @@ static const struct { | |||
69 | }; | 69 | }; |
70 | 70 | ||
71 | /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */ | 71 | /* get AUD_CONFIG_PIXEL_CLOCK_HDMI_* value for mode */ |
72 | static u32 audio_config_hdmi_pixel_clock(struct drm_display_mode *mode) | 72 | static u32 audio_config_hdmi_pixel_clock(const struct drm_display_mode *adjusted_mode) |
73 | { | 73 | { |
74 | int i; | 74 | int i; |
75 | 75 | ||
76 | for (i = 0; i < ARRAY_SIZE(hdmi_audio_clock); i++) { | 76 | for (i = 0; i < ARRAY_SIZE(hdmi_audio_clock); i++) { |
77 | if (mode->clock == hdmi_audio_clock[i].clock) | 77 | if (adjusted_mode->clock == hdmi_audio_clock[i].clock) |
78 | break; | 78 | break; |
79 | } | 79 | } |
80 | 80 | ||
81 | if (i == ARRAY_SIZE(hdmi_audio_clock)) { | 81 | if (i == ARRAY_SIZE(hdmi_audio_clock)) { |
82 | DRM_DEBUG_KMS("HDMI audio pixel clock setting for %d not found, falling back to defaults\n", mode->clock); | 82 | DRM_DEBUG_KMS("HDMI audio pixel clock setting for %d not found, falling back to defaults\n", |
83 | adjusted_mode->clock); | ||
83 | i = 1; | 84 | i = 1; |
84 | } | 85 | } |
85 | 86 | ||
@@ -138,7 +139,7 @@ static void g4x_audio_codec_disable(struct intel_encoder *encoder) | |||
138 | 139 | ||
139 | static void g4x_audio_codec_enable(struct drm_connector *connector, | 140 | static void g4x_audio_codec_enable(struct drm_connector *connector, |
140 | struct intel_encoder *encoder, | 141 | struct intel_encoder *encoder, |
141 | struct drm_display_mode *mode) | 142 | const struct drm_display_mode *adjusted_mode) |
142 | { | 143 | { |
143 | struct drm_i915_private *dev_priv = connector->dev->dev_private; | 144 | struct drm_i915_private *dev_priv = connector->dev->dev_private; |
144 | uint8_t *eld = connector->eld; | 145 | uint8_t *eld = connector->eld; |
@@ -203,7 +204,7 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder) | |||
203 | 204 | ||
204 | static void hsw_audio_codec_enable(struct drm_connector *connector, | 205 | static void hsw_audio_codec_enable(struct drm_connector *connector, |
205 | struct intel_encoder *encoder, | 206 | struct intel_encoder *encoder, |
206 | struct drm_display_mode *mode) | 207 | const struct drm_display_mode *adjusted_mode) |
207 | { | 208 | { |
208 | struct drm_i915_private *dev_priv = connector->dev->dev_private; | 209 | struct drm_i915_private *dev_priv = connector->dev->dev_private; |
209 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); | 210 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); |
@@ -251,7 +252,7 @@ static void hsw_audio_codec_enable(struct drm_connector *connector, | |||
251 | if (intel_pipe_has_type(intel_crtc, INTEL_OUTPUT_DISPLAYPORT)) | 252 | if (intel_pipe_has_type(intel_crtc, INTEL_OUTPUT_DISPLAYPORT)) |
252 | tmp |= AUD_CONFIG_N_VALUE_INDEX; | 253 | tmp |= AUD_CONFIG_N_VALUE_INDEX; |
253 | else | 254 | else |
254 | tmp |= audio_config_hdmi_pixel_clock(mode); | 255 | tmp |= audio_config_hdmi_pixel_clock(adjusted_mode); |
255 | I915_WRITE(HSW_AUD_CFG(pipe), tmp); | 256 | I915_WRITE(HSW_AUD_CFG(pipe), tmp); |
256 | } | 257 | } |
257 | 258 | ||
@@ -304,7 +305,7 @@ static void ilk_audio_codec_disable(struct intel_encoder *encoder) | |||
304 | 305 | ||
305 | static void ilk_audio_codec_enable(struct drm_connector *connector, | 306 | static void ilk_audio_codec_enable(struct drm_connector *connector, |
306 | struct intel_encoder *encoder, | 307 | struct intel_encoder *encoder, |
307 | struct drm_display_mode *mode) | 308 | const struct drm_display_mode *adjusted_mode) |
308 | { | 309 | { |
309 | struct drm_i915_private *dev_priv = connector->dev->dev_private; | 310 | struct drm_i915_private *dev_priv = connector->dev->dev_private; |
310 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); | 311 | struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); |
@@ -381,7 +382,7 @@ static void ilk_audio_codec_enable(struct drm_connector *connector, | |||
381 | if (intel_pipe_has_type(intel_crtc, INTEL_OUTPUT_DISPLAYPORT)) | 382 | if (intel_pipe_has_type(intel_crtc, INTEL_OUTPUT_DISPLAYPORT)) |
382 | tmp |= AUD_CONFIG_N_VALUE_INDEX; | 383 | tmp |= AUD_CONFIG_N_VALUE_INDEX; |
383 | else | 384 | else |
384 | tmp |= audio_config_hdmi_pixel_clock(mode); | 385 | tmp |= audio_config_hdmi_pixel_clock(adjusted_mode); |
385 | I915_WRITE(aud_config, tmp); | 386 | I915_WRITE(aud_config, tmp); |
386 | } | 387 | } |
387 | 388 | ||
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 23b7fc517e96..b4d5213f0abb 100644 --- a/drivers/gpu/drm/i915/intel_dsi.c +++ b/drivers/gpu/drm/i915/intel_dsi.c | |||
@@ -698,7 +698,7 @@ static u16 txbyteclkhs(u16 pixels, int bpp, int lane_count, | |||
698 | } | 698 | } |
699 | 699 | ||
700 | static void set_dsi_timings(struct drm_encoder *encoder, | 700 | static void set_dsi_timings(struct drm_encoder *encoder, |
701 | const struct drm_display_mode *mode) | 701 | const struct drm_display_mode *adjusted_mode) |
702 | { | 702 | { |
703 | struct drm_device *dev = encoder->dev; | 703 | struct drm_device *dev = encoder->dev; |
704 | struct drm_i915_private *dev_priv = dev->dev_private; | 704 | struct drm_i915_private *dev_priv = dev->dev_private; |
@@ -710,10 +710,10 @@ static void set_dsi_timings(struct drm_encoder *encoder, | |||
710 | 710 | ||
711 | u16 hactive, hfp, hsync, hbp, vfp, vsync, vbp; | 711 | u16 hactive, hfp, hsync, hbp, vfp, vsync, vbp; |
712 | 712 | ||
713 | hactive = mode->hdisplay; | 713 | hactive = adjusted_mode->hdisplay; |
714 | hfp = mode->hsync_start - mode->hdisplay; | 714 | hfp = adjusted_mode->hsync_start - adjusted_mode->hdisplay; |
715 | hsync = mode->hsync_end - mode->hsync_start; | 715 | hsync = adjusted_mode->hsync_end - adjusted_mode->hsync_start; |
716 | hbp = mode->htotal - mode->hsync_end; | 716 | hbp = adjusted_mode->htotal - adjusted_mode->hsync_end; |
717 | 717 | ||
718 | if (intel_dsi->dual_link) { | 718 | if (intel_dsi->dual_link) { |
719 | hactive /= 2; | 719 | hactive /= 2; |
@@ -724,9 +724,9 @@ static void set_dsi_timings(struct drm_encoder *encoder, | |||
724 | hbp /= 2; | 724 | hbp /= 2; |
725 | } | 725 | } |
726 | 726 | ||
727 | vfp = mode->vsync_start - mode->vdisplay; | 727 | vfp = adjusted_mode->vsync_start - adjusted_mode->vdisplay; |
728 | vsync = mode->vsync_end - mode->vsync_start; | 728 | vsync = adjusted_mode->vsync_end - adjusted_mode->vsync_start; |
729 | vbp = mode->vtotal - mode->vsync_end; | 729 | vbp = adjusted_mode->vtotal - adjusted_mode->vsync_end; |
730 | 730 | ||
731 | /* horizontal values are in terms of high speed byte clock */ | 731 | /* horizontal values are in terms of high speed byte clock */ |
732 | hactive = txbyteclkhs(hactive, bpp, lane_count, | 732 | hactive = txbyteclkhs(hactive, bpp, lane_count, |
@@ -745,11 +745,11 @@ static void set_dsi_timings(struct drm_encoder *encoder, | |||
745 | * whereas these values should be based on resolution. | 745 | * whereas these values should be based on resolution. |
746 | */ | 746 | */ |
747 | I915_WRITE(BXT_MIPI_TRANS_HACTIVE(port), | 747 | I915_WRITE(BXT_MIPI_TRANS_HACTIVE(port), |
748 | mode->hdisplay); | 748 | adjusted_mode->hdisplay); |
749 | I915_WRITE(BXT_MIPI_TRANS_VACTIVE(port), | 749 | I915_WRITE(BXT_MIPI_TRANS_VACTIVE(port), |
750 | mode->vdisplay); | 750 | adjusted_mode->vdisplay); |
751 | I915_WRITE(BXT_MIPI_TRANS_VTOTAL(port), | 751 | I915_WRITE(BXT_MIPI_TRANS_VTOTAL(port), |
752 | mode->vtotal); | 752 | adjusted_mode->vtotal); |
753 | } | 753 | } |
754 | 754 | ||
755 | I915_WRITE(MIPI_HACTIVE_AREA_COUNT(port), hactive); | 755 | I915_WRITE(MIPI_HACTIVE_AREA_COUNT(port), hactive); |
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index 2c11b4eedfc6..4294f605fe00 100644 --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c | |||
@@ -172,46 +172,46 @@ done: | |||
172 | } | 172 | } |
173 | 173 | ||
174 | static void | 174 | static void |
175 | centre_horizontally(struct drm_display_mode *mode, | 175 | centre_horizontally(struct drm_display_mode *adjusted_mode, |
176 | int width) | 176 | int width) |
177 | { | 177 | { |
178 | u32 border, sync_pos, blank_width, sync_width; | 178 | u32 border, sync_pos, blank_width, sync_width; |
179 | 179 | ||
180 | /* keep the hsync and hblank widths constant */ | 180 | /* keep the hsync and hblank widths constant */ |
181 | sync_width = mode->crtc_hsync_end - mode->crtc_hsync_start; | 181 | sync_width = adjusted_mode->crtc_hsync_end - adjusted_mode->crtc_hsync_start; |
182 | blank_width = mode->crtc_hblank_end - mode->crtc_hblank_start; | 182 | blank_width = adjusted_mode->crtc_hblank_end - adjusted_mode->crtc_hblank_start; |
183 | sync_pos = (blank_width - sync_width + 1) / 2; | 183 | sync_pos = (blank_width - sync_width + 1) / 2; |
184 | 184 | ||
185 | border = (mode->hdisplay - width + 1) / 2; | 185 | border = (adjusted_mode->hdisplay - width + 1) / 2; |
186 | border += border & 1; /* make the border even */ | 186 | border += border & 1; /* make the border even */ |
187 | 187 | ||
188 | mode->crtc_hdisplay = width; | 188 | adjusted_mode->crtc_hdisplay = width; |
189 | mode->crtc_hblank_start = width + border; | 189 | adjusted_mode->crtc_hblank_start = width + border; |
190 | mode->crtc_hblank_end = mode->crtc_hblank_start + blank_width; | 190 | adjusted_mode->crtc_hblank_end = adjusted_mode->crtc_hblank_start + blank_width; |
191 | 191 | ||
192 | mode->crtc_hsync_start = mode->crtc_hblank_start + sync_pos; | 192 | adjusted_mode->crtc_hsync_start = adjusted_mode->crtc_hblank_start + sync_pos; |
193 | mode->crtc_hsync_end = mode->crtc_hsync_start + sync_width; | 193 | adjusted_mode->crtc_hsync_end = adjusted_mode->crtc_hsync_start + sync_width; |
194 | } | 194 | } |
195 | 195 | ||
196 | static void | 196 | static void |
197 | centre_vertically(struct drm_display_mode *mode, | 197 | centre_vertically(struct drm_display_mode *adjusted_mode, |
198 | int height) | 198 | int height) |
199 | { | 199 | { |
200 | u32 border, sync_pos, blank_width, sync_width; | 200 | u32 border, sync_pos, blank_width, sync_width; |
201 | 201 | ||
202 | /* keep the vsync and vblank widths constant */ | 202 | /* keep the vsync and vblank widths constant */ |
203 | sync_width = mode->crtc_vsync_end - mode->crtc_vsync_start; | 203 | sync_width = adjusted_mode->crtc_vsync_end - adjusted_mode->crtc_vsync_start; |
204 | blank_width = mode->crtc_vblank_end - mode->crtc_vblank_start; | 204 | blank_width = adjusted_mode->crtc_vblank_end - adjusted_mode->crtc_vblank_start; |
205 | sync_pos = (blank_width - sync_width + 1) / 2; | 205 | sync_pos = (blank_width - sync_width + 1) / 2; |
206 | 206 | ||
207 | border = (mode->vdisplay - height + 1) / 2; | 207 | border = (adjusted_mode->vdisplay - height + 1) / 2; |
208 | 208 | ||
209 | mode->crtc_vdisplay = height; | 209 | adjusted_mode->crtc_vdisplay = height; |
210 | mode->crtc_vblank_start = height + border; | 210 | adjusted_mode->crtc_vblank_start = height + border; |
211 | mode->crtc_vblank_end = mode->crtc_vblank_start + blank_width; | 211 | adjusted_mode->crtc_vblank_end = adjusted_mode->crtc_vblank_start + blank_width; |
212 | 212 | ||
213 | mode->crtc_vsync_start = mode->crtc_vblank_start + sync_pos; | 213 | adjusted_mode->crtc_vsync_start = adjusted_mode->crtc_vblank_start + sync_pos; |
214 | mode->crtc_vsync_end = mode->crtc_vsync_start + sync_width; | 214 | adjusted_mode->crtc_vsync_end = adjusted_mode->crtc_vsync_start + sync_width; |
215 | } | 215 | } |
216 | 216 | ||
217 | static inline u32 panel_fitter_scaling(u32 source, u32 target) | 217 | static inline u32 panel_fitter_scaling(u32 source, u32 target) |
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index b0b96fded708..ab75b6146e84 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/drm/i915/intel_sdvo.c | |||
@@ -603,11 +603,11 @@ log_fail: | |||
603 | return false; | 603 | return false; |
604 | } | 604 | } |
605 | 605 | ||
606 | static int intel_sdvo_get_pixel_multiplier(struct drm_display_mode *mode) | 606 | static int intel_sdvo_get_pixel_multiplier(const struct drm_display_mode *adjusted_mode) |
607 | { | 607 | { |
608 | if (mode->clock >= 100000) | 608 | if (adjusted_mode->clock >= 100000) |
609 | return 1; | 609 | return 1; |
610 | else if (mode->clock >= 50000) | 610 | else if (adjusted_mode->clock >= 50000) |
611 | return 2; | 611 | return 2; |
612 | else | 612 | else |
613 | return 4; | 613 | return 4; |
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index 821804071d91..b229c6752671 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c +++ b/drivers/gpu/drm/i915/intel_sprite.c | |||
@@ -53,13 +53,15 @@ format_is_yuv(uint32_t format) | |||
53 | } | 53 | } |
54 | } | 54 | } |
55 | 55 | ||
56 | static int usecs_to_scanlines(const struct drm_display_mode *mode, int usecs) | 56 | static int usecs_to_scanlines(const struct drm_display_mode *adjusted_mode, |
57 | int usecs) | ||
57 | { | 58 | { |
58 | /* paranoia */ | 59 | /* paranoia */ |
59 | if (!mode->crtc_htotal) | 60 | if (!adjusted_mode->crtc_htotal) |
60 | return 1; | 61 | return 1; |
61 | 62 | ||
62 | return DIV_ROUND_UP(usecs * mode->crtc_clock, 1000 * mode->crtc_htotal); | 63 | return DIV_ROUND_UP(usecs * adjusted_mode->crtc_clock, |
64 | 1000 * adjusted_mode->crtc_htotal); | ||
63 | } | 65 | } |
64 | 66 | ||
65 | /** | 67 | /** |