aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm
diff options
context:
space:
mode:
authorRavikant B Sharma <ravikant.s2@samsung.com>2016-11-08 00:49:42 -0500
committerAlex Deucher <alexander.deucher@amd.com>2016-11-11 10:21:07 -0500
commit3f12325ab8dc3a35f77eaf0155bd6d6e78f67e9c (patch)
tree02375dd3c54bbd6532fea6a7b86abaf3f32c92c1 /drivers/gpu/drm
parentbc24fbe9df6623500ad1fab92e71265d4cb7fa2a (diff)
drm/amd/amdgpu : Fix NULL pointer comparison
Replace direct comparisons to NULL i.e. 'x == NULL' with '!x'. As per coding standard. Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Ravikant B Sharma <ravikant.s2@samsung.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm')
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c3
-rw-r--r--drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c2
3 files changed, 3 insertions, 4 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
index 2b6afe123f3d..b7e2762fcdd2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
@@ -70,7 +70,7 @@ static bool igp_read_bios_from_vram(struct amdgpu_device *adev)
70 return false; 70 return false;
71 } 71 }
72 adev->bios = kmalloc(size, GFP_KERNEL); 72 adev->bios = kmalloc(size, GFP_KERNEL);
73 if (adev->bios == NULL) { 73 if (!adev->bios) {
74 iounmap(bios); 74 iounmap(bios);
75 return false; 75 return false;
76 } 76 }
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
index 34a795463988..de9f919ae336 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
@@ -327,9 +327,8 @@ int amdgpu_sa_bo_new(struct amdgpu_sa_manager *sa_manager,
327 return -EINVAL; 327 return -EINVAL;
328 328
329 *sa_bo = kmalloc(sizeof(struct amdgpu_sa_bo), GFP_KERNEL); 329 *sa_bo = kmalloc(sizeof(struct amdgpu_sa_bo), GFP_KERNEL);
330 if ((*sa_bo) == NULL) { 330 if (!(*sa_bo))
331 return -ENOMEM; 331 return -ENOMEM;
332 }
333 (*sa_bo)->manager = sa_manager; 332 (*sa_bo)->manager = sa_manager;
334 (*sa_bo)->fence = NULL; 333 (*sa_bo)->fence = NULL;
335 INIT_LIST_HEAD(&(*sa_bo)->olist); 334 INIT_LIST_HEAD(&(*sa_bo)->olist);
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 1ac88b1fb1a1..ab84bff18727 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -3904,7 +3904,7 @@ static int gfx_v8_0_init_save_restore_list(struct amdgpu_device *adev)
3904 int list_size; 3904 int list_size;
3905 unsigned int *register_list_format = 3905 unsigned int *register_list_format =
3906 kmalloc(adev->gfx.rlc.reg_list_format_size_bytes, GFP_KERNEL); 3906 kmalloc(adev->gfx.rlc.reg_list_format_size_bytes, GFP_KERNEL);
3907 if (register_list_format == NULL) 3907 if (!register_list_format)
3908 return -ENOMEM; 3908 return -ENOMEM;
3909 memcpy(register_list_format, adev->gfx.rlc.register_list_format, 3909 memcpy(register_list_format, adev->gfx.rlc.register_list_format,
3910 adev->gfx.rlc.reg_list_format_size_bytes); 3910 adev->gfx.rlc.reg_list_format_size_bytes);