diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2016-07-15 16:38:42 -0400 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-07-18 03:11:29 -0400 |
| commit | 5345a5ab513b3438bab7d5b02c02d9bde064209e (patch) | |
| tree | 4795309bf0223ef6dbe3bb4308d00944cc410664 /drivers/gpu/drm/virtio | |
| parent | f15a8e9a14196bad904d040e7b587bdf76ad35ed (diff) | |
drm/virtgpu: Delete unnecessary checks before drm_gem_object_unreference_unlocked()
The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/5e3dafff-72bb-e616-e84a-368f78fa66b1@users.sourceforge.net
Diffstat (limited to 'drivers/gpu/drm/virtio')
| -rw-r--r-- | drivers/gpu/drm/virtio/virtgpu_display.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index ac758cdbc1bc..fdfc711c9a4d 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c | |||
| @@ -53,8 +53,7 @@ static void virtio_gpu_user_framebuffer_destroy(struct drm_framebuffer *fb) | |||
| 53 | struct virtio_gpu_framebuffer *virtio_gpu_fb | 53 | struct virtio_gpu_framebuffer *virtio_gpu_fb |
| 54 | = to_virtio_gpu_framebuffer(fb); | 54 | = to_virtio_gpu_framebuffer(fb); |
| 55 | 55 | ||
| 56 | if (virtio_gpu_fb->obj) | 56 | drm_gem_object_unreference_unlocked(virtio_gpu_fb->obj); |
| 57 | drm_gem_object_unreference_unlocked(virtio_gpu_fb->obj); | ||
| 58 | drm_framebuffer_cleanup(fb); | 57 | drm_framebuffer_cleanup(fb); |
| 59 | kfree(virtio_gpu_fb); | 58 | kfree(virtio_gpu_fb); |
| 60 | } | 59 | } |
| @@ -326,8 +325,7 @@ virtio_gpu_user_framebuffer_create(struct drm_device *dev, | |||
| 326 | ret = virtio_gpu_framebuffer_init(dev, virtio_gpu_fb, mode_cmd, obj); | 325 | ret = virtio_gpu_framebuffer_init(dev, virtio_gpu_fb, mode_cmd, obj); |
| 327 | if (ret) { | 326 | if (ret) { |
| 328 | kfree(virtio_gpu_fb); | 327 | kfree(virtio_gpu_fb); |
| 329 | if (obj) | 328 | drm_gem_object_unreference_unlocked(obj); |
| 330 | drm_gem_object_unreference_unlocked(obj); | ||
| 331 | return NULL; | 329 | return NULL; |
| 332 | } | 330 | } |
| 333 | 331 | ||
