gpu: drm: vc4_hdmi: add missing of_node_put after calling of_parse_phandle

of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
Reviewed-by: Eric Anholt <eric@anholt.net>

1 files changed, 7 insertions, 6 deletions

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index fd2644d231ff..26b6b067567c 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -465,12 +465,6 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
         if (IS_ERR(hdmi->hd_regs))
                 return PTR_ERR(hdmi->hd_regs);
 
-        ddc_node = of_parse_phandle(dev->of_node, "ddc", 0);
-        if (!ddc_node) {
-                DRM_ERROR("Failed to find ddc node in device tree\n");
-                return -ENODEV;
-        }
-
         hdmi->pixel_clock = devm_clk_get(dev, "pixel");
         if (IS_ERR(hdmi->pixel_clock)) {
                 DRM_ERROR("Failed to get pixel clock\n");
@@ -482,7 +476,14 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
                 return PTR_ERR(hdmi->hsm_clock);
         }
 
+        ddc_node = of_parse_phandle(dev->of_node, "ddc", 0);
+        if (!ddc_node) {
+                DRM_ERROR("Failed to find ddc node in device tree\n");
+                return -ENODEV;
+        }
+
         hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
+        of_node_put(ddc_node);
         if (!hdmi->ddc) {
                 DRM_DEBUG("Failed to get ddc i2c adapter by node\n");
                 return -EPROBE_DEFER;