diff options
author | Maarten Lankhorst <m.b.lankhorst@gmail.com> | 2012-11-28 06:25:39 -0500 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2012-12-10 05:09:58 -0500 |
commit | 4154f051e74e6a5db174c8f4fc8a2f9c8a6b2541 (patch) | |
tree | 6bdfc3dc7fd144bf5cbe23c908649afff6183448 /drivers/gpu/drm/ttm/ttm_execbuf_util.c | |
parent | 1a1494def7eacbd25db05185aa2e81ef90892460 (diff) |
drm/ttm: change fence_lock to inner lock
This requires changing the order in ttm_bo_cleanup_refs_or_queue to
take the reservation first, as there is otherwise no race free way to
take lru lock before fence_lock.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/ttm/ttm_execbuf_util.c')
-rw-r--r-- | drivers/gpu/drm/ttm/ttm_execbuf_util.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/ttm/ttm_execbuf_util.c b/drivers/gpu/drm/ttm/ttm_execbuf_util.c index 1986d006c264..cd9e4523dc56 100644 --- a/drivers/gpu/drm/ttm/ttm_execbuf_util.c +++ b/drivers/gpu/drm/ttm/ttm_execbuf_util.c | |||
@@ -213,8 +213,8 @@ void ttm_eu_fence_buffer_objects(struct list_head *list, void *sync_obj) | |||
213 | driver = bdev->driver; | 213 | driver = bdev->driver; |
214 | glob = bo->glob; | 214 | glob = bo->glob; |
215 | 215 | ||
216 | spin_lock(&bdev->fence_lock); | ||
217 | spin_lock(&glob->lru_lock); | 216 | spin_lock(&glob->lru_lock); |
217 | spin_lock(&bdev->fence_lock); | ||
218 | 218 | ||
219 | list_for_each_entry(entry, list, head) { | 219 | list_for_each_entry(entry, list, head) { |
220 | bo = entry->bo; | 220 | bo = entry->bo; |
@@ -223,8 +223,8 @@ void ttm_eu_fence_buffer_objects(struct list_head *list, void *sync_obj) | |||
223 | ttm_bo_unreserve_locked(bo); | 223 | ttm_bo_unreserve_locked(bo); |
224 | entry->reserved = false; | 224 | entry->reserved = false; |
225 | } | 225 | } |
226 | spin_unlock(&glob->lru_lock); | ||
227 | spin_unlock(&bdev->fence_lock); | 226 | spin_unlock(&bdev->fence_lock); |
227 | spin_unlock(&glob->lru_lock); | ||
228 | 228 | ||
229 | list_for_each_entry(entry, list, head) { | 229 | list_for_each_entry(entry, list, head) { |
230 | if (entry->old_sync_obj) | 230 | if (entry->old_sync_obj) |