drm: rcar-du: Use the drm atomic state duplication helpers for planes

Ensure that the duplicate and destroy plane state operations will always
be in sync with the DRM core implementation of the plane state by using
the __drm_atomic_helper_plane_duplicate_state() and
__drm_atomic_helper_plane_destroy_state() functions designed especially
for this purpose.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
index d90dc428e3fd..c66986414bb4 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
@@ -302,13 +302,15 @@ rcar_du_plane_atomic_duplicate_state(struct drm_plane *plane)
         struct rcar_du_plane_state *state;
         struct rcar_du_plane_state *copy;
 
+        if (WARN_ON(!plane->state))
+                return NULL;
+
         state = to_rcar_plane_state(plane->state);
         copy = kmemdup(state, sizeof(*state), GFP_KERNEL);
         if (copy == NULL)
                 return NULL;
 
-        if (copy->state.fb)
-                drm_framebuffer_reference(copy->state.fb);
+        __drm_atomic_helper_plane_duplicate_state(plane, &copy->state);
 
         return &copy->state;
 }
@@ -316,9 +318,7 @@ rcar_du_plane_atomic_duplicate_state(struct drm_plane *plane)
 static void rcar_du_plane_atomic_destroy_state(struct drm_plane *plane,
                                                struct drm_plane_state *state)
 {
-        if (state->fb)
-                drm_framebuffer_unreference(state->fb);
-
+        __drm_atomic_helper_plane_destroy_state(plane, state);
         kfree(to_rcar_plane_state(state));
 }