drm/panel: simple: Update calls to gpiod_get*()

Add the new flags argument to calls of (devm_)gpiod_get*() and remove
any direction setting code afterwards.

Currently both forms (with or without the flags argument) are valid
thanks to transitional macros in <linux/gpio/consumer.h>. These macros
will be removed once all consumers are updated and the flags argument
will become compulsary.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

1 files changed, 2 insertions, 9 deletions

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 23de22f8c820..83d93062930d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -247,21 +247,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
         if (IS_ERR(panel->supply))
                 return PTR_ERR(panel->supply);
 
-        panel->enable_gpio = devm_gpiod_get_optional(dev, "enable");
+        panel->enable_gpio = devm_gpiod_get_optional(dev, "enable",
+                                                     GPIOD_OUT_LOW);
         if (IS_ERR(panel->enable_gpio)) {
                 err = PTR_ERR(panel->enable_gpio);
                 dev_err(dev, "failed to request GPIO: %d\n", err);
                 return err;
         }
 
-        if (panel->enable_gpio) {
-                err = gpiod_direction_output(panel->enable_gpio, 0);
-                if (err < 0) {
-                        dev_err(dev, "failed to setup GPIO: %d\n", err);
-                        return err;
-                }
-        }
-
         backlight = of_parse_phandle(dev->of_node, "backlight", 0);
         if (backlight) {
                 panel->backlight = of_find_backlight_by_node(backlight);