aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/omapdrm
diff options
context:
space:
mode:
authorPeter Chen <peter.chen@nxp.com>2016-08-11 05:44:54 -0400
committerSean Paul <seanpaul@chromium.org>2016-08-12 07:10:37 -0400
commit5a78ff7bf7e25191144b550961001bbf6c734da4 (patch)
tree52a50af68a556e014fb98f660bcea7c15f3da2bc /drivers/gpu/drm/omapdrm
parent0c756134cf76350ee9b1b516065e5ea1bedac956 (diff)
Revert "gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle"
This reverts commit 2ab9f5879162499e1c4e48613287e3f59e593c4f Author: Peter Chen <peter.chen@nxp.com> Date: Fri Jul 15 11:17:03 2016 +0800 gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle The of_get_next_parent will drop refcount on the passed node, so the reverted patch is wrong, thanks for Tomi Valkeinen points it. Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by: Peter Chen <peter.chen@nxp.com> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: http://patchwork.freedesktop.org/patch/msgid/1470908694-16362-1-git-send-email-peter.chen@nxp.com
Diffstat (limited to 'drivers/gpu/drm/omapdrm')
-rw-r--r--drivers/gpu/drm/omapdrm/dss/dss-of.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c b/drivers/gpu/drm/omapdrm/dss/dss-of.c
index e256d879b25c..dfd4e9621e3b 100644
--- a/drivers/gpu/drm/omapdrm/dss/dss-of.c
+++ b/drivers/gpu/drm/omapdrm/dss/dss-of.c
@@ -125,16 +125,15 @@ u32 dss_of_port_get_port_number(struct device_node *port)
125 125
126static struct device_node *omapdss_of_get_remote_port(const struct device_node *node) 126static struct device_node *omapdss_of_get_remote_port(const struct device_node *node)
127{ 127{
128 struct device_node *np, *np_parent; 128 struct device_node *np;
129 129
130 np = of_parse_phandle(node, "remote-endpoint", 0); 130 np = of_parse_phandle(node, "remote-endpoint", 0);
131 if (!np) 131 if (!np)
132 return NULL; 132 return NULL;
133 133
134 np_parent = of_get_next_parent(np); 134 np = of_get_next_parent(np);
135 of_node_put(np);
136 135
137 return np_parent; 136 return np;
138} 137}
139 138
140struct device_node * 139struct device_node *