diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2018-06-05 17:04:39 -0400 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2018-09-03 09:13:29 -0400 |
commit | 138fe53ef8d341dd27a0f01d55f8774d33b880f8 (patch) | |
tree | 46b5b25a12e81e1e8cbee0199893de44c9a13bc3 /drivers/gpu/drm/omapdrm/omap_encoder.c | |
parent | bb23800c887da3a96297ec3d4a09b6bd887ce503 (diff) |
drm/omap: Remove unneeded fallback for missing .check_timings()
The .check_timings() operation is present in all panels and connectors.
The fallback that uses .get_timings() in the absence of .check_timings()
is thus unneeded.
While it could be argued that the fallback implements a useful check
that should be extended to cover all fixed-resolution panels, the code
is currently unused and gets in the way of the ongoing refactoring.
Remove it, a similar feature can always be added later.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/gpu/drm/omapdrm/omap_encoder.c')
-rw-r--r-- | drivers/gpu/drm/omapdrm/omap_encoder.c | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c b/drivers/gpu/drm/omapdrm/omap_encoder.c index 94b75d018e71..a6dce480b2cf 100644 --- a/drivers/gpu/drm/omapdrm/omap_encoder.c +++ b/drivers/gpu/drm/omapdrm/omap_encoder.c | |||
@@ -101,21 +101,9 @@ static int omap_encoder_update(struct drm_encoder *encoder, | |||
101 | struct omap_dss_device *dssdev = omap_encoder->display; | 101 | struct omap_dss_device *dssdev = omap_encoder->display; |
102 | int ret; | 102 | int ret; |
103 | 103 | ||
104 | if (dssdev->ops->check_timings) { | 104 | ret = dssdev->ops->check_timings(dssdev, vm); |
105 | ret = dssdev->ops->check_timings(dssdev, vm); | ||
106 | } else { | ||
107 | struct videomode t = {0}; | ||
108 | |||
109 | dssdev->ops->get_timings(dssdev, &t); | ||
110 | |||
111 | if (memcmp(vm, &t, sizeof(*vm))) | ||
112 | ret = -EINVAL; | ||
113 | else | ||
114 | ret = 0; | ||
115 | } | ||
116 | |||
117 | if (ret) { | 105 | if (ret) { |
118 | dev_err(dev->dev, "could not set timings: %d\n", ret); | 106 | dev_err(dev->dev, "invalid timings: %d\n", ret); |
119 | return ret; | 107 | return ret; |
120 | } | 108 | } |
121 | 109 | ||