diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2018-06-05 17:04:39 -0400 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2018-09-03 09:13:29 -0400 |
commit | 138fe53ef8d341dd27a0f01d55f8774d33b880f8 (patch) | |
tree | 46b5b25a12e81e1e8cbee0199893de44c9a13bc3 /drivers/gpu/drm/omapdrm/omap_connector.c | |
parent | bb23800c887da3a96297ec3d4a09b6bd887ce503 (diff) |
drm/omap: Remove unneeded fallback for missing .check_timings()
The .check_timings() operation is present in all panels and connectors.
The fallback that uses .get_timings() in the absence of .check_timings()
is thus unneeded.
While it could be argued that the fallback implements a useful check
that should be extended to cover all fixed-resolution panels, the code
is currently unused and gets in the way of the ongoing refactoring.
Remove it, a similar feature can always be added later.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/gpu/drm/omapdrm/omap_connector.c')
-rw-r--r-- | drivers/gpu/drm/omapdrm/omap_connector.c | 25 |
1 files changed, 1 insertions, 24 deletions
diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c b/drivers/gpu/drm/omapdrm/omap_connector.c index 06c48a64b745..b58d9a0bb53d 100644 --- a/drivers/gpu/drm/omapdrm/omap_connector.c +++ b/drivers/gpu/drm/omapdrm/omap_connector.c | |||
@@ -261,30 +261,7 @@ static int omap_connector_mode_valid(struct drm_connector *connector, | |||
261 | drm_display_mode_to_videomode(mode, &vm); | 261 | drm_display_mode_to_videomode(mode, &vm); |
262 | mode->vrefresh = drm_mode_vrefresh(mode); | 262 | mode->vrefresh = drm_mode_vrefresh(mode); |
263 | 263 | ||
264 | /* | 264 | r = dssdev->ops->check_timings(dssdev, &vm); |
265 | * if the panel driver doesn't have a check_timings, it's most likely | ||
266 | * a fixed resolution panel, check if the timings match with the | ||
267 | * panel's timings | ||
268 | */ | ||
269 | if (dssdev->ops->check_timings) { | ||
270 | r = dssdev->ops->check_timings(dssdev, &vm); | ||
271 | } else { | ||
272 | struct videomode t = {0}; | ||
273 | |||
274 | dssdev->ops->get_timings(dssdev, &t); | ||
275 | |||
276 | /* | ||
277 | * Ignore the flags, as we don't get them from | ||
278 | * drm_display_mode_to_videomode. | ||
279 | */ | ||
280 | t.flags = 0; | ||
281 | |||
282 | if (memcmp(&vm, &t, sizeof(vm))) | ||
283 | r = -EINVAL; | ||
284 | else | ||
285 | r = 0; | ||
286 | } | ||
287 | |||
288 | if (!r) { | 265 | if (!r) { |
289 | /* check if vrefresh is still valid */ | 266 | /* check if vrefresh is still valid */ |
290 | new_mode = drm_mode_duplicate(dev, mode); | 267 | new_mode = drm_mode_duplicate(dev, mode); |