Merge tag 'drm-for-v4.9' of git://people.freedesktop.org/~airlied/linux

Pull drm updates from Dave Airlie:
 "Core:
   - Fence destaging work
   - DRIVER_LEGACY to split off legacy drm drivers
   - drm_mm refactoring
   - Splitting drm_crtc.c into chunks and documenting better
   - Display info fixes
   - rbtree support for prime buffer lookup
   - Simple VGA DAC driver

  Panel:
   - Add Nexus 7 panel
   - More simple panels

  i915:
   - Refactoring GEM naming
   - Refactored vma/active tracking
   - Lockless request lookups
   - Better stolen memory support
   - FBC fixes
   - SKL watermark fixes
   - VGPU improvements
   - dma-buf fencing support
   - Better DP dongle support

  amdgpu:
   - Powerplay for Iceland asics
   - Improved GPU reset support
   - UVD/VEC powergating support for CZ/ST
   - Preinitialised VRAM buffer support
   - Virtual display support
   - Initial SI support
   - GTT rework
   - PCI shutdown callback support
   - HPD IRQ storm fixes

  amdkfd:
   - bugfixes

  tilcdc:
   - Atomic modesetting support

  mediatek:
   - AAL + GAMMA engine support
   - Hook up gamma LUT
   - Temporal dithering support

  imx:
   - Pixel clock from devicetree
   - drm bridge support for LVDS bridges
   - active plane reconfiguration
   - VDIC deinterlacer support
   - Frame synchronisation unit support
   - Color space conversion support

  analogix:
   - PSR support
   - Better panel on/off support

  rockchip:
   - rk3399 vop/crtc support
   - PSR support

  vc4:
   - Interlaced vblank timing
   - 3D rendering CPU overhead reduction
   - HDMI output fixes

  tda998x:
   - HDMI audio ASoC support

  sunxi:
   - Allwinner A33 support
   - better TCON support

  msm:
   - DT binding cleanups
   - Explicit fence-fd support

  sti:
   - remove sti415/416 support

  etnaviv:
   - MMUv2 refactoring
   - GC3000 support

  exynos:
   - Refactoring HDMI DCC/PHY
   - G2D pm regression fix
   - Page fault issues with wait for vblank

  There is no nouveau work in this tree, as Ben didn't get a pull
  request in, and he was fighting moving to atomic and adding mst
  support, so maybe best it waits for a cycle"

* tag 'drm-for-v4.9' of git://people.freedesktop.org/~airlied/linux: (1412 commits)
  drm/crtc: constify drm_crtc_index parameter
  drm/i915: Fix conflict resolution from backmerge of v4.8-rc8 to drm-next
  drm/i915/guc: Unwind GuC workqueue reservation if request construction fails
  drm/i915: Reset the breadcrumbs IRQ more carefully
  drm/i915: Force relocations via cpu if we run out of idle aperture
  drm/i915: Distinguish last emitted request from last submitted request
  drm/i915: Allow DP to work w/o EDID
  drm/i915: Move long hpd handling into the hotplug work
  drm/i915/execlists: Reinitialise context image after GPU hang
  drm/i915: Use correct index for backtracking HUNG semaphores
  drm/i915: Unalias obj->phys_handle and obj->userptr
  drm/i915: Just clear the mmiodebug before a register access
  drm/i915/gen9: only add the planes actually affected by ddb changes
  drm/i915: Allow PCH DPLL sharing regardless of DPLL_SDVO_HIGH_SPEED
  drm/i915/bxt: Fix HDMI DPLL configuration
  drm/i915/gen9: fix the watermark res_blocks value
  drm/i915/gen9: fix plane_blocks_per_line on watermarks calculations
  drm/i915/gen9: minimum scanlines for Y tile is not always 4
  drm/i915/gen9: fix the WaWmMemoryReadLatency implementation
  drm/i915/kbl: KBL also needs to run the SAGV code
  ...

13 files changed, 131 insertions, 63 deletions

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 7c7a0314a756..d96b2b6898a3 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -11,6 +11,7 @@ config DRM_MSM
         select TMPFS
         select QCOM_SCM
         select SND_SOC_HDMI_CODEC if SND_SOC
+        select SYNC_FILE
         default y
         help
           DRM/KMS driver for MSM/snapdragon.
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index 973720792236..a968cad509c2 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -422,12 +422,29 @@ static const struct {
 
 static int msm_hdmi_get_gpio(struct device_node *of_node, const char *name)
 {
-        int gpio = of_get_named_gpio(of_node, name, 0);
+        int gpio;
+
+        /* try with the gpio names as in the table (downstream bindings) */
+        gpio = of_get_named_gpio(of_node, name, 0);
         if (gpio < 0) {
                 char name2[32];
-                snprintf(name2, sizeof(name2), "%s-gpio", name);
+
+                /* try with the gpio names as in the upstream bindings */
+                snprintf(name2, sizeof(name2), "%s-gpios", name);
                 gpio = of_get_named_gpio(of_node, name2, 0);
                 if (gpio < 0) {
+                        char name3[32];
+
+                        /*
+                         * try again after stripping out the "qcom,hdmi-tx"
+                         * prefix. This is mainly to match "hpd-gpios" used
+                         * in the upstream bindings
+                         */
+                        if (sscanf(name2, "qcom,hdmi-tx-%s", name3))
+                                gpio = of_get_named_gpio(of_node, name3, 0);
+                }
+
+                if (gpio < 0) {
                         DBG("failed to get gpio: %s (%d)", name, gpio);
                         gpio = -1;
                 }
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
index de9007e72f4e..73e20219d431 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c
@@ -243,7 +243,6 @@ void msm_hdmi_i2c_destroy(struct i2c_adapter *i2c)
 
 struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi)
 {
-        struct drm_device *dev = hdmi->dev;
         struct hdmi_i2c_adapter *hdmi_i2c;
         struct i2c_adapter *i2c = NULL;
         int ret;
@@ -267,10 +266,8 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi)
         i2c->algo = &msm_hdmi_i2c_algorithm;
 
         ret = i2c_add_adapter(i2c);
-        if (ret) {
-                dev_err(dev->dev, "failed to register hdmi i2c: %d\n", ret);
+        if (ret)
                 goto fail;
-        }
 
         return i2c;
 
diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c
index 7b39e89fbc2b..571a91ee9607 100644
--- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c
+++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c
@@ -228,18 +228,21 @@ static struct device_node *mdp4_detect_lcdc_panel(struct drm_device *dev)
         struct device_node *endpoint, *panel_node;
         struct device_node *np = dev->dev->of_node;
 
-        endpoint = of_graph_get_next_endpoint(np, NULL);
+        /*
+         * LVDS/LCDC is the first port described in the list of ports in the
+         * MDP4 DT node.
+         */
+        endpoint = of_graph_get_endpoint_by_regs(np, 0, -1);
         if (!endpoint) {
-                DBG("no endpoint in MDP4 to fetch LVDS panel\n");
+                DBG("no LVDS remote endpoint\n");
                 return NULL;
         }
 
-        /* don't proceed if we have an endpoint but no panel_node tied to it */
         panel_node = of_graph_get_remote_port_parent(endpoint);
         if (!panel_node) {
-                dev_err(dev->dev, "no valid panel node\n");
+                DBG("no valid panel node in LVDS endpoint\n");
                 of_node_put(endpoint);
-                return ERR_PTR(-ENODEV);
+                return NULL;
         }
 
         of_node_put(endpoint);
@@ -262,14 +265,12 @@ static int mdp4_modeset_init_intf(struct mdp4_kms *mdp4_kms,
         switch (intf_type) {
         case DRM_MODE_ENCODER_LVDS:
                 /*
-                 * bail out early if:
-                 * - there is no panel node (no need to initialize lcdc
-                 *   encoder and lvds connector), or
-                 * - panel node is a bad pointer
+                 * bail out early if there is no panel node (no need to
+                 * initialize LCDC encoder and LVDS connector)
                  */
                 panel_node = mdp4_detect_lcdc_panel(dev);
-                if (IS_ERR_OR_NULL(panel_node))
-                        return PTR_ERR(panel_node);
+                if (!panel_node)
+                        return 0;
 
                 encoder = mdp4_lcdc_encoder_init(dev, panel_node);
                 if (IS_ERR(encoder)) {
diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c
index bc3d8e719c6c..a06b064f86c1 100644
--- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c
+++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c
@@ -93,7 +93,7 @@ static const struct drm_encoder_funcs mdp4_lcdc_encoder_funcs = {
 };
 
 /* this should probably be a helper: */
-struct drm_connector *get_connector(struct drm_encoder *encoder)
+static struct drm_connector *get_connector(struct drm_encoder *encoder)
 {
         struct drm_device *dev = encoder->dev;
         struct drm_connector *connector;
diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c
index 9f96dfe67769..3903dbcda763 100644
--- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c
+++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c
@@ -81,7 +81,7 @@ static void mdp4_plane_install_properties(struct drm_plane *plane,
         // XXX
 }
 
-int mdp4_plane_set_property(struct drm_plane *plane,
+static int mdp4_plane_set_property(struct drm_plane *plane,
                 struct drm_property *property, uint64_t val)
 {
         // XXX
@@ -99,7 +99,7 @@ static const struct drm_plane_funcs mdp4_plane_funcs = {
 };
 
 static int mdp4_plane_prepare_fb(struct drm_plane *plane,
-                const struct drm_plane_state *new_state)
+                                 struct drm_plane_state *new_state)
 {
         struct mdp4_plane *mdp4_plane = to_mdp4_plane(plane);
         struct mdp4_kms *mdp4_kms = get_kms(plane);
@@ -113,7 +113,7 @@ static int mdp4_plane_prepare_fb(struct drm_plane *plane,
 }
 
 static void mdp4_plane_cleanup_fb(struct drm_plane *plane,
-                const struct drm_plane_state *old_state)
+                                  struct drm_plane_state *old_state)
 {
         struct mdp4_plane *mdp4_plane = to_mdp4_plane(plane);
         struct mdp4_kms *mdp4_kms = get_kms(plane);
diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
index 432c09836b0e..951c002b05df 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
@@ -78,12 +78,12 @@ static void mdp5_plane_install_rotation_property(struct drm_device *dev,
         if (!dev->mode_config.rotation_property)
                 dev->mode_config.rotation_property =
                         drm_mode_create_rotation_property(dev,
-                        BIT(DRM_REFLECT_X) | BIT(DRM_REFLECT_Y));
+                                DRM_ROTATE_0 | DRM_REFLECT_X | DRM_REFLECT_Y);
 
         if (dev->mode_config.rotation_property)
                 drm_object_attach_property(&plane->base,
                         dev->mode_config.rotation_property,
-                        0);
+                        DRM_ROTATE_0);
 }
 
 /* helper to install properties which are common to planes and crtcs */
@@ -250,7 +250,7 @@ static const struct drm_plane_funcs mdp5_plane_funcs = {
 };
 
 static int mdp5_plane_prepare_fb(struct drm_plane *plane,
-                const struct drm_plane_state *new_state)
+                                 struct drm_plane_state *new_state)
 {
         struct mdp5_plane *mdp5_plane = to_mdp5_plane(plane);
         struct mdp5_kms *mdp5_kms = get_kms(plane);
@@ -264,7 +264,7 @@ static int mdp5_plane_prepare_fb(struct drm_plane *plane,
 }
 
 static void mdp5_plane_cleanup_fb(struct drm_plane *plane,
-                const struct drm_plane_state *old_state)
+                                  struct drm_plane_state *old_state)
 {
         struct mdp5_plane *mdp5_plane = to_mdp5_plane(plane);
         struct mdp5_kms *mdp5_kms = get_kms(plane);
@@ -309,8 +309,8 @@ static int mdp5_plane_atomic_check(struct drm_plane *plane,
                         return -EINVAL;
                 }
 
-                hflip = !!(state->rotation & BIT(DRM_REFLECT_X));
-                vflip = !!(state->rotation & BIT(DRM_REFLECT_Y));
+                hflip = !!(state->rotation & DRM_REFLECT_X);
+                vflip = !!(state->rotation & DRM_REFLECT_Y);
                 if ((vflip && !(mdp5_plane->caps & MDP_PIPE_CAP_VFLIP)) ||
                         (hflip && !(mdp5_plane->caps & MDP_PIPE_CAP_HFLIP))) {
                         dev_err(plane->dev->dev,
@@ -743,8 +743,8 @@ static int mdp5_plane_mode_set(struct drm_plane *plane,
         config |= get_scale_config(format, src_h, crtc_h, false);
         DBG("scale config = %x", config);
 
-        hflip = !!(pstate->rotation & BIT(DRM_REFLECT_X));
-        vflip = !!(pstate->rotation & BIT(DRM_REFLECT_Y));
+        hflip = !!(pstate->rotation & DRM_REFLECT_X);
+        vflip = !!(pstate->rotation & DRM_REFLECT_Y);
 
         spin_lock_irqsave(&mdp5_plane->pipe_lock, flags);
 
diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c
index 4a8a6f1f1151..73bae382eac3 100644
--- a/drivers/gpu/drm/msm/msm_atomic.c
+++ b/drivers/gpu/drm/msm/msm_atomic.c
@@ -112,13 +112,13 @@ static void complete_commit(struct msm_commit *c, bool async)
         struct msm_drm_private *priv = dev->dev_private;
         struct msm_kms *kms = priv->kms;
 
-        drm_atomic_helper_wait_for_fences(dev, state);
+        drm_atomic_helper_wait_for_fences(dev, state, false);
 
         kms->funcs->prepare_commit(kms, state);
 
         drm_atomic_helper_commit_modeset_disables(dev, state);
 
-        drm_atomic_helper_commit_planes(dev, state, false);
+        drm_atomic_helper_commit_planes(dev, state, 0);
 
         drm_atomic_helper_commit_modeset_enables(dev, state);
 
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 8a0237008f74..fb5c0b0a7594 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -26,9 +26,10 @@
  * MSM driver version:
  * - 1.0.0 - initial interface
  * - 1.1.0 - adds madvise, and support for submits with > 4 cmd buffers
+ * - 1.2.0 - adds explicit fence support for submit ioctl
  */
 #define MSM_VERSION_MAJOR       1
-#define MSM_VERSION_MINOR       1
+#define MSM_VERSION_MINOR       2
 #define MSM_VERSION_PATCHLEVEL  0
 
 static void msm_fb_output_poll_changed(struct drm_device *dev)
@@ -347,9 +348,9 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
         int ret;
 
         ddev = drm_dev_alloc(drv, dev);
-        if (!ddev) {
+        if (IS_ERR(ddev)) {
                 dev_err(dev, "failed to allocate drm_device\n");
-                return -ENOMEM;
+                return PTR_ERR(ddev);
         }
 
         platform_set_drvdata(pdev, ddev);
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index 85f3047e05ae..b6ac27e31929 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -593,18 +593,16 @@ int msm_gem_cpu_prep(struct drm_gem_object *obj, uint32_t op, ktime_t *timeout)
 {
         struct msm_gem_object *msm_obj = to_msm_bo(obj);
         bool write = !!(op & MSM_PREP_WRITE);
-
-        if (op & MSM_PREP_NOSYNC) {
-                if (!reservation_object_test_signaled_rcu(msm_obj->resv, write))
-                        return -EBUSY;
-        } else {
-                int ret;
-
-                ret = reservation_object_wait_timeout_rcu(msm_obj->resv, write,
-                                true, timeout_to_jiffies(timeout));
-                if (ret <= 0)
-                        return ret == 0 ? -ETIMEDOUT : ret;
-        }
+        unsigned long remain =
+                op & MSM_PREP_NOSYNC ? 0 : timeout_to_jiffies(timeout);
+        long ret;
+
+        ret = reservation_object_wait_timeout_rcu(msm_obj->resv, write,
+                                                  true,  remain);
+        if (ret == 0)
+                return remain == 0 ? -EBUSY : -ETIMEDOUT;
+        else if (ret < 0)
+                return ret;
 
         /* TODO cache maintenance */
 
diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c
index 880d6a9af7c8..b6a0f37a65f3 100644
--- a/drivers/gpu/drm/msm/msm_gem_submit.c
+++ b/drivers/gpu/drm/msm/msm_gem_submit.c
@@ -15,6 +15,8 @@
  * this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <linux/sync_file.h>
+
 #include "msm_drv.h"
 #include "msm_gpu.h"
 #include "msm_gem.h"
@@ -378,6 +380,9 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
         struct msm_file_private *ctx = file->driver_priv;
         struct msm_gem_submit *submit;
         struct msm_gpu *gpu = priv->gpu;
+        struct fence *in_fence = NULL;
+        struct sync_file *sync_file = NULL;
+        int out_fence_fd = -1;
         unsigned i;
         int ret;
 
@@ -387,13 +392,23 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
         /* for now, we just have 3d pipe.. eventually this would need to
          * be more clever to dispatch to appropriate gpu module:
          */
-        if (args->pipe != MSM_PIPE_3D0)
+        if (MSM_PIPE_ID(args->flags) != MSM_PIPE_3D0)
+                return -EINVAL;
+
+        if (MSM_PIPE_FLAGS(args->flags) & ~MSM_SUBMIT_FLAGS)
                 return -EINVAL;
 
         ret = mutex_lock_interruptible(&dev->struct_mutex);
         if (ret)
                 return ret;
 
+        if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
+                out_fence_fd = get_unused_fd_flags(O_CLOEXEC);
+                if (out_fence_fd < 0) {
+                        ret = out_fence_fd;
+                        goto out_unlock;
+                }
+        }
         priv->struct_mutex_task = current;
 
         submit = submit_create(dev, gpu, args->nr_bos, args->nr_cmds);
@@ -410,9 +425,32 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
         if (ret)
                 goto out;
 
-        ret = submit_fence_sync(submit);
-        if (ret)
-                goto out;
+        if (args->flags & MSM_SUBMIT_FENCE_FD_IN) {
+                in_fence = sync_file_get_fence(args->fence_fd);
+
+                if (!in_fence) {
+                        ret = -EINVAL;
+                        goto out;
+                }
+
+                /* TODO if we get an array-fence due to userspace merging multiple
+                 * fences, we need a way to determine if all the backing fences
+                 * are from our own context..
+                 */
+
+                if (in_fence->context != gpu->fctx->context) {
+                        ret = fence_wait(in_fence, true);
+                        if (ret)
+                                goto out;
+                }
+
+        }
+
+        if (!(args->fence & MSM_SUBMIT_NO_IMPLICIT)) {
+                ret = submit_fence_sync(submit);
+                if (ret)
+                        goto out;
+        }
 
         ret = submit_pin_objects(submit);
         if (ret)
@@ -478,15 +516,39 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
 
         submit->nr_cmds = i;
 
-        ret = msm_gpu_submit(gpu, submit, ctx);
+        submit->fence = msm_fence_alloc(gpu->fctx);
+        if (IS_ERR(submit->fence)) {
+                ret = PTR_ERR(submit->fence);
+                submit->fence = NULL;
+                goto out;
+        }
+
+        if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
+                sync_file = sync_file_create(submit->fence);
+                if (!sync_file) {
+                        ret = -ENOMEM;
+                        goto out;
+                }
+        }
+
+        msm_gpu_submit(gpu, submit, ctx);
 
         args->fence = submit->fence->seqno;
 
+        if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
+                fd_install(out_fence_fd, sync_file->file);
+                args->fence_fd = out_fence_fd;
+        }
+
 out:
+        if (in_fence)
+                fence_put(in_fence);
         submit_cleanup(submit);
         if (ret)
                 msm_gem_submit_free(submit);
 out_unlock:
+        if (ret && (out_fence_fd >= 0))
+                put_unused_fd(out_fence_fd);
         priv->struct_mutex_task = NULL;
         mutex_unlock(&dev->struct_mutex);
         return ret;
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
index 36ed53e661fe..5bb09838b5ae 100644
--- a/drivers/gpu/drm/msm/msm_gpu.c
+++ b/drivers/gpu/drm/msm/msm_gpu.c
@@ -509,22 +509,15 @@ void msm_gpu_retire(struct msm_gpu *gpu)
 }
 
 /* add bo's to gpu's ring, and kick gpu: */
-int msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit,
+void msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit,
                 struct msm_file_private *ctx)
 {
         struct drm_device *dev = gpu->dev;
         struct msm_drm_private *priv = dev->dev_private;
-        int i, ret;
+        int i;
 
         WARN_ON(!mutex_is_locked(&dev->struct_mutex));
 
-        submit->fence = msm_fence_alloc(gpu->fctx);
-        if (IS_ERR(submit->fence)) {
-                ret = PTR_ERR(submit->fence);
-                submit->fence = NULL;
-                return ret;
-        }
-
         inactive_cancel(gpu);
 
         list_add_tail(&submit->node, &gpu->submit_list);
@@ -557,8 +550,6 @@ int msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit,
         priv->lastctx = ctx;
 
         hangcheck_timer_reset(gpu);
-
-        return 0;
 }
 
 /*
diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h
index c9022837a1a4..d61d98a6e047 100644
--- a/drivers/gpu/drm/msm/msm_gpu.h
+++ b/drivers/gpu/drm/msm/msm_gpu.h
@@ -163,7 +163,7 @@ int msm_gpu_perfcntr_sample(struct msm_gpu *gpu, uint32_t *activetime,
                 uint32_t *totaltime, uint32_t ncntrs, uint32_t *cntrs);
 
 void msm_gpu_retire(struct msm_gpu *gpu);
-int msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit,
+void msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit,
                 struct msm_file_private *ctx);
 
 int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev,