diff options
author | Baoyou Xie <baoyou.xie@linaro.org> | 2016-09-07 06:58:44 -0400 |
---|---|---|
committer | Rob Clark <robdclark@gmail.com> | 2016-09-15 17:21:11 -0400 |
commit | 14edbde1a6cd46258126c82fcbf88a533a810611 (patch) | |
tree | 555e7508e40b6f0ee1c5fcfdc786fdd34f4af916 /drivers/gpu/drm/msm | |
parent | f755e227dc0ad9f2b58937db489b9a6f6c7b76d9 (diff) |
drm/msm/mdp4: mark symbols static where possible
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c:96:23: warning: no previous prototype for 'get_connector' [-Wmissing-prototypes]
drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c:84:5: warning: no previous prototype for 'mdp4_plane_set_property' [-Wmissing-prototypes]
In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Diffstat (limited to 'drivers/gpu/drm/msm')
-rw-r--r-- | drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c index bc3d8e719c6c..a06b064f86c1 100644 --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c | |||
@@ -93,7 +93,7 @@ static const struct drm_encoder_funcs mdp4_lcdc_encoder_funcs = { | |||
93 | }; | 93 | }; |
94 | 94 | ||
95 | /* this should probably be a helper: */ | 95 | /* this should probably be a helper: */ |
96 | struct drm_connector *get_connector(struct drm_encoder *encoder) | 96 | static struct drm_connector *get_connector(struct drm_encoder *encoder) |
97 | { | 97 | { |
98 | struct drm_device *dev = encoder->dev; | 98 | struct drm_device *dev = encoder->dev; |
99 | struct drm_connector *connector; | 99 | struct drm_connector *connector; |
diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c index 7c9626d92019..3903dbcda763 100644 --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | |||
@@ -81,7 +81,7 @@ static void mdp4_plane_install_properties(struct drm_plane *plane, | |||
81 | // XXX | 81 | // XXX |
82 | } | 82 | } |
83 | 83 | ||
84 | int mdp4_plane_set_property(struct drm_plane *plane, | 84 | static int mdp4_plane_set_property(struct drm_plane *plane, |
85 | struct drm_property *property, uint64_t val) | 85 | struct drm_property *property, uint64_t val) |
86 | { | 86 | { |
87 | // XXX | 87 | // XXX |