aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915
diff options
context:
space:
mode:
authorImre Deak <imre.deak@intel.com>2015-12-15 13:10:34 -0500
committerImre Deak <imre.deak@intel.com>2015-12-17 08:59:44 -0500
commitc9b8846a29c82c080b80119b7f85c37a9eb3457f (patch)
tree3be96020369424d64d39122cf8ad6fd12385abf7 /drivers/gpu/drm/i915
parentda5827c366073d17ab38ac6ceea6a3f48e6b5d78 (diff)
drm/i915: use assert_rpm_wakelock_held instead of opencoding it
Signed-off-by: Imre Deak <imre.deak@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Link: http://patchwork.freedesktop.org/patch/msgid/1450203038-5150-7-git-send-email-imre.deak@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915')
-rw-r--r--drivers/gpu/drm/i915/intel_runtime_pm.c10
-rw-r--r--drivers/gpu/drm/i915/intel_uncore.c2
2 files changed, 5 insertions, 7 deletions
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index cc0492e02d97..270513385ae9 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -538,8 +538,7 @@ static void assert_can_enable_dc5(struct drm_i915_private *dev_priv)
538 538
539 WARN_ONCE((I915_READ(DC_STATE_EN) & DC_STATE_EN_UPTO_DC5), 539 WARN_ONCE((I915_READ(DC_STATE_EN) & DC_STATE_EN_UPTO_DC5),
540 "DC5 already programmed to be enabled.\n"); 540 "DC5 already programmed to be enabled.\n");
541 WARN_ONCE(dev_priv->pm.suspended, 541 assert_rpm_wakelock_held(dev_priv);
542 "DC5 cannot be enabled, if platform is runtime-suspended.\n");
543 542
544 assert_csr_loaded(dev_priv); 543 assert_csr_loaded(dev_priv);
545} 544}
@@ -553,8 +552,7 @@ static void assert_can_disable_dc5(struct drm_i915_private *dev_priv)
553 if (dev_priv->power_domains.initializing) 552 if (dev_priv->power_domains.initializing)
554 return; 553 return;
555 554
556 WARN_ONCE(dev_priv->pm.suspended, 555 assert_rpm_wakelock_held(dev_priv);
557 "Disabling of DC5 while platform is runtime-suspended should never happen.\n");
558} 556}
559 557
560static void gen9_enable_dc5(struct drm_i915_private *dev_priv) 558static void gen9_enable_dc5(struct drm_i915_private *dev_priv)
@@ -2242,7 +2240,7 @@ void intel_runtime_pm_get(struct drm_i915_private *dev_priv)
2242 struct device *device = &dev->pdev->dev; 2240 struct device *device = &dev->pdev->dev;
2243 2241
2244 pm_runtime_get_sync(device); 2242 pm_runtime_get_sync(device);
2245 WARN(dev_priv->pm.suspended, "Device still suspended.\n"); 2243 assert_rpm_wakelock_held(dev_priv);
2246} 2244}
2247 2245
2248/** 2246/**
@@ -2267,7 +2265,7 @@ void intel_runtime_pm_get_noresume(struct drm_i915_private *dev_priv)
2267 struct drm_device *dev = dev_priv->dev; 2265 struct drm_device *dev = dev_priv->dev;
2268 struct device *device = &dev->pdev->dev; 2266 struct device *device = &dev->pdev->dev;
2269 2267
2270 WARN(dev_priv->pm.suspended, "Getting nosync-ref while suspended.\n"); 2268 assert_rpm_wakelock_held(dev_priv);
2271 pm_runtime_get_noresume(device); 2269 pm_runtime_get_noresume(device);
2272} 2270}
2273 2271
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index 3c63d94e9dbf..277e60ae0e47 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -404,7 +404,7 @@ void intel_uncore_forcewake_get(struct drm_i915_private *dev_priv,
404 if (!dev_priv->uncore.funcs.force_wake_get) 404 if (!dev_priv->uncore.funcs.force_wake_get)
405 return; 405 return;
406 406
407 WARN_ON(dev_priv->pm.suspended); 407 assert_rpm_wakelock_held(dev_priv);
408 408
409 spin_lock_irqsave(&dev_priv->uncore.lock, irqflags); 409 spin_lock_irqsave(&dev_priv->uncore.lock, irqflags);
410 __intel_uncore_forcewake_get(dev_priv, fw_domains); 410 __intel_uncore_forcewake_get(dev_priv, fw_domains);