drm/i915: pipe config quirk infrastructure plus sdvo mode.flags fix

For various reasons the hw state readout might not be able to
faithfully match the hw state:
- broken hw (like the case which motivated this patch here where the
  sdvo encoder does not implemented mandatory functionality
  correctly).
- platforms which are not supported fully with the pipe config
  infrastructure
- if our code doesn't support a given hw configuration natively, e.g.
  special restrictions on the per-pipe panel fitters when they're used
  in high-quality scaling modes.

In all these cases both fastboot and the hw state cross checker need
to be aware of these cases and act accordingly. To be able to do this
add a new quirk flag to the pipe config structure.

The specific case at hand is an sdvo encoder which doesn't implement
the get_timings function, so adjusted_mode flags will be wrong. The
strange thing though is that the encoder _does_ work, even though it
doesn't implement any of the timings functions (so neither get nor
set, neither for input nor output timings).

Not that non-compliant sdvo encoder are any surprise at all ...

v2:
- Don't read random garbage from the dtd if the get_timings call
  failed (suggested by Chris).
- Still check the interlaced flag, that's read out from someplace
  else. We want maximal paranoia, after all.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

1 files changed, 13 insertions, 11 deletions

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index 5c816dd75bec..960358d8e336 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -1324,19 +1324,21 @@ static void intel_sdvo_get_config(struct intel_encoder *encoder,
 
         ret = intel_sdvo_get_input_timing(intel_sdvo, &dtd);
         if (!ret) {
+                /* Some sdvo encoders are not spec compliant and don't
+                 * implement the mandatory get_timings function. */
                 DRM_DEBUG_DRIVER("failed to retrieve SDVO DTD\n");
-                return;
-        }
-
-        if (dtd.part2.dtd_flags & DTD_FLAG_HSYNC_POSITIVE)
-                flags |= DRM_MODE_FLAG_PHSYNC;
-        else
-                flags |= DRM_MODE_FLAG_NHSYNC;
+                pipe_config->quirks |= PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS;
+        } else {
+                if (dtd.part2.dtd_flags & DTD_FLAG_HSYNC_POSITIVE)
+                        flags |= DRM_MODE_FLAG_PHSYNC;
+                else
+                        flags |= DRM_MODE_FLAG_NHSYNC;
 
-        if (dtd.part2.dtd_flags & DTD_FLAG_VSYNC_POSITIVE)
-                flags |= DRM_MODE_FLAG_PVSYNC;
-        else
-                flags |= DRM_MODE_FLAG_NVSYNC;
+                if (dtd.part2.dtd_flags & DTD_FLAG_VSYNC_POSITIVE)
+                        flags |= DRM_MODE_FLAG_PVSYNC;
+                else
+                        flags |= DRM_MODE_FLAG_NVSYNC;
+        }
 
         pipe_config->adjusted_mode.flags |= flags;