aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/intel_runtime_pm.c
diff options
context:
space:
mode:
authorImre Deak <imre.deak@intel.com>2018-08-06 05:58:36 -0400
committerImre Deak <imre.deak@intel.com>2018-08-08 06:41:40 -0400
commit3ae27f7e103d95a820061fa692d0fe53303ccf98 (patch)
treeec9491068916405d94f6399fc70c5da556707df7 /drivers/gpu/drm/i915/intel_runtime_pm.c
parent48a287ed9d624d8eae65e2dd1b12915b2b853644 (diff)
drm/i915/vlv: Remove redundant power well ID asserts
The callbacks these asserts are called from are used from a single power well, so not much point in checking that. The check also requires a unique power well ID that we would need to keep around only for this purpose. (A follow-up patch removes power well IDs not needed for direct power well access). Cc: Ville Syrjala <ville.syrjala@linux.intel.com> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> Cc: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180806095843.13294-4-imre.deak@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_runtime_pm.c')
-rw-r--r--drivers/gpu/drm/i915/intel_runtime_pm.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index e82aa38bfd23..b2d182cc3319 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -1045,8 +1045,6 @@ static void vlv_display_power_well_deinit(struct drm_i915_private *dev_priv)
1045static void vlv_display_power_well_enable(struct drm_i915_private *dev_priv, 1045static void vlv_display_power_well_enable(struct drm_i915_private *dev_priv,
1046 struct i915_power_well *power_well) 1046 struct i915_power_well *power_well)
1047{ 1047{
1048 WARN_ON_ONCE(power_well->id != PUNIT_POWER_WELL_DISP2D);
1049
1050 vlv_set_power_well(dev_priv, power_well, true); 1048 vlv_set_power_well(dev_priv, power_well, true);
1051 1049
1052 vlv_display_power_well_init(dev_priv); 1050 vlv_display_power_well_init(dev_priv);
@@ -1055,8 +1053,6 @@ static void vlv_display_power_well_enable(struct drm_i915_private *dev_priv,
1055static void vlv_display_power_well_disable(struct drm_i915_private *dev_priv, 1053static void vlv_display_power_well_disable(struct drm_i915_private *dev_priv,
1056 struct i915_power_well *power_well) 1054 struct i915_power_well *power_well)
1057{ 1055{
1058 WARN_ON_ONCE(power_well->id != PUNIT_POWER_WELL_DISP2D);
1059
1060 vlv_display_power_well_deinit(dev_priv); 1056 vlv_display_power_well_deinit(dev_priv);
1061 1057
1062 vlv_set_power_well(dev_priv, power_well, false); 1058 vlv_set_power_well(dev_priv, power_well, false);
@@ -1065,8 +1061,6 @@ static void vlv_display_power_well_disable(struct drm_i915_private *dev_priv,
1065static void vlv_dpio_cmn_power_well_enable(struct drm_i915_private *dev_priv, 1061static void vlv_dpio_cmn_power_well_enable(struct drm_i915_private *dev_priv,
1066 struct i915_power_well *power_well) 1062 struct i915_power_well *power_well)
1067{ 1063{
1068 WARN_ON_ONCE(power_well->id != PUNIT_POWER_WELL_DPIO_CMN_BC);
1069
1070 /* since ref/cri clock was enabled */ 1064 /* since ref/cri clock was enabled */
1071 udelay(1); /* >10ns for cmnreset, >0ns for sidereset */ 1065 udelay(1); /* >10ns for cmnreset, >0ns for sidereset */
1072 1066
@@ -1091,8 +1085,6 @@ static void vlv_dpio_cmn_power_well_disable(struct drm_i915_private *dev_priv,
1091{ 1085{
1092 enum pipe pipe; 1086 enum pipe pipe;
1093 1087
1094 WARN_ON_ONCE(power_well->id != PUNIT_POWER_WELL_DPIO_CMN_BC);
1095
1096 for_each_pipe(dev_priv, pipe) 1088 for_each_pipe(dev_priv, pipe)
1097 assert_pll_disabled(dev_priv, pipe); 1089 assert_pll_disabled(dev_priv, pipe);
1098 1090
@@ -1516,8 +1508,6 @@ out:
1516static void chv_pipe_power_well_enable(struct drm_i915_private *dev_priv, 1508static void chv_pipe_power_well_enable(struct drm_i915_private *dev_priv,
1517 struct i915_power_well *power_well) 1509 struct i915_power_well *power_well)
1518{ 1510{
1519 WARN_ON_ONCE(power_well->id != CHV_DISP_PW_PIPE_A);
1520
1521 chv_set_pipe_power_well(dev_priv, power_well, true); 1511 chv_set_pipe_power_well(dev_priv, power_well, true);
1522 1512
1523 vlv_display_power_well_init(dev_priv); 1513 vlv_display_power_well_init(dev_priv);
@@ -1526,8 +1516,6 @@ static void chv_pipe_power_well_enable(struct drm_i915_private *dev_priv,
1526static void chv_pipe_power_well_disable(struct drm_i915_private *dev_priv, 1516static void chv_pipe_power_well_disable(struct drm_i915_private *dev_priv,
1527 struct i915_power_well *power_well) 1517 struct i915_power_well *power_well)
1528{ 1518{
1529 WARN_ON_ONCE(power_well->id != CHV_DISP_PW_PIPE_A);
1530
1531 vlv_display_power_well_deinit(dev_priv); 1519 vlv_display_power_well_deinit(dev_priv);
1532 1520
1533 chv_set_pipe_power_well(dev_priv, power_well, false); 1521 chv_set_pipe_power_well(dev_priv, power_well, false);