diff options
author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2016-05-16 09:59:40 -0400 |
---|---|---|
committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2016-05-23 14:11:18 -0400 |
commit | 18a8067c5748054d7731957ec3c46697a6a9ac1b (patch) | |
tree | 752c3bb8516411650b987240e7bf3b273f808e20 /drivers/gpu/drm/i915/intel_runtime_pm.c | |
parent | d1b32c32e8943d18a104f347fbe40c46276011d9 (diff) |
drm/i915: Assert the dbuf is enabled when disabling DC5/6
Like with cdclk, the DMC is supposed to manage dbuf enabling/disabling.
Let's make sure it has correctly restored the dbuf state to enabled
when we disable the DC states.
v2: s/skl/gen9/ in function name (Imre)
Cc: Imre Deak <imre.deak@intel.com>
Suggested-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1463407180-28993-1-git-send-email-ville.syrjala@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_runtime_pm.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_runtime_pm.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index a1741182f924..fe8faf30bda7 100644 --- a/drivers/gpu/drm/i915/intel_runtime_pm.c +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c | |||
@@ -806,6 +806,15 @@ static bool gen9_dc_off_power_well_enabled(struct drm_i915_private *dev_priv, | |||
806 | return (I915_READ(DC_STATE_EN) & DC_STATE_EN_UPTO_DC5_DC6_MASK) == 0; | 806 | return (I915_READ(DC_STATE_EN) & DC_STATE_EN_UPTO_DC5_DC6_MASK) == 0; |
807 | } | 807 | } |
808 | 808 | ||
809 | static void gen9_assert_dbuf_enabled(struct drm_i915_private *dev_priv) | ||
810 | { | ||
811 | u32 tmp = I915_READ(DBUF_CTL); | ||
812 | |||
813 | WARN((tmp & (DBUF_POWER_STATE | DBUF_POWER_REQUEST)) != | ||
814 | (DBUF_POWER_STATE | DBUF_POWER_REQUEST), | ||
815 | "Unexpected DBuf power power state (0x%08x)\n", tmp); | ||
816 | } | ||
817 | |||
809 | static void gen9_dc_off_power_well_enable(struct drm_i915_private *dev_priv, | 818 | static void gen9_dc_off_power_well_enable(struct drm_i915_private *dev_priv, |
810 | struct i915_power_well *power_well) | 819 | struct i915_power_well *power_well) |
811 | { | 820 | { |
@@ -814,6 +823,8 @@ static void gen9_dc_off_power_well_enable(struct drm_i915_private *dev_priv, | |||
814 | WARN_ON(dev_priv->cdclk_freq != | 823 | WARN_ON(dev_priv->cdclk_freq != |
815 | dev_priv->display.get_display_clock_speed(dev_priv->dev)); | 824 | dev_priv->display.get_display_clock_speed(dev_priv->dev)); |
816 | 825 | ||
826 | gen9_assert_dbuf_enabled(dev_priv); | ||
827 | |||
817 | if (IS_BROXTON(dev_priv)) | 828 | if (IS_BROXTON(dev_priv)) |
818 | broxton_ddi_phy_verify_state(dev_priv); | 829 | broxton_ddi_phy_verify_state(dev_priv); |
819 | } | 830 | } |