aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/intel_runtime_pm.c
diff options
context:
space:
mode:
authorJesse Barnes <jbarnes@virtuousgeek.org>2015-09-23 17:37:17 -0400
committerDaniel Vetter <daniel.vetter@ffwll.ch>2015-09-30 04:20:01 -0400
commit165ed87c47ae7dd0deab53d552a29d7985569c28 (patch)
treeeab29a08047447cf4d1724a828a8bd95085e6d4b /drivers/gpu/drm/i915/intel_runtime_pm.c
parent0d44d3fa2b9089b0039118351773d465204ad581 (diff)
drm/i915: fixup runtime PM handling v2
According to the PCI docs and Rafael, we don't need to be doing explicit enables and disables in our init and teardown routines, as they're taken care of by the PCI core. So drop the pm_runtime_disable() at teardown and pm_runtime_set_active() at init. This fixes one failure of the basic-pci-d3-state test on my BYT. v2: drop extra get_noresume() and put_noidle() (Rafael) Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Acked-by: "Rafael J. Wysocki" <rjw@rjwysocki.net> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_runtime_pm.c')
-rw-r--r--drivers/gpu/drm/i915/intel_runtime_pm.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 4a815bb6cfca..e1fdbabaf2bf 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -1828,7 +1828,6 @@ static void intel_runtime_pm_disable(struct drm_i915_private *dev_priv)
1828 1828
1829 /* Make sure we're not suspended first. */ 1829 /* Make sure we're not suspended first. */
1830 pm_runtime_get_sync(device); 1830 pm_runtime_get_sync(device);
1831 pm_runtime_disable(device);
1832} 1831}
1833 1832
1834/** 1833/**
@@ -2120,8 +2119,6 @@ void intel_runtime_pm_enable(struct drm_i915_private *dev_priv)
2120 if (!HAS_RUNTIME_PM(dev)) 2119 if (!HAS_RUNTIME_PM(dev))
2121 return; 2120 return;
2122 2121
2123 pm_runtime_set_active(device);
2124
2125 /* 2122 /*
2126 * RPM depends on RC6 to save restore the GT HW context, so make RC6 a 2123 * RPM depends on RC6 to save restore the GT HW context, so make RC6 a
2127 * requirement. 2124 * requirement.