aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/intel_engine_cs.c
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2018-07-27 05:18:55 -0400
committerChris Wilson <chris@chris-wilson.co.uk>2018-07-27 06:05:28 -0400
commit7a859c655d8f9e83d95ad8e4722c0da6b29590d6 (patch)
tree6ada293e484fb5a50d854b92c19fee69b5c7a2e6 /drivers/gpu/drm/i915/intel_engine_cs.c
parent6dc17d69f83ec315157b76fbf47d4379e1266cef (diff)
drm/i915: Eliminate use of PAGE_SIZE as a virtual alignment
Using PAGE_SIZE for virtual offset alignment is superfluous as it is equal to the minimum gtt alignment and so equivalent to 0. It is also the wrong value to use as we stopped using physical page constructs for the virtual GTT, i.e. it would be preferrable to use I915_GTT_PAGE_SIZE and in these cases merely imply I915_GTT_MIN_ALIGNMENT. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Matthew Auld <matthew.auld@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180727091855.1879-1-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/intel_engine_cs.c')
-rw-r--r--drivers/gpu/drm/i915/intel_engine_cs.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index 734a789688da..67c4fc5d737c 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -513,7 +513,7 @@ int intel_engine_create_scratch(struct intel_engine_cs *engine,
513 goto err_unref; 513 goto err_unref;
514 } 514 }
515 515
516 ret = i915_vma_pin(vma, 0, 4096, PIN_GLOBAL | PIN_HIGH); 516 ret = i915_vma_pin(vma, 0, 0, PIN_GLOBAL | PIN_HIGH);
517 if (ret) 517 if (ret)
518 goto err_unref; 518 goto err_unref;
519 519
@@ -586,7 +586,7 @@ static int init_status_page(struct intel_engine_cs *engine)
586 flags |= PIN_MAPPABLE; 586 flags |= PIN_MAPPABLE;
587 else 587 else
588 flags |= PIN_HIGH; 588 flags |= PIN_HIGH;
589 ret = i915_vma_pin(vma, 0, 4096, flags); 589 ret = i915_vma_pin(vma, 0, 0, flags);
590 if (ret) 590 if (ret)
591 goto err; 591 goto err;
592 592