diff options
author | Lee, Shawn C <shawn.c.lee@intel.com> | 2018-09-12 02:22:50 -0400 |
---|---|---|
committer | Jani Nikula <jani.nikula@intel.com> | 2018-09-19 09:44:12 -0400 |
commit | 53ca2edcf033f3368b2dc0ef3cbcc2f47d556d13 (patch) | |
tree | c7a8b6e2c93bb03c8cd5b4d3eb5b68e2154a3fe0 /drivers/gpu/drm/i915/intel_dp_mst.c | |
parent | 0b49bbbd9f10dd5bcce126aa99041a44320767f7 (diff) |
drm: Change limited M/N quirk to constant N quirk.
Some DP dongles in particular seem to be fussy about too large
link M/N values. Set specific value for N divider can resolve
this issue per dongle vendor's comment. So configure N as
constant value (0x8000) to instead of reduce M/N formula when
specific DP dongle connected.
v2: add more comments for issue description and fix typo.
v3: add lost commit messages back for version 2
v4: send patch to both intel-gfx and dri-devel
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Clint Taylor <clinton.a.taylor@intel.com>
Tested-by: Clint Taylor <clinton.a.taylor@intel.com>
Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1536733371-25004-3-git-send-email-shawn.c.lee@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_dp_mst.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_dp_mst.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c index 7e3e01607643..b7505879b1f7 100644 --- a/drivers/gpu/drm/i915/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/intel_dp_mst.c | |||
@@ -45,8 +45,8 @@ static bool intel_dp_mst_compute_config(struct intel_encoder *encoder, | |||
45 | int lane_count, slots; | 45 | int lane_count, slots; |
46 | const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode; | 46 | const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode; |
47 | int mst_pbn; | 47 | int mst_pbn; |
48 | bool reduce_m_n = drm_dp_has_quirk(&intel_dp->desc, | 48 | bool constant_n = drm_dp_has_quirk(&intel_dp->desc, |
49 | DP_DPCD_QUIRK_LIMITED_M_N); | 49 | DP_DPCD_QUIRK_CONSTANT_N); |
50 | 50 | ||
51 | if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN) | 51 | if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN) |
52 | return false; | 52 | return false; |
@@ -87,7 +87,7 @@ static bool intel_dp_mst_compute_config(struct intel_encoder *encoder, | |||
87 | adjusted_mode->crtc_clock, | 87 | adjusted_mode->crtc_clock, |
88 | pipe_config->port_clock, | 88 | pipe_config->port_clock, |
89 | &pipe_config->dp_m_n, | 89 | &pipe_config->dp_m_n, |
90 | reduce_m_n); | 90 | constant_n); |
91 | 91 | ||
92 | pipe_config->dp_m_n.tu = slots; | 92 | pipe_config->dp_m_n.tu = slots; |
93 | 93 | ||