diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-05-21 15:54:55 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-06-12 15:27:45 -0400 |
commit | 7df00d7adb080122502a30ec48f237d2f90d36ad (patch) | |
tree | ffa372cd69889ff49333ff2ea4c7a614c7396a37 /drivers/gpu/drm/i915/intel_display.c | |
parent | fdafa9e276235225ce087695984cf1e52dd0c159 (diff) |
drm/i915: pnv dpll doesn't use m1!
So don't try to store it in the DPLL_FP register.
Otherwise it looks like the limits for pineview are correct: It has
it's own clock computation code, which doesn't use an offset for n
divisors, and the register value based m limits look sane enough.
v2: Rebase on top of the pineview clock refactor and fixup up the
commit message: It's m1 pnv doens't care about, not m2!
Quoting Damien's review:
- "n can vary between 2 and 6, but we declare the 3-6 as limits.
- "p1 seems to be able to go up to 9
- "the m upper limit seems a bit big, but the docs are a bit shy on
that values for pnv.
"Otherwise, the change itself seems good:"
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_display.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index bef9086bf542..1dfaa1c5fa41 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
@@ -4240,7 +4240,7 @@ static int i9xx_get_refclk(struct drm_crtc *crtc, int num_connectors) | |||
4240 | 4240 | ||
4241 | static uint32_t pnv_dpll_compute_fp(struct dpll *dpll) | 4241 | static uint32_t pnv_dpll_compute_fp(struct dpll *dpll) |
4242 | { | 4242 | { |
4243 | return (1 << dpll->n) << 16 | dpll->m1 << 8 | dpll->m2; | 4243 | return (1 << dpll->n) << 16 | dpll->m2; |
4244 | } | 4244 | } |
4245 | 4245 | ||
4246 | static uint32_t i9xx_dpll_compute_fp(struct dpll *dpll) | 4246 | static uint32_t i9xx_dpll_compute_fp(struct dpll *dpll) |