Merge tag 'drm-next-2019-05-16' of git://anongit.freedesktop.org/drm/drm

Pull drm fixes from Dave Airlie:
 "A bunch of fixes for the merge window closure, doesn't seem to be
  anything too major or serious in there.

  It does add TU117 turing modesetting to nouveau but it's just an
  enable for preexisting code.

  amdgpu:
   - gpu reset at load crash fix
   - ATPX hotplug fix for when dGPU is off
   - SR-IOV fixes

  radeon:
   - r5xx pll fixes

  i915:
   - GVT (MCHBAR, buffer alignment, misc warnings fixes)
   - Fixes for newly enabled semaphore code
   - Geminilake disable framebuffer compression
   - HSW edp fast modeset fix
   - IRQ vs RCU race fix

  nouveau:
   - Turing modesetting fixes
   - TU117 support

  msm:
   - SDM845 bringup fixes

  panfrost:
   - static checker fixes

  pl111:
   - spinlock init fix.

  bridge:
   - refresh rate register fix for adv7511"

* tag 'drm-next-2019-05-16' of git://anongit.freedesktop.org/drm/drm: (36 commits)
  drm/msm: Upgrade gxpd checks to IS_ERR_OR_NULL
  drm/msm/dpu: Remove duplicate header
  drm/pl111: Initialize clock spinlock early
  drm/msm: correct attempted NULL pointer dereference in debugfs
  drm/msm: remove resv fields from msm_gem_object struct
  drm/nouveau: fix duplication of nv50_head_atom struct
  drm/nouveau/disp/dp: respect sink limits when selecting failsafe link configuration
  drm/nouveau/core: initial support for boards with TU117 chipset
  drm/nouveau/core: allow detected chipset to be overridden
  drm/nouveau/kms/gf119-gp10x: push HeadSetControlOutputResource() mthd when encoders change
  drm/nouveau/kms/nv50-: fix bug preventing non-vsync'd page flips
  drm/nouveau/kms/gv100-: fix spurious window immediate interlocks
  drm/bridge: adv7511: Fix low refresh rate selection
  drm/panfrost: Add missing _fini() calls in panfrost_device_fini()
  drm/panfrost: Only put sync_out if non-NULL
  drm/i915: Seal races between async GPU cancellation, retirement and signaling
  drm/i915: Fix fastset vs. pfit on/off on HSW EDP transcoder
  drm/i915/fbc: disable framebuffer compression on GeminiLake
  drm/amdgpu/psp: move psp version specific function pointers to early_init
  drm/radeon: prefer lower reference dividers
  ...

1 files changed, 57 insertions, 21 deletions

diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c
index 3cbffd400b1b..832cb6b1e9bd 100644
--- a/drivers/gpu/drm/i915/intel_breadcrumbs.c
+++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c
@@ -23,6 +23,7 @@
  */
 
 #include <linux/kthread.h>
+#include <trace/events/dma_fence.h>
 #include <uapi/linux/sched/types.h>
 
 #include "i915_drv.h"
@@ -80,9 +81,39 @@ static inline bool __request_completed(const struct i915_request *rq)
         return i915_seqno_passed(__hwsp_seqno(rq), rq->fence.seqno);
 }
 
+static bool
+__dma_fence_signal(struct dma_fence *fence)
+{
+        return !test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
+}
+
+static void
+__dma_fence_signal__timestamp(struct dma_fence *fence, ktime_t timestamp)
+{
+        fence->timestamp = timestamp;
+        set_bit(DMA_FENCE_FLAG_TIMESTAMP_BIT, &fence->flags);
+        trace_dma_fence_signaled(fence);
+}
+
+static void
+__dma_fence_signal__notify(struct dma_fence *fence)
+{
+        struct dma_fence_cb *cur, *tmp;
+
+        lockdep_assert_held(fence->lock);
+        lockdep_assert_irqs_disabled();
+
+        list_for_each_entry_safe(cur, tmp, &fence->cb_list, node) {
+                INIT_LIST_HEAD(&cur->node);
+                cur->func(fence, cur);
+        }
+        INIT_LIST_HEAD(&fence->cb_list);
+}
+
 void intel_engine_breadcrumbs_irq(struct intel_engine_cs *engine)
 {
         struct intel_breadcrumbs *b = &engine->breadcrumbs;
+        const ktime_t timestamp = ktime_get();
         struct intel_context *ce, *cn;
         struct list_head *pos, *next;
         LIST_HEAD(signal);
@@ -104,6 +135,10 @@ void intel_engine_breadcrumbs_irq(struct intel_engine_cs *engine)
 
                         GEM_BUG_ON(!test_bit(I915_FENCE_FLAG_SIGNAL,
                                              &rq->fence.flags));
+                        clear_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
+
+                        if (!__dma_fence_signal(&rq->fence))
+                                continue;
 
                         /*
                          * Queue for execution after dropping the signaling
@@ -111,14 +146,6 @@ void intel_engine_breadcrumbs_irq(struct intel_engine_cs *engine)
                          * more signalers to the same context or engine.
                          */
                         i915_request_get(rq);
-
-                        /*
-                         * We may race with direct invocation of
-                         * dma_fence_signal(), e.g. i915_request_retire(),
-                         * so we need to acquire our reference to the request
-                         * before we cancel the breadcrumb.
-                         */
-                        clear_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
                         list_add_tail(&rq->signal_link, &signal);
                 }
 
@@ -141,7 +168,12 @@ void intel_engine_breadcrumbs_irq(struct intel_engine_cs *engine)
                 struct i915_request *rq =
                         list_entry(pos, typeof(*rq), signal_link);
 
-                dma_fence_signal(&rq->fence);
+                __dma_fence_signal__timestamp(&rq->fence, timestamp);
+
+                spin_lock(&rq->lock);
+                __dma_fence_signal__notify(&rq->fence);
+                spin_unlock(&rq->lock);
+
                 i915_request_put(rq);
         }
 }
@@ -243,19 +275,17 @@ void intel_engine_fini_breadcrumbs(struct intel_engine_cs *engine)
 
 bool i915_request_enable_breadcrumb(struct i915_request *rq)
 {
-        struct intel_breadcrumbs *b = &rq->engine->breadcrumbs;
-
-        GEM_BUG_ON(test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags));
+        lockdep_assert_held(&rq->lock);
+        lockdep_assert_irqs_disabled();
 
-        if (!test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags))
-                return true;
-
-        spin_lock(&b->irq_lock);
-        if (test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags) &&
-            !__request_completed(rq)) {
+        if (test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags)) {
+                struct intel_breadcrumbs *b = &rq->engine->breadcrumbs;
                 struct intel_context *ce = rq->hw_context;
                 struct list_head *pos;
 
+                spin_lock(&b->irq_lock);
+                GEM_BUG_ON(test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags));
+
                 __intel_breadcrumbs_arm_irq(b);
 
                 /*
@@ -284,8 +314,8 @@ bool i915_request_enable_breadcrumb(struct i915_request *rq)
                         list_move_tail(&ce->signal_link, &b->signalers);
 
                 set_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
+                spin_unlock(&b->irq_lock);
         }
-        spin_unlock(&b->irq_lock);
 
         return !__request_completed(rq);
 }
@@ -294,9 +324,15 @@ void i915_request_cancel_breadcrumb(struct i915_request *rq)
 {
         struct intel_breadcrumbs *b = &rq->engine->breadcrumbs;
 
-        if (!test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags))
-                return;
+        lockdep_assert_held(&rq->lock);
+        lockdep_assert_irqs_disabled();
 
+        /*
+         * We must wait for b->irq_lock so that we know the interrupt handler
+         * has released its reference to the intel_context and has completed
+         * the DMA_FENCE_FLAG_SIGNALED_BIT/I915_FENCE_FLAG_SIGNAL dance (if
+         * required).
+         */
         spin_lock(&b->irq_lock);
         if (test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags)) {
                 struct intel_context *ce = rq->hw_context;