diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2019-01-28 13:18:07 -0500 |
---|---|---|
committer | Chris Wilson <chris@chris-wilson.co.uk> | 2019-01-28 14:06:59 -0500 |
commit | 3adac4689f58cb3fb666d92dff0ee73cc97d24d7 (patch) | |
tree | 90bc29f50d97398999529cfd070c7944ec89f9c1 /drivers/gpu/drm/i915/i915_request.c | |
parent | 1e345568e3b541e19202caadae8d2cb2237e7ed8 (diff) |
drm/i915: Introduce concept of per-timeline (context) HWSP
Supplement the per-engine HWSP with a per-timeline HWSP. That is a
per-request pointer through which we can check a local seqno,
abstracting away the presumption of a global seqno. In this first step,
we point each request back into the engine's HWSP so everything
continues to work with the global timeline.
v2: s/i915_request_hwsp/hwsp_seqno/ to emphasis that this is the current
HW value and that we are accessing it via i915_request merely as a
convenience.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190128181812.22804-1-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/i915_request.c')
-rw-r--r-- | drivers/gpu/drm/i915/i915_request.c | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index f4241a17e2ad..a076fd0b7ba6 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c | |||
@@ -182,10 +182,11 @@ static void free_capture_list(struct i915_request *request) | |||
182 | static void __retire_engine_request(struct intel_engine_cs *engine, | 182 | static void __retire_engine_request(struct intel_engine_cs *engine, |
183 | struct i915_request *rq) | 183 | struct i915_request *rq) |
184 | { | 184 | { |
185 | GEM_TRACE("%s(%s) fence %llx:%lld, global=%d, current %d\n", | 185 | GEM_TRACE("%s(%s) fence %llx:%lld, global=%d, current %d:%d\n", |
186 | __func__, engine->name, | 186 | __func__, engine->name, |
187 | rq->fence.context, rq->fence.seqno, | 187 | rq->fence.context, rq->fence.seqno, |
188 | rq->global_seqno, | 188 | rq->global_seqno, |
189 | hwsp_seqno(rq), | ||
189 | intel_engine_get_seqno(engine)); | 190 | intel_engine_get_seqno(engine)); |
190 | 191 | ||
191 | GEM_BUG_ON(!i915_request_completed(rq)); | 192 | GEM_BUG_ON(!i915_request_completed(rq)); |
@@ -244,10 +245,11 @@ static void i915_request_retire(struct i915_request *request) | |||
244 | { | 245 | { |
245 | struct i915_gem_active *active, *next; | 246 | struct i915_gem_active *active, *next; |
246 | 247 | ||
247 | GEM_TRACE("%s fence %llx:%lld, global=%d, current %d\n", | 248 | GEM_TRACE("%s fence %llx:%lld, global=%d, current %d:%d\n", |
248 | request->engine->name, | 249 | request->engine->name, |
249 | request->fence.context, request->fence.seqno, | 250 | request->fence.context, request->fence.seqno, |
250 | request->global_seqno, | 251 | request->global_seqno, |
252 | hwsp_seqno(request), | ||
251 | intel_engine_get_seqno(request->engine)); | 253 | intel_engine_get_seqno(request->engine)); |
252 | 254 | ||
253 | lockdep_assert_held(&request->i915->drm.struct_mutex); | 255 | lockdep_assert_held(&request->i915->drm.struct_mutex); |
@@ -307,10 +309,11 @@ void i915_request_retire_upto(struct i915_request *rq) | |||
307 | struct intel_ring *ring = rq->ring; | 309 | struct intel_ring *ring = rq->ring; |
308 | struct i915_request *tmp; | 310 | struct i915_request *tmp; |
309 | 311 | ||
310 | GEM_TRACE("%s fence %llx:%lld, global=%d, current %d\n", | 312 | GEM_TRACE("%s fence %llx:%lld, global=%d, current %d:%d\n", |
311 | rq->engine->name, | 313 | rq->engine->name, |
312 | rq->fence.context, rq->fence.seqno, | 314 | rq->fence.context, rq->fence.seqno, |
313 | rq->global_seqno, | 315 | rq->global_seqno, |
316 | hwsp_seqno(rq), | ||
314 | intel_engine_get_seqno(rq->engine)); | 317 | intel_engine_get_seqno(rq->engine)); |
315 | 318 | ||
316 | lockdep_assert_held(&rq->i915->drm.struct_mutex); | 319 | lockdep_assert_held(&rq->i915->drm.struct_mutex); |
@@ -355,10 +358,11 @@ void __i915_request_submit(struct i915_request *request) | |||
355 | struct intel_engine_cs *engine = request->engine; | 358 | struct intel_engine_cs *engine = request->engine; |
356 | u32 seqno; | 359 | u32 seqno; |
357 | 360 | ||
358 | GEM_TRACE("%s fence %llx:%lld -> global=%d, current %d\n", | 361 | GEM_TRACE("%s fence %llx:%lld -> global=%d, current %d:%d\n", |
359 | engine->name, | 362 | engine->name, |
360 | request->fence.context, request->fence.seqno, | 363 | request->fence.context, request->fence.seqno, |
361 | engine->timeline.seqno + 1, | 364 | engine->timeline.seqno + 1, |
365 | hwsp_seqno(request), | ||
362 | intel_engine_get_seqno(engine)); | 366 | intel_engine_get_seqno(engine)); |
363 | 367 | ||
364 | GEM_BUG_ON(!irqs_disabled()); | 368 | GEM_BUG_ON(!irqs_disabled()); |
@@ -405,10 +409,11 @@ void __i915_request_unsubmit(struct i915_request *request) | |||
405 | { | 409 | { |
406 | struct intel_engine_cs *engine = request->engine; | 410 | struct intel_engine_cs *engine = request->engine; |
407 | 411 | ||
408 | GEM_TRACE("%s fence %llx:%lld <- global=%d, current %d\n", | 412 | GEM_TRACE("%s fence %llx:%lld <- global=%d, current %d:%d\n", |
409 | engine->name, | 413 | engine->name, |
410 | request->fence.context, request->fence.seqno, | 414 | request->fence.context, request->fence.seqno, |
411 | request->global_seqno, | 415 | request->global_seqno, |
416 | hwsp_seqno(request), | ||
412 | intel_engine_get_seqno(engine)); | 417 | intel_engine_get_seqno(engine)); |
413 | 418 | ||
414 | GEM_BUG_ON(!irqs_disabled()); | 419 | GEM_BUG_ON(!irqs_disabled()); |
@@ -616,6 +621,7 @@ i915_request_alloc(struct intel_engine_cs *engine, struct i915_gem_context *ctx) | |||
616 | rq->ring = ce->ring; | 621 | rq->ring = ce->ring; |
617 | rq->timeline = ce->ring->timeline; | 622 | rq->timeline = ce->ring->timeline; |
618 | GEM_BUG_ON(rq->timeline == &engine->timeline); | 623 | GEM_BUG_ON(rq->timeline == &engine->timeline); |
624 | rq->hwsp_seqno = &engine->status_page.addr[I915_GEM_HWS_INDEX]; | ||
619 | 625 | ||
620 | spin_lock_init(&rq->lock); | 626 | spin_lock_init(&rq->lock); |
621 | dma_fence_init(&rq->fence, | 627 | dma_fence_init(&rq->fence, |