diff options
author | Jan Kara <jack@suse.cz> | 2016-12-14 18:07:01 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-12-14 19:04:09 -0500 |
commit | 1a29d85eb0f19b7d8271923d8917d7b4f5540b3e (patch) | |
tree | 76bf90e637fb4b0c95a7a9eb81bc9aec71329a4e /drivers/gpu/drm/etnaviv | |
parent | 82b0f8c39a3869b6fd2a10e180a862248736ec6f (diff) |
mm: use vmf->address instead of of vmf->virtual_address
Every single user of vmf->virtual_address typed that entry to unsigned
long before doing anything with it so the type of virtual_address does
not really provide us any additional safety. Just use masked
vmf->address which already has the appropriate type.
Link: http://lkml.kernel.org/r/1479460644-25076-3-git-send-email-jack@suse.cz
Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/gpu/drm/etnaviv')
-rw-r--r-- | drivers/gpu/drm/etnaviv/etnaviv_gem.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index 6f5dfabb3096..114dddbd297b 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c | |||
@@ -202,15 +202,14 @@ int etnaviv_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
202 | } | 202 | } |
203 | 203 | ||
204 | /* We don't use vmf->pgoff since that has the fake offset: */ | 204 | /* We don't use vmf->pgoff since that has the fake offset: */ |
205 | pgoff = ((unsigned long)vmf->virtual_address - | 205 | pgoff = (vmf->address - vma->vm_start) >> PAGE_SHIFT; |
206 | vma->vm_start) >> PAGE_SHIFT; | ||
207 | 206 | ||
208 | page = pages[pgoff]; | 207 | page = pages[pgoff]; |
209 | 208 | ||
210 | VERB("Inserting %p pfn %lx, pa %lx", vmf->virtual_address, | 209 | VERB("Inserting %p pfn %lx, pa %lx", (void *)vmf->address, |
211 | page_to_pfn(page), page_to_pfn(page) << PAGE_SHIFT); | 210 | page_to_pfn(page), page_to_pfn(page) << PAGE_SHIFT); |
212 | 211 | ||
213 | ret = vm_insert_page(vma, (unsigned long)vmf->virtual_address, page); | 212 | ret = vm_insert_page(vma, vmf->address, page); |
214 | 213 | ||
215 | out: | 214 | out: |
216 | switch (ret) { | 215 | switch (ret) { |