aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/drm_atomic_helper.c
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2016-05-09 10:34:11 -0400
committerDaniel Vetter <daniel.vetter@ffwll.ch>2016-05-17 02:57:05 -0400
commitfabd9106f758714ed614c8c2a7321386aa58bdb1 (patch)
tree55cc0fde61da99b4cc5bffed37e747cac9ba82e8 /drivers/gpu/drm/drm_atomic_helper.c
parent2f701695fd3a5876cd302662554f6c0ece5197eb (diff)
drm: Drop connector argument from __drm_atomic_helper_connector_destroy_state
It's unused, and really this helper should only look at the state structure and nothing else. Note that this conflicts with a patch from Dave that adds refcounting to drm_connectors. It's not yet clear whether the check Dave adds for connector != NULL is really needed or the right check. v2: Fix commmit message (Laurent). Cc: Dave Airlie <airlied@gmail.com> Acked-by: Thierry Reding <thierry.reding@gmail.com> Acked-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1462804451-15318-3-git-send-email-daniel.vetter@ffwll.ch
Diffstat (limited to 'drivers/gpu/drm/drm_atomic_helper.c')
-rw-r--r--drivers/gpu/drm/drm_atomic_helper.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index c6282b4fb8bf..ddfa0d120e39 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -2756,8 +2756,7 @@ void drm_atomic_helper_connector_reset(struct drm_connector *connector)
2756 kzalloc(sizeof(*conn_state), GFP_KERNEL); 2756 kzalloc(sizeof(*conn_state), GFP_KERNEL);
2757 2757
2758 if (connector->state) 2758 if (connector->state)
2759 __drm_atomic_helper_connector_destroy_state(connector, 2759 __drm_atomic_helper_connector_destroy_state(connector->state);
2760 connector->state);
2761 2760
2762 kfree(connector->state); 2761 kfree(connector->state);
2763 __drm_atomic_helper_connector_reset(connector, conn_state); 2762 __drm_atomic_helper_connector_reset(connector, conn_state);
@@ -2890,7 +2889,6 @@ EXPORT_SYMBOL(drm_atomic_helper_duplicate_state);
2890 2889
2891/** 2890/**
2892 * __drm_atomic_helper_connector_destroy_state - release connector state 2891 * __drm_atomic_helper_connector_destroy_state - release connector state
2893 * @connector: connector object
2894 * @state: connector state object to release 2892 * @state: connector state object to release
2895 * 2893 *
2896 * Releases all resources stored in the connector state without actually 2894 * Releases all resources stored in the connector state without actually
@@ -2898,8 +2896,7 @@ EXPORT_SYMBOL(drm_atomic_helper_duplicate_state);
2898 * subclass the connector state. 2896 * subclass the connector state.
2899 */ 2897 */
2900void 2898void
2901__drm_atomic_helper_connector_destroy_state(struct drm_connector *connector, 2899__drm_atomic_helper_connector_destroy_state(struct drm_connector_state *state)
2902 struct drm_connector_state *state)
2903{ 2900{
2904 /* 2901 /*
2905 * This is currently a placeholder so that drivers that subclass the 2902 * This is currently a placeholder so that drivers that subclass the
@@ -2922,7 +2919,7 @@ EXPORT_SYMBOL(__drm_atomic_helper_connector_destroy_state);
2922void drm_atomic_helper_connector_destroy_state(struct drm_connector *connector, 2919void drm_atomic_helper_connector_destroy_state(struct drm_connector *connector,
2923 struct drm_connector_state *state) 2920 struct drm_connector_state *state)
2924{ 2921{
2925 __drm_atomic_helper_connector_destroy_state(connector, state); 2922 __drm_atomic_helper_connector_destroy_state(state);
2926 kfree(state); 2923 kfree(state);
2927} 2924}
2928EXPORT_SYMBOL(drm_atomic_helper_connector_destroy_state); 2925EXPORT_SYMBOL(drm_atomic_helper_connector_destroy_state);