diff options
author | Wei Yongjun <weiyj.lk@gmail.com> | 2016-07-27 22:14:26 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-07-28 06:59:56 -0400 |
commit | 12ae57aab43880eac500c43590e26d9d4411961b (patch) | |
tree | 64275091f1018697f8dc9a3156b70318f3bd4850 /drivers/gpu/drm/arm | |
parent | 1a9d71f84c8d6f981bc598398ddbbec4ee25e3c7 (diff) |
drm/arm: mali-dp: Fix error return code in malidp_bind()
Fix to return error code -EINVAL from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
instead of the endpoint')
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Acked-by: Brian Starkey <brian.starkey@arm.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1469672066-13401-1-git-send-email-weiyj.lk@gmail.com
Diffstat (limited to 'drivers/gpu/drm/arm')
-rw-r--r-- | drivers/gpu/drm/arm/malidp_drv.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 116032216e62..82171d223f2d 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c | |||
@@ -360,8 +360,10 @@ static int malidp_bind(struct device *dev) | |||
360 | 360 | ||
361 | /* Set the CRTC's port so that the encoder component can find it */ | 361 | /* Set the CRTC's port so that the encoder component can find it */ |
362 | ep = of_graph_get_next_endpoint(dev->of_node, NULL); | 362 | ep = of_graph_get_next_endpoint(dev->of_node, NULL); |
363 | if (!ep) | 363 | if (!ep) { |
364 | ret = -EINVAL; | ||
364 | goto port_fail; | 365 | goto port_fail; |
366 | } | ||
365 | malidp->crtc.port = of_get_next_parent(ep); | 367 | malidp->crtc.port = of_get_next_parent(ep); |
366 | 368 | ||
367 | ret = component_bind_all(dev, drm); | 369 | ret = component_bind_all(dev, drm); |