aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/arc
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2016-06-17 04:25:18 -0400
committerDaniel Vetter <daniel.vetter@ffwll.ch>2016-06-21 04:53:12 -0400
commite01d9e5415f2770e341754fa40ca20e069772521 (patch)
tree46f52f21234c1a92b8b8160fbdfbe7e19ee8bf25 /drivers/gpu/drm/arc
parent9127f99c4801f323ffbb3b755259f3a679f66c7c (diff)
drm/arc: Remove redundant calls to drm_connector_register_all()
Up to now, the recommendation was for drivers to call drm_dev_register() followed by drm_connector_register_all(). Now that drm_connector_register() is safe against multiple invocations, we can move drm_connector_register_all() to drm_dev_register() and not suffer from any backwards compatibility issues with drivers not following the more rigorous init ordering. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Alexey Brodkin <abrodkin@synopsys.com> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1466151923-1572-3-git-send-email-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/arc')
-rw-r--r--drivers/gpu/drm/arc/arcpgu_drv.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
index 381c5fcbf903..ccbdadb108dc 100644
--- a/drivers/gpu/drm/arc/arcpgu_drv.c
+++ b/drivers/gpu/drm/arc/arcpgu_drv.c
@@ -211,15 +211,8 @@ static int arcpgu_probe(struct platform_device *pdev)
211 if (ret) 211 if (ret)
212 goto err_unload; 212 goto err_unload;
213 213
214 ret = drm_connector_register_all(drm);
215 if (ret)
216 goto err_unregister;
217
218 return 0; 214 return 0;
219 215
220err_unregister:
221 drm_dev_unregister(drm);
222
223err_unload: 216err_unload:
224 arcpgu_unload(drm); 217 arcpgu_unload(drm);
225 218
@@ -233,7 +226,6 @@ static int arcpgu_remove(struct platform_device *pdev)
233{ 226{
234 struct drm_device *drm = platform_get_drvdata(pdev); 227 struct drm_device *drm = platform_get_drvdata(pdev);
235 228
236 drm_connector_unregister_all(drm);
237 drm_dev_unregister(drm); 229 drm_dev_unregister(drm);
238 arcpgu_unload(drm); 230 arcpgu_unload(drm);
239 drm_dev_unref(drm); 231 drm_dev_unref(drm);