diff options
| author | Dave Airlie <airlied@redhat.com> | 2015-08-13 20:15:24 -0400 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2015-08-13 20:15:24 -0400 |
| commit | 8f9cb50789e76f3e224e8861adf650e55c747af4 (patch) | |
| tree | fa84fd7daf1a6dd252f2632cb33b634cb9784691 /drivers/gpu/drm/amd | |
| parent | e1474e7bdf6b16db41cc12b8e7b3fefd8668f3cf (diff) | |
| parent | a63c580a5271b61f12cf91e768120e33792e2907 (diff) | |
Merge tag 'drm-amdkfd-next-fixes-2015-08-05' of git://people.freedesktop.org/~gabbayo/linux into drm-next
Two small bug fixes for the code you pulled for 4.3:
- Used a SHIFT define instead of a MASK define to check if a bit is turned on
when destroying hqd. Luckily, this is in gfx7 interface file with amdgpu,
which was used only for bring-up purposes of amdgpu, so no real effect on
a running system
- Used a logical AND instead of a bitwise AND operator, when initializing
sdma virtual memory when using SDMA queues
* tag 'drm-amdkfd-next-fixes-2015-08-05' of git://people.freedesktop.org/~gabbayo/linux:
drm/amdkfd: fix bug when initializing sdma vm
drm/amdgpu: fix bug when amdkfd destroys hqd
Diffstat (limited to 'drivers/gpu/drm/amd')
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 2 | ||||
| -rw-r--r-- | drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_cik.c | 2 | ||||
| -rw-r--r-- | drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c index 2daad335b809..dd2037bc0b4a 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | |||
| @@ -450,7 +450,7 @@ static int kgd_hqd_destroy(struct kgd_dev *kgd, uint32_t reset_type, | |||
| 450 | 450 | ||
| 451 | while (true) { | 451 | while (true) { |
| 452 | temp = RREG32(mmCP_HQD_ACTIVE); | 452 | temp = RREG32(mmCP_HQD_ACTIVE); |
| 453 | if (temp & CP_HQD_ACTIVE__ACTIVE__SHIFT) | 453 | if (temp & CP_HQD_ACTIVE__ACTIVE_MASK) |
| 454 | break; | 454 | break; |
| 455 | if (timeout == 0) { | 455 | if (timeout == 0) { |
| 456 | pr_err("kfd: cp queue preemption time out (%dms)\n", | 456 | pr_err("kfd: cp queue preemption time out (%dms)\n", |
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_cik.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_cik.c index 23ce774ff09d..c6f435aa803f 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_cik.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_cik.c | |||
| @@ -143,7 +143,7 @@ static void init_sdma_vm(struct device_queue_manager *dqm, struct queue *q, | |||
| 143 | get_sh_mem_bases_32(qpd_to_pdd(qpd)); | 143 | get_sh_mem_bases_32(qpd_to_pdd(qpd)); |
| 144 | else | 144 | else |
| 145 | value |= ((get_sh_mem_bases_nybble_64(qpd_to_pdd(qpd))) << | 145 | value |= ((get_sh_mem_bases_nybble_64(qpd_to_pdd(qpd))) << |
| 146 | SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE__SHIFT) && | 146 | SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE__SHIFT) & |
| 147 | SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE_MASK; | 147 | SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE_MASK; |
| 148 | 148 | ||
| 149 | q->properties.sdma_vm_addr = value; | 149 | q->properties.sdma_vm_addr = value; |
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c index 44c38e8e54d3..7e9cae9d349b 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c | |||
| @@ -155,7 +155,7 @@ static void init_sdma_vm(struct device_queue_manager *dqm, struct queue *q, | |||
| 155 | get_sh_mem_bases_32(qpd_to_pdd(qpd)); | 155 | get_sh_mem_bases_32(qpd_to_pdd(qpd)); |
| 156 | else | 156 | else |
| 157 | value |= ((get_sh_mem_bases_nybble_64(qpd_to_pdd(qpd))) << | 157 | value |= ((get_sh_mem_bases_nybble_64(qpd_to_pdd(qpd))) << |
| 158 | SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE__SHIFT) && | 158 | SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE__SHIFT) & |
| 159 | SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE_MASK; | 159 | SDMA0_RLC0_VIRTUAL_ADDR__SHARED_BASE_MASK; |
| 160 | 160 | ||
| 161 | q->properties.sdma_vm_addr = value; | 161 | q->properties.sdma_vm_addr = value; |
