drm/amdgpu: various cleanups for uvd/vce.

Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

7 files changed, 22 insertions, 103 deletions

diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c b/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c
index 9a4129d881aa..8ab0f78794a5 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c
@@ -135,12 +135,9 @@ static int uvd_v4_2_sw_fini(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_uvd_sw_fini(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_uvd_sw_fini(adev);
 }
+
 static void uvd_v4_2_enable_mgcg(struct amdgpu_device *adev,
                                  bool enable);
 /**
@@ -230,11 +227,7 @@ static int uvd_v4_2_suspend(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_uvd_suspend(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_uvd_suspend(adev);
 }
 
 static int uvd_v4_2_resume(void *handle)
@@ -246,11 +239,7 @@ static int uvd_v4_2_resume(void *handle)
         if (r)
                 return r;
 
-        r = uvd_v4_2_hw_init(adev);
-        if (r)
-                return r;
-
-        return r;
+        return uvd_v4_2_hw_init(adev);
 }
 
 /**
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c
index e448f7d86bc0..bb6d46e168a3 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c
@@ -131,11 +131,7 @@ static int uvd_v5_0_sw_fini(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_uvd_sw_fini(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_uvd_sw_fini(adev);
 }
 
 /**
@@ -228,11 +224,7 @@ static int uvd_v5_0_suspend(void *handle)
                 return r;
         uvd_v5_0_set_clockgating_state(adev, AMD_CG_STATE_GATE);
 
-        r = amdgpu_uvd_suspend(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_uvd_suspend(adev);
 }
 
 static int uvd_v5_0_resume(void *handle)
@@ -244,11 +236,7 @@ static int uvd_v5_0_resume(void *handle)
         if (r)
                 return r;
 
-        r = uvd_v5_0_hw_init(adev);
-        if (r)
-                return r;
-
-        return r;
+        return uvd_v5_0_hw_init(adev);
 }
 
 /**
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
index 5679a4249bd9..31db356476f8 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
@@ -134,11 +134,7 @@ static int uvd_v6_0_sw_fini(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_uvd_sw_fini(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_uvd_sw_fini(adev);
 }
 
 /**
@@ -230,11 +226,8 @@ static int uvd_v6_0_suspend(void *handle)
                 return r;
 
         /* Skip this for APU for now */
-        if (!(adev->flags & AMD_IS_APU)) {
+        if (!(adev->flags & AMD_IS_APU))
                 r = amdgpu_uvd_suspend(adev);
-                if (r)
-                        return r;
-        }
 
         return r;
 }
@@ -250,11 +243,7 @@ static int uvd_v6_0_resume(void *handle)
                 if (r)
                         return r;
         }
-        r = uvd_v6_0_hw_init(adev);
-        if (r)
-                return r;
-
-        return r;
+        return uvd_v6_0_hw_init(adev);
 }
 
 /**
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
index 13f52e0af9b8..8a9a90b00c93 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
@@ -438,11 +438,7 @@ static int uvd_v7_0_sw_fini(void *handle)
         for (i = 0; i < adev->uvd.num_enc_rings; ++i)
                 amdgpu_ring_fini(&adev->uvd.ring_enc[i]);
 
-        r = amdgpu_uvd_sw_fini(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_uvd_sw_fini(adev);
 }
 
 /**
@@ -547,11 +543,8 @@ static int uvd_v7_0_suspend(void *handle)
                 return r;
 
         /* Skip this for APU for now */
-        if (!(adev->flags & AMD_IS_APU)) {
+        if (!(adev->flags & AMD_IS_APU))
                 r = amdgpu_uvd_suspend(adev);
-                if (r)
-                        return r;
-        }
 
         return r;
 }
@@ -567,11 +560,7 @@ static int uvd_v7_0_resume(void *handle)
                 if (r)
                         return r;
         }
-        r = uvd_v7_0_hw_init(adev);
-        if (r)
-                return r;
-
-        return r;
+        return uvd_v7_0_hw_init(adev);
 }
 
 /**
diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c
index 49a6c45e65be..47f70827195b 100644
--- a/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c
@@ -451,11 +451,7 @@ static int vce_v2_0_sw_fini(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_vce_sw_fini(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_vce_sw_fini(adev);
 }
 
 static int vce_v2_0_hw_init(void *handle)
@@ -495,11 +491,7 @@ static int vce_v2_0_suspend(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_vce_suspend(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_vce_suspend(adev);
 }
 
 static int vce_v2_0_resume(void *handle)
@@ -511,11 +503,7 @@ static int vce_v2_0_resume(void *handle)
         if (r)
                 return r;
 
-        r = vce_v2_0_hw_init(adev);
-        if (r)
-                return r;
-
-        return r;
+        return vce_v2_0_hw_init(adev);
 }
 
 static int vce_v2_0_soft_reset(void *handle)
diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
index db0adac073c6..fb0819359909 100644
--- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
@@ -417,11 +417,7 @@ static int vce_v3_0_sw_fini(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_vce_sw_fini(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_vce_sw_fini(adev);
 }
 
 static int vce_v3_0_hw_init(void *handle)
@@ -471,11 +467,7 @@ static int vce_v3_0_suspend(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_vce_suspend(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_vce_suspend(adev);
 }
 
 static int vce_v3_0_resume(void *handle)
@@ -487,11 +479,7 @@ static int vce_v3_0_resume(void *handle)
         if (r)
                 return r;
 
-        r = vce_v3_0_hw_init(adev);
-        if (r)
-                return r;
-
-        return r;
+        return vce_v3_0_hw_init(adev);
 }
 
 static void vce_v3_0_mc_resume(struct amdgpu_device *adev, int idx)
diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c
index becc5f744a98..2a3db99fbf1e 100644
--- a/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c
@@ -527,11 +527,7 @@ static int vce_v4_0_sw_fini(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_vce_sw_fini(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_vce_sw_fini(adev);
 }
 
 static int vce_v4_0_hw_init(void *handle)
@@ -584,11 +580,7 @@ static int vce_v4_0_suspend(void *handle)
         if (r)
                 return r;
 
-        r = amdgpu_vce_suspend(adev);
-        if (r)
-                return r;
-
-        return r;
+        return amdgpu_vce_suspend(adev);
 }
 
 static int vce_v4_0_resume(void *handle)
@@ -600,11 +592,7 @@ static int vce_v4_0_resume(void *handle)
         if (r)
                 return r;
 
-        r = vce_v4_0_hw_init(adev);
-        if (r)
-                return r;
-
-        return r;
+        return vce_v4_0_hw_init(adev);
 }
 
 static void vce_v4_0_mc_resume(struct amdgpu_device *adev)