aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/amdgpu
diff options
context:
space:
mode:
authorMel Gorman <mgorman@techsingularity.net>2017-11-15 20:37:55 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2017-11-15 21:21:06 -0500
commitc6f92f9fbe7dbcc8903a67229aa88b4077ae4422 (patch)
tree9462a6283a2e62aff9701ad10c92461eac9fdaf1 /drivers/gpu/drm/amd/amdgpu
parent8667982014d6048e0b5e286b6247ff24f48d4cc6 (diff)
mm: remove cold parameter for release_pages
All callers of release_pages claim the pages being released are cache hot. As no one cares about the hotness of pages being released to the allocator, just ditch the parameter. No performance impact is expected as the overhead is marginal. The parameter is removed simply because it is a bit stupid to have a useless parameter copied everywhere. Link: http://lkml.kernel.org/r/20171018075952.10627-7-mgorman@techsingularity.net Signed-off-by: Mel Gorman <mgorman@techsingularity.net> Acked-by: Vlastimil Babka <vbabka@suse.cz> Cc: Andi Kleen <ak@linux.intel.com> Cc: Dave Chinner <david@fromorbit.com> Cc: Dave Hansen <dave.hansen@intel.com> Cc: Jan Kara <jack@suse.cz> Cc: Johannes Weiner <hannes@cmpxchg.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu')
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c6
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c2
3 files changed, 4 insertions, 6 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 60d8bedb694d..cd664832f9e8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -553,8 +553,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
553 * invalidated it. Free it and try again 553 * invalidated it. Free it and try again
554 */ 554 */
555 release_pages(e->user_pages, 555 release_pages(e->user_pages,
556 e->robj->tbo.ttm->num_pages, 556 e->robj->tbo.ttm->num_pages);
557 false);
558 kvfree(e->user_pages); 557 kvfree(e->user_pages);
559 e->user_pages = NULL; 558 e->user_pages = NULL;
560 } 559 }
@@ -691,8 +690,7 @@ error_free_pages:
691 continue; 690 continue;
692 691
693 release_pages(e->user_pages, 692 release_pages(e->user_pages,
694 e->robj->tbo.ttm->num_pages, 693 e->robj->tbo.ttm->num_pages);
695 false);
696 kvfree(e->user_pages); 694 kvfree(e->user_pages);
697 } 695 }
698 } 696 }
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index 6149a47fe63d..0bda8f2a188a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
@@ -347,7 +347,7 @@ int amdgpu_gem_userptr_ioctl(struct drm_device *dev, void *data,
347 return 0; 347 return 0;
348 348
349free_pages: 349free_pages:
350 release_pages(bo->tbo.ttm->pages, bo->tbo.ttm->num_pages, false); 350 release_pages(bo->tbo.ttm->pages, bo->tbo.ttm->num_pages);
351 351
352unlock_mmap_sem: 352unlock_mmap_sem:
353 up_read(&current->mm->mmap_sem); 353 up_read(&current->mm->mmap_sem);
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index bc746131987f..d792959fac43 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -659,7 +659,7 @@ int amdgpu_ttm_tt_get_user_pages(struct ttm_tt *ttm, struct page **pages)
659 return 0; 659 return 0;
660 660
661release_pages: 661release_pages:
662 release_pages(pages, pinned, 0); 662 release_pages(pages, pinned);
663 return r; 663 return r;
664} 664}
665 665