aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2017-09-30 04:14:13 -0400
committerAlex Deucher <alexander.deucher@amd.com>2017-11-08 17:55:04 -0500
commit78aa02c713fcf19e9bc8511ab61a5fd6c877cc01 (patch)
treef88d3828b4aa2d94731d2d7e737bf711e3ac4716 /drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
parent40a9960b046290939b56ce8e51f365258f27f264 (diff)
drm/amdgpu: Potential uninitialized variable in amdgpu_vm_update_directories()
After commit ea09729c9302 ("drm/amdgpu: rework page directory filling v2") then it becomes a lot harder to verify that "r" is initialized. My static checker complains and so I've reviewed the code. It does look like it might be buggy... Anyway, it doesn't hurt to set "r" to zero at the start. Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c')
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 010d14195a5e..c8c26f21993c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1244,7 +1244,7 @@ static void amdgpu_vm_invalidate_level(struct amdgpu_vm *vm,
1244int amdgpu_vm_update_directories(struct amdgpu_device *adev, 1244int amdgpu_vm_update_directories(struct amdgpu_device *adev,
1245 struct amdgpu_vm *vm) 1245 struct amdgpu_vm *vm)
1246{ 1246{
1247 int r; 1247 int r = 0;
1248 1248
1249 spin_lock(&vm->status_lock); 1249 spin_lock(&vm->status_lock);
1250 while (!list_empty(&vm->relocated)) { 1250 while (!list_empty(&vm->relocated)) {