diff options
author | Chunming Zhou <david1.zhou@amd.com> | 2018-03-16 00:29:38 -0400 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2018-03-22 15:42:33 -0400 |
commit | cc15dfaa85e8dfc763f22caca54fa097e377ea27 (patch) | |
tree | ae2a983d60876449e2f9f9e75a57869b5ce5ea9a /drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | |
parent | b6356df3eb9ad9ae12efb4ec37d5615065e51d8b (diff) |
drm/amdgpu: Don't change preferred domian when fallback GTT v5
v2: add sanity checking
v3: make code open
v4: also handle visible to invisible fallback
v5: Since two fallback cases, re-use goto retry
Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_object.c')
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 18 |
1 files changed, 15 insertions, 3 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index 6d08cde8443c..fac4b6067efd 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | |||
@@ -356,6 +356,7 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev, unsigned long size, | |||
356 | struct amdgpu_bo *bo; | 356 | struct amdgpu_bo *bo; |
357 | unsigned long page_align; | 357 | unsigned long page_align; |
358 | size_t acc_size; | 358 | size_t acc_size; |
359 | u32 domains; | ||
359 | int r; | 360 | int r; |
360 | 361 | ||
361 | page_align = roundup(byte_align, PAGE_SIZE) >> PAGE_SHIFT; | 362 | page_align = roundup(byte_align, PAGE_SIZE) >> PAGE_SHIFT; |
@@ -417,12 +418,23 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev, unsigned long size, | |||
417 | #endif | 418 | #endif |
418 | 419 | ||
419 | bo->tbo.bdev = &adev->mman.bdev; | 420 | bo->tbo.bdev = &adev->mman.bdev; |
420 | amdgpu_ttm_placement_from_domain(bo, domain); | 421 | domains = bo->preferred_domains; |
421 | 422 | retry: | |
423 | amdgpu_ttm_placement_from_domain(bo, domains); | ||
422 | r = ttm_bo_init_reserved(&adev->mman.bdev, &bo->tbo, size, type, | 424 | r = ttm_bo_init_reserved(&adev->mman.bdev, &bo->tbo, size, type, |
423 | &bo->placement, page_align, &ctx, acc_size, | 425 | &bo->placement, page_align, &ctx, acc_size, |
424 | NULL, resv, &amdgpu_ttm_bo_destroy); | 426 | NULL, resv, &amdgpu_ttm_bo_destroy); |
425 | if (unlikely(r != 0)) | 427 | |
428 | if (unlikely(r && r != -ERESTARTSYS)) { | ||
429 | if (bo->flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED) { | ||
430 | bo->flags &= ~AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED; | ||
431 | goto retry; | ||
432 | } else if (domains != bo->preferred_domains) { | ||
433 | domains = bo->allowed_domains; | ||
434 | goto retry; | ||
435 | } | ||
436 | } | ||
437 | if (unlikely(r)) | ||
426 | return r; | 438 | return r; |
427 | 439 | ||
428 | if (adev->gmc.visible_vram_size < adev->gmc.real_vram_size && | 440 | if (adev->gmc.visible_vram_size < adev->gmc.real_vram_size && |