aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
diff options
context:
space:
mode:
authorAlex Deucher <alexander.deucher@amd.com>2018-01-18 19:05:36 -0500
committerAlex Deucher <alexander.deucher@amd.com>2018-02-19 14:18:16 -0500
commit9950cda2a0187314c3cd6a86415ab9050074c5f8 (patch)
tree914f0f1660b69eff416a5924292cc035bb90e823 /drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
parent04f618eb3b81ac20daea791766e9f4cb71f1f32b (diff)
drm/amdgpu: drop the drm irq pre/post/un install callbacks
The preinstall callback didn't do anything because not all of the IPs were initialized when it was called. Move the postinstall setup into sequence in the driver. The uninstall callback disabled all interrupt source, but it got called too late in the driver sequence and caused problems with IPs who already freed the relevant data structures. Move the call into the right place in the driver sequence. Acked-by: Christian König <christian.koenig@amd.com> Acked-by: Harry Wentland <harry.wentland@amd.com> Tested-By: Mikita Lipski <mikita.lipski@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h')
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
index 0610cc4a9788..3375ad778edc 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
@@ -78,9 +78,7 @@ struct amdgpu_irq {
78 uint32_t srbm_soft_reset; 78 uint32_t srbm_soft_reset;
79}; 79};
80 80
81void amdgpu_irq_preinstall(struct drm_device *dev); 81void amdgpu_irq_disable_all(struct amdgpu_device *adev);
82int amdgpu_irq_postinstall(struct drm_device *dev);
83void amdgpu_irq_uninstall(struct drm_device *dev);
84irqreturn_t amdgpu_irq_handler(int irq, void *arg); 82irqreturn_t amdgpu_irq_handler(int irq, void *arg);
85 83
86int amdgpu_irq_init(struct amdgpu_device *adev); 84int amdgpu_irq_init(struct amdgpu_device *adev);