drm/fb-helper: Automatically clean up fb_info

Noticed that everyone duplicates the same logic here and we could safe
a few lines per driver. Yay for lots of drivers to make such tiny
refactors worth-while!

v2: Forgot to git add everything :(

v3: Actually remove release_fbi (Sean, Emil, Chris) ...

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170207161603.17611-1-daniel.vetter@ffwll.ch

1 files changed, 4 insertions, 7 deletions

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
index 36ce3cac81ba..72505b15dd13 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
@@ -224,7 +224,7 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
         info = drm_fb_helper_alloc_fbi(helper);
         if (IS_ERR(info)) {
                 ret = PTR_ERR(info);
-                goto out_unref;
+                goto out;
         }
 
         info->par = rfbdev;
@@ -233,7 +233,7 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
         ret = amdgpu_framebuffer_init(adev->ddev, &rfbdev->rfb, &mode_cmd, gobj);
         if (ret) {
                 DRM_ERROR("failed to initialize framebuffer %d\n", ret);
-                goto out_destroy_fbi;
+                goto out;
         }
 
         fb = &rfbdev->rfb.base;
@@ -266,7 +266,7 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
 
         if (info->screen_base == NULL) {
                 ret = -ENOSPC;
-                goto out_destroy_fbi;
+                goto out;
         }
 
         DRM_INFO("fb mappable at 0x%lX\n",  info->fix.smem_start);
@@ -278,9 +278,7 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
         vga_switcheroo_client_fb_set(adev->ddev->pdev, info);
         return 0;
 
-out_destroy_fbi:
-        drm_fb_helper_release_fbi(helper);
-out_unref:
+out:
         if (abo) {
 
         }
@@ -304,7 +302,6 @@ static int amdgpu_fbdev_destroy(struct drm_device *dev, struct amdgpu_fbdev *rfb
         struct amdgpu_framebuffer *rfb = &rfbdev->rfb;
 
         drm_fb_helper_unregister_fbi(&rfbdev->helper);
-        drm_fb_helper_release_fbi(&rfbdev->helper);
 
         if (rfb->obj) {
                 amdgpufb_destroy_pinned_object(rfb->obj);