aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/edac
diff options
context:
space:
mode:
authorBorislav Petkov <bp@suse.de>2018-10-31 14:20:20 -0400
committerBorislav Petkov <bp@suse.de>2018-10-31 14:24:21 -0400
commita324e9396ca3d00e1101476ba067b412e0aba232 (patch)
tree3e79aaf1f5c10d5890ca2ce0e233222864aeda82 /drivers/edac
parentad6e16059d8e00de0887885db11d87cba0bd1512 (diff)
EDAC, skx: Fix randconfig builds
The driver depends on the ADXL component glue and selects it. However, ADXL itself implicitly depends on ACPI and in nonsensical randconfig builds like this: # CONFIG_ACPI is not set CONFIG_ACPI_ADXL=y where ACPI is not enabled, the build fails with: drivers/edac/skx_edac.o: In function `skx_mce_check_error': skx_edac.c:(.text+0xab): undefined reference to `adxl_decode' drivers/edac/skx_edac.o: In function `skx_init': skx_edac.c:(.init.text+0x8bf): undefined reference to `adxl_get_component_names' make: *** [vmlinux] Error 1 Add stubs for that case so that the build succeeds. CONFIG_ACPI=n doesn't make any sense for real configurations but this fix will at least silence randconfig builds. Signed-off-by: Borislav Petkov <bp@suse.de> Acked-by: Tony Luck <tony.luck@intel.com> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Diffstat (limited to 'drivers/edac')
-rw-r--r--drivers/edac/Kconfig2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index ffd349c12479..68e479b4d9c9 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -234,7 +234,7 @@ config EDAC_SKX
234 depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG 234 depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
235 depends on ACPI_NFIT || !ACPI_NFIT # if ACPI_NFIT=m, EDAC_SKX can't be y 235 depends on ACPI_NFIT || !ACPI_NFIT # if ACPI_NFIT=m, EDAC_SKX can't be y
236 select DMI 236 select DMI
237 select ACPI_ADXL 237 select ACPI_ADXL if ACPI
238 help 238 help
239 Support for error detection and correction the Intel 239 Support for error detection and correction the Intel
240 Skylake server Integrated Memory Controllers. If your 240 Skylake server Integrated Memory Controllers. If your