aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/edac
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2012-01-08 16:21:22 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2012-01-08 16:21:22 -0500
commit98793265b429a3f0b3f1750e74d67cd4d740d162 (patch)
treeb0bd717673f0c21845cf053f3fb6b75d42530af5 /drivers/edac
parentb4a133da2eaccb844a7beaef16ffd9c76a0d21d3 (diff)
parentbd1b2a555952d959f47169056fca05acf7eff81f (diff)
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (53 commits) Kconfig: acpi: Fix typo in comment. misc latin1 to utf8 conversions devres: Fix a typo in devm_kfree comment btrfs: free-space-cache.c: remove extra semicolon. fat: Spelling s/obsolate/obsolete/g SCSI, pmcraid: Fix spelling error in a pmcraid_err() call tools/power turbostat: update fields in manpage mac80211: drop spelling fix types.h: fix comment spelling for 'architectures' typo fixes: aera -> area, exntension -> extension devices.txt: Fix typo of 'VMware'. sis900: Fix enum typo 'sis900_rx_bufer_status' decompress_bunzip2: remove invalid vi modeline treewide: Fix comment and string typo 'bufer' hyper-v: Update MAINTAINERS treewide: Fix typos in various parts of the kernel, and fix some comments. clockevents: drop unknown Kconfig symbol GENERIC_CLOCKEVENTS_MIGR gpio: Kconfig: drop unknown symbol 'CS5535_GPIO' leds: Kconfig: Fix typo 'D2NET_V2' sound: Kconfig: drop unknown symbol ARCH_CLPS7500 ... Fix up trivial conflicts in arch/powerpc/platforms/40x/Kconfig (some new kconfig additions, close to removed commented-out old ones)
Diffstat (limited to 'drivers/edac')
-rw-r--r--drivers/edac/i82975x_edac.c30
-rw-r--r--drivers/edac/ppc4xx_edac.c2
2 files changed, 20 insertions, 12 deletions
diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
index a5da732fe5b2..4184e0171f00 100644
--- a/drivers/edac/i82975x_edac.c
+++ b/drivers/edac/i82975x_edac.c
@@ -277,11 +277,9 @@ static void i82975x_get_error_info(struct mem_ctl_info *mci,
277static int i82975x_process_error_info(struct mem_ctl_info *mci, 277static int i82975x_process_error_info(struct mem_ctl_info *mci,
278 struct i82975x_error_info *info, int handle_errors) 278 struct i82975x_error_info *info, int handle_errors)
279{ 279{
280 int row, multi_chan, chan; 280 int row, chan;
281 unsigned long offst, page; 281 unsigned long offst, page;
282 282
283 multi_chan = mci->csrows[0].nr_channels - 1;
284
285 if (!(info->errsts2 & 0x0003)) 283 if (!(info->errsts2 & 0x0003))
286 return 0; 284 return 0;
287 285
@@ -294,20 +292,30 @@ static int i82975x_process_error_info(struct mem_ctl_info *mci,
294 } 292 }
295 293
296 page = (unsigned long) info->eap; 294 page = (unsigned long) info->eap;
297 if (info->xeap & 1)
298 page |= 0x100000000ul;
299 chan = page & 1;
300 page >>= 1; 295 page >>= 1;
301 offst = page & ((1 << PAGE_SHIFT) - 1); 296 if (info->xeap & 1)
302 page >>= PAGE_SHIFT; 297 page |= 0x80000000;
298 page >>= (PAGE_SHIFT - 1);
303 row = edac_mc_find_csrow_by_page(mci, page); 299 row = edac_mc_find_csrow_by_page(mci, page);
304 300
301 if (row == -1) {
302 i82975x_mc_printk(mci, KERN_ERR, "error processing EAP:\n"
303 "\tXEAP=%u\n"
304 "\t EAP=0x%08x\n"
305 "\tPAGE=0x%08x\n",
306 (info->xeap & 1) ? 1 : 0, info->eap, (unsigned int) page);
307 return 0;
308 }
309 chan = (mci->csrows[row].nr_channels == 1) ? 0 : info->eap & 1;
310 offst = info->eap
311 & ((1 << PAGE_SHIFT) -
312 (1 << mci->csrows[row].grain));
313
305 if (info->errsts & 0x0002) 314 if (info->errsts & 0x0002)
306 edac_mc_handle_ue(mci, page, offst , row, "i82975x UE"); 315 edac_mc_handle_ue(mci, page, offst , row, "i82975x UE");
307 else 316 else
308 edac_mc_handle_ce(mci, page, offst, info->derrsyn, row, 317 edac_mc_handle_ce(mci, page, offst, info->derrsyn, row,
309 multi_chan ? chan : 0, 318 chan, "i82975x CE");
310 "i82975x CE");
311 319
312 return 1; 320 return 1;
313} 321}
@@ -410,7 +418,7 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
410 csrow->last_page = cumul_size - 1; 418 csrow->last_page = cumul_size - 1;
411 csrow->nr_pages = cumul_size - last_cumul_size; 419 csrow->nr_pages = cumul_size - last_cumul_size;
412 last_cumul_size = cumul_size; 420 last_cumul_size = cumul_size;
413 csrow->grain = 1 << 6; /* I82975X_EAP has 64B resolution */ 421 csrow->grain = 1 << 7; /* 128Byte cache-line resolution */
414 csrow->mtype = MEM_DDR2; /* I82975x supports only DDR2 */ 422 csrow->mtype = MEM_DDR2; /* I82975x supports only DDR2 */
415 csrow->dtype = i82975x_dram_type(mch_window, index); 423 csrow->dtype = i82975x_dram_type(mch_window, index);
416 csrow->edac_mode = EDAC_SECDED; /* only supported */ 424 csrow->edac_mode = EDAC_SECDED; /* only supported */
diff --git a/drivers/edac/ppc4xx_edac.c b/drivers/edac/ppc4xx_edac.c
index 38400963e245..fc757069c6af 100644
--- a/drivers/edac/ppc4xx_edac.c
+++ b/drivers/edac/ppc4xx_edac.c
@@ -142,7 +142,7 @@
142 142
143/* 143/*
144 * The ibm,sdram-4xx-ddr2 Device Control Registers (DCRs) are 144 * The ibm,sdram-4xx-ddr2 Device Control Registers (DCRs) are
145 * indirectly acccessed and have a base and length defined by the 145 * indirectly accessed and have a base and length defined by the
146 * device tree. The base can be anything; however, we expect the 146 * device tree. The base can be anything; however, we expect the
147 * length to be precisely two registers, the first for the address 147 * length to be precisely two registers, the first for the address
148 * window and the second for the data window. 148 * window and the second for the data window.