diff options
| author | Dave Airlie <airlied@redhat.com> | 2016-06-08 21:19:28 -0400 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2016-06-08 21:19:28 -0400 |
| commit | 2cca45574007b4a77fa5f63ea45d664510cec22a (patch) | |
| tree | dd32a0b2bea4f3cef900b15c6badc8dfde69ab69 /drivers/dma-buf | |
| parent | bb4cec0222f984d7ef282c06cc3644069db21bac (diff) | |
| parent | e8395081636734da19778b0446d65588a06bc40d (diff) | |
Merge tag 'topic/drm-misc-2016-06-07' of git://anongit.freedesktop.org/drm-intel into drm-next
As promised, piles of prep work all around:
- drm_atomic_state rework, prep for nonblocking commit helpers
- fence patches from Gustavo and Christian to prep for atomic fences and
some cool work in ttm/amdgpu from Christian
- drm event prep for both nonblocking commit and atomic fences
- Gustavo seems on a crusade against the non-kms-native version of the
vblank functions.
- prep work from Boris to nuke all the silly ->best_encoder
implementations we have (we really only need that for truly dynamic
cases like dvi-i vs dvi-d or dp mst selecting the right transcoder on
intel)
- prep work from Laurent to rework the format handling functions
- and few small things all over
* tag 'topic/drm-misc-2016-06-07' of git://anongit.freedesktop.org/drm-intel: (47 commits)
drm/dsi: Implement set tear scanline
drm/fb_cma_helper: Implement fb_mmap callback
drm/qxl: Remove useless drm_fb_get_bpp_depth() call
drm/ast: Remove useless drm_fb_get_bpp_depth() call
drm/atomic: Fix remaining places where !funcs->best_encoder is valid
drm/core: Change declaration for gamma_set.
Documentation: add fence-array to kernel DocBook
drm/shmobile: use drm_crtc_vblank_{get,put}()
drm/radeon: use drm_crtc_vblank_{get,put}()
drm/qxl: use drm_crtc_vblank_{get,put}()
drm/atmel: use drm_crtc_vblank_{get,put}()
drm/armada: use drm_crtc_vblank_{get,put}()
drm/amdgpu: use drm_crtc_vblank_{get,put}()
drm/virtio: use drm_crtc_send_vblank_event()
drm/udl: use drm_crtc_send_vblank_event()
drm/qxl: use drm_crtc_send_vblank_event()
drm/atmel: use drm_crtc_send_vblank_event()
drm/armada: use drm_crtc_send_vblank_event()
drm/doc: Switch to sphinx/rst fixed-width quoting
drm/doc: Drop kerneldoc for static functions in drm_irq.c
...
Diffstat (limited to 'drivers/dma-buf')
| -rw-r--r-- | drivers/dma-buf/Makefile | 2 | ||||
| -rw-r--r-- | drivers/dma-buf/fence-array.c | 144 | ||||
| -rw-r--r-- | drivers/dma-buf/fence.c | 8 | ||||
| -rw-r--r-- | drivers/dma-buf/sync_file.c | 2 |
4 files changed, 150 insertions, 6 deletions
diff --git a/drivers/dma-buf/Makefile b/drivers/dma-buf/Makefile index 4a424eca75ed..f353db213a81 100644 --- a/drivers/dma-buf/Makefile +++ b/drivers/dma-buf/Makefile | |||
| @@ -1,2 +1,2 @@ | |||
| 1 | obj-y := dma-buf.o fence.o reservation.o seqno-fence.o | 1 | obj-y := dma-buf.o fence.o reservation.o seqno-fence.o fence-array.o |
| 2 | obj-$(CONFIG_SYNC_FILE) += sync_file.o | 2 | obj-$(CONFIG_SYNC_FILE) += sync_file.o |
diff --git a/drivers/dma-buf/fence-array.c b/drivers/dma-buf/fence-array.c new file mode 100644 index 000000000000..a8731c853da6 --- /dev/null +++ b/drivers/dma-buf/fence-array.c | |||
| @@ -0,0 +1,144 @@ | |||
| 1 | /* | ||
| 2 | * fence-array: aggregate fences to be waited together | ||
| 3 | * | ||
| 4 | * Copyright (C) 2016 Collabora Ltd | ||
| 5 | * Copyright (C) 2016 Advanced Micro Devices, Inc. | ||
| 6 | * Authors: | ||
| 7 | * Gustavo Padovan <gustavo@padovan.org> | ||
| 8 | * Christian König <christian.koenig@amd.com> | ||
| 9 | * | ||
| 10 | * This program is free software; you can redistribute it and/or modify it | ||
| 11 | * under the terms of the GNU General Public License version 2 as published by | ||
| 12 | * the Free Software Foundation. | ||
| 13 | * | ||
| 14 | * This program is distributed in the hope that it will be useful, but WITHOUT | ||
| 15 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| 16 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for | ||
| 17 | * more details. | ||
| 18 | */ | ||
| 19 | |||
| 20 | #include <linux/export.h> | ||
| 21 | #include <linux/slab.h> | ||
| 22 | #include <linux/fence-array.h> | ||
| 23 | |||
| 24 | static void fence_array_cb_func(struct fence *f, struct fence_cb *cb); | ||
| 25 | |||
| 26 | static const char *fence_array_get_driver_name(struct fence *fence) | ||
| 27 | { | ||
| 28 | return "fence_array"; | ||
| 29 | } | ||
| 30 | |||
| 31 | static const char *fence_array_get_timeline_name(struct fence *fence) | ||
| 32 | { | ||
| 33 | return "unbound"; | ||
| 34 | } | ||
| 35 | |||
| 36 | static void fence_array_cb_func(struct fence *f, struct fence_cb *cb) | ||
| 37 | { | ||
| 38 | struct fence_array_cb *array_cb = | ||
| 39 | container_of(cb, struct fence_array_cb, cb); | ||
| 40 | struct fence_array *array = array_cb->array; | ||
| 41 | |||
| 42 | if (atomic_dec_and_test(&array->num_pending)) | ||
| 43 | fence_signal(&array->base); | ||
| 44 | fence_put(&array->base); | ||
| 45 | } | ||
| 46 | |||
| 47 | static bool fence_array_enable_signaling(struct fence *fence) | ||
| 48 | { | ||
| 49 | struct fence_array *array = to_fence_array(fence); | ||
| 50 | struct fence_array_cb *cb = (void *)(&array[1]); | ||
| 51 | unsigned i; | ||
| 52 | |||
| 53 | for (i = 0; i < array->num_fences; ++i) { | ||
| 54 | cb[i].array = array; | ||
| 55 | /* | ||
| 56 | * As we may report that the fence is signaled before all | ||
| 57 | * callbacks are complete, we need to take an additional | ||
| 58 | * reference count on the array so that we do not free it too | ||
| 59 | * early. The core fence handling will only hold the reference | ||
| 60 | * until we signal the array as complete (but that is now | ||
| 61 | * insufficient). | ||
| 62 | */ | ||
| 63 | fence_get(&array->base); | ||
| 64 | if (fence_add_callback(array->fences[i], &cb[i].cb, | ||
| 65 | fence_array_cb_func)) { | ||
| 66 | fence_put(&array->base); | ||
| 67 | if (atomic_dec_and_test(&array->num_pending)) | ||
| 68 | return false; | ||
| 69 | } | ||
| 70 | } | ||
| 71 | |||
| 72 | return true; | ||
| 73 | } | ||
| 74 | |||
| 75 | static bool fence_array_signaled(struct fence *fence) | ||
| 76 | { | ||
| 77 | struct fence_array *array = to_fence_array(fence); | ||
| 78 | |||
| 79 | return atomic_read(&array->num_pending) <= 0; | ||
| 80 | } | ||
| 81 | |||
| 82 | static void fence_array_release(struct fence *fence) | ||
| 83 | { | ||
| 84 | struct fence_array *array = to_fence_array(fence); | ||
| 85 | unsigned i; | ||
| 86 | |||
| 87 | for (i = 0; i < array->num_fences; ++i) | ||
| 88 | fence_put(array->fences[i]); | ||
| 89 | |||
| 90 | kfree(array->fences); | ||
| 91 | fence_free(fence); | ||
| 92 | } | ||
| 93 | |||
| 94 | const struct fence_ops fence_array_ops = { | ||
| 95 | .get_driver_name = fence_array_get_driver_name, | ||
| 96 | .get_timeline_name = fence_array_get_timeline_name, | ||
| 97 | .enable_signaling = fence_array_enable_signaling, | ||
| 98 | .signaled = fence_array_signaled, | ||
| 99 | .wait = fence_default_wait, | ||
| 100 | .release = fence_array_release, | ||
| 101 | }; | ||
| 102 | |||
| 103 | /** | ||
| 104 | * fence_array_create - Create a custom fence array | ||
| 105 | * @num_fences: [in] number of fences to add in the array | ||
| 106 | * @fences: [in] array containing the fences | ||
| 107 | * @context: [in] fence context to use | ||
| 108 | * @seqno: [in] sequence number to use | ||
| 109 | * @signal_on_any [in] signal on any fence in the array | ||
| 110 | * | ||
| 111 | * Allocate a fence_array object and initialize the base fence with fence_init(). | ||
| 112 | * In case of error it returns NULL. | ||
| 113 | * | ||
| 114 | * The caller should allocte the fences array with num_fences size | ||
| 115 | * and fill it with the fences it wants to add to the object. Ownership of this | ||
| 116 | * array is take and fence_put() is used on each fence on release. | ||
| 117 | * | ||
| 118 | * If @signal_on_any is true the fence array signals if any fence in the array | ||
| 119 | * signals, otherwise it signals when all fences in the array signal. | ||
| 120 | */ | ||
| 121 | struct fence_array *fence_array_create(int num_fences, struct fence **fences, | ||
| 122 | u64 context, unsigned seqno, | ||
| 123 | bool signal_on_any) | ||
| 124 | { | ||
| 125 | struct fence_array *array; | ||
| 126 | size_t size = sizeof(*array); | ||
| 127 | |||
| 128 | /* Allocate the callback structures behind the array. */ | ||
| 129 | size += num_fences * sizeof(struct fence_array_cb); | ||
| 130 | array = kzalloc(size, GFP_KERNEL); | ||
| 131 | if (!array) | ||
| 132 | return NULL; | ||
| 133 | |||
| 134 | spin_lock_init(&array->lock); | ||
| 135 | fence_init(&array->base, &fence_array_ops, &array->lock, | ||
| 136 | context, seqno); | ||
| 137 | |||
| 138 | array->num_fences = num_fences; | ||
| 139 | atomic_set(&array->num_pending, signal_on_any ? 1 : num_fences); | ||
| 140 | array->fences = fences; | ||
| 141 | |||
| 142 | return array; | ||
| 143 | } | ||
| 144 | EXPORT_SYMBOL(fence_array_create); | ||
diff --git a/drivers/dma-buf/fence.c b/drivers/dma-buf/fence.c index 7b05dbe9b296..4d51f9e83fa8 100644 --- a/drivers/dma-buf/fence.c +++ b/drivers/dma-buf/fence.c | |||
| @@ -35,7 +35,7 @@ EXPORT_TRACEPOINT_SYMBOL(fence_emit); | |||
| 35 | * context or not. One device can have multiple separate contexts, | 35 | * context or not. One device can have multiple separate contexts, |
| 36 | * and they're used if some engine can run independently of another. | 36 | * and they're used if some engine can run independently of another. |
| 37 | */ | 37 | */ |
| 38 | static atomic_t fence_context_counter = ATOMIC_INIT(0); | 38 | static atomic64_t fence_context_counter = ATOMIC64_INIT(0); |
| 39 | 39 | ||
| 40 | /** | 40 | /** |
| 41 | * fence_context_alloc - allocate an array of fence contexts | 41 | * fence_context_alloc - allocate an array of fence contexts |
| @@ -44,10 +44,10 @@ static atomic_t fence_context_counter = ATOMIC_INIT(0); | |||
| 44 | * This function will return the first index of the number of fences allocated. | 44 | * This function will return the first index of the number of fences allocated. |
| 45 | * The fence context is used for setting fence->context to a unique number. | 45 | * The fence context is used for setting fence->context to a unique number. |
| 46 | */ | 46 | */ |
| 47 | unsigned fence_context_alloc(unsigned num) | 47 | u64 fence_context_alloc(unsigned num) |
| 48 | { | 48 | { |
| 49 | BUG_ON(!num); | 49 | BUG_ON(!num); |
| 50 | return atomic_add_return(num, &fence_context_counter) - num; | 50 | return atomic64_add_return(num, &fence_context_counter) - num; |
| 51 | } | 51 | } |
| 52 | EXPORT_SYMBOL(fence_context_alloc); | 52 | EXPORT_SYMBOL(fence_context_alloc); |
| 53 | 53 | ||
| @@ -513,7 +513,7 @@ EXPORT_SYMBOL(fence_wait_any_timeout); | |||
| 513 | */ | 513 | */ |
| 514 | void | 514 | void |
| 515 | fence_init(struct fence *fence, const struct fence_ops *ops, | 515 | fence_init(struct fence *fence, const struct fence_ops *ops, |
| 516 | spinlock_t *lock, unsigned context, unsigned seqno) | 516 | spinlock_t *lock, u64 context, unsigned seqno) |
| 517 | { | 517 | { |
| 518 | BUG_ON(!lock); | 518 | BUG_ON(!lock); |
| 519 | BUG_ON(!ops || !ops->wait || !ops->enable_signaling || | 519 | BUG_ON(!ops || !ops->wait || !ops->enable_signaling || |
diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c index f08cf2d8309e..9aaa608dfe01 100644 --- a/drivers/dma-buf/sync_file.c +++ b/drivers/dma-buf/sync_file.c | |||
| @@ -82,7 +82,7 @@ struct sync_file *sync_file_create(struct fence *fence) | |||
| 82 | 82 | ||
| 83 | sync_file->num_fences = 1; | 83 | sync_file->num_fences = 1; |
| 84 | atomic_set(&sync_file->status, 1); | 84 | atomic_set(&sync_file->status, 1); |
| 85 | snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%d-%d", | 85 | snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%llu-%d", |
| 86 | fence->ops->get_driver_name(fence), | 86 | fence->ops->get_driver_name(fence), |
| 87 | fence->ops->get_timeline_name(fence), fence->context, | 87 | fence->ops->get_timeline_name(fence), fence->context, |
| 88 | fence->seqno); | 88 | fence->seqno); |
