dma-fence: Wrap querying the fence->status

The fence->status is an optional field that is only valid once the fence
has been signaled. (Driver may fill the fence->status with an error code
prior to calling dma_fence_signal().) Given the restriction upon its
validity, wrap querying of the fence->status into a helper
dma_fence_get_status().

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Link: http://patchwork.freedesktop.org/patch/msgid/20170104141222.6992-2-chris@chris-wilson.co.uk

1 files changed, 8 insertions, 9 deletions

diff --git a/drivers/dma-buf/sync_debug.c b/drivers/dma-buf/sync_debug.c
index 48b20e34fb6d..c769dc653b34 100644
--- a/drivers/dma-buf/sync_debug.c
+++ b/drivers/dma-buf/sync_debug.c
@@ -62,30 +62,29 @@ void sync_file_debug_remove(struct sync_file *sync_file)
 
 static const char *sync_status_str(int status)
 {
-        if (status == 0)
-                return "signaled";
+        if (status < 0)
+                return "error";
 
         if (status > 0)
-                return "active";
+                return "signaled";
 
-        return "error";
+        return "active";
 }
 
 static void sync_print_fence(struct seq_file *s,
                              struct dma_fence *fence, bool show)
 {
-        int status = 1;
         struct sync_timeline *parent = dma_fence_parent(fence);
+        int status;
 
-        if (dma_fence_is_signaled_locked(fence))
-                status = fence->status;
+        status = dma_fence_get_status_locked(fence);
 
         seq_printf(s, "  %s%sfence %s",
                    show ? parent->name : "",
                    show ? "_" : "",
                    sync_status_str(status));
 
-        if (status <= 0) {
+        if (status) {
                 struct timespec64 ts64 =
                         ktime_to_timespec64(fence->timestamp);
 
@@ -136,7 +135,7 @@ static void sync_print_sync_file(struct seq_file *s,
         int i;
 
         seq_printf(s, "[%p] %s: %s\n", sync_file, sync_file->name,
-                   sync_status_str(!dma_fence_is_signaled(sync_file->fence)));
+                   sync_status_str(dma_fence_get_status(sync_file->fence)));
 
         if (dma_fence_is_array(sync_file->fence)) {
                 struct dma_fence_array *array = to_dma_fence_array(sync_file->fence);