diff options
author | Dmitry Kasatkin <dmitry.kasatkin@nokia.com> | 2011-06-02 14:10:07 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2011-06-29 19:44:03 -0400 |
commit | ed3ea9a82b4c63e591ceaa065b2e04a3fe946265 (patch) | |
tree | d30c1cb1df749adf31102b69bc9e664845edf78a /drivers/crypto | |
parent | a929cbeef7d8e5c3603a6f43b977c03c922aada3 (diff) |
crypto: omap-sham - move some flags to device context
Couple of context flags have been moved to device flags.
IRQ and tasklet handlers does not need to access request
context anymore.
Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
-rw-r--r-- | drivers/crypto/omap-sham.c | 19 |
1 files changed, 6 insertions, 13 deletions
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 208404e20ef7..b959dc6dbbde 100644 --- a/drivers/crypto/omap-sham.c +++ b/drivers/crypto/omap-sham.c | |||
@@ -303,7 +303,7 @@ static int omap_sham_xmit_cpu(struct omap_sham_dev *dd, const u8 *buf, | |||
303 | return -ETIMEDOUT; | 303 | return -ETIMEDOUT; |
304 | 304 | ||
305 | if (final) | 305 | if (final) |
306 | set_bit(FLAGS_FINAL, &ctx->flags); /* catch last interrupt */ | 306 | set_bit(FLAGS_FINAL, &dd->flags); /* catch last interrupt */ |
307 | 307 | ||
308 | len32 = DIV_ROUND_UP(length, sizeof(u32)); | 308 | len32 = DIV_ROUND_UP(length, sizeof(u32)); |
309 | 309 | ||
@@ -336,7 +336,7 @@ static int omap_sham_xmit_dma(struct omap_sham_dev *dd, dma_addr_t dma_addr, | |||
336 | ctx->digcnt += length; | 336 | ctx->digcnt += length; |
337 | 337 | ||
338 | if (final) | 338 | if (final) |
339 | set_bit(FLAGS_FINAL, &ctx->flags); /* catch last interrupt */ | 339 | set_bit(FLAGS_FINAL, &dd->flags); /* catch last interrupt */ |
340 | 340 | ||
341 | set_bit(FLAGS_DMA_ACTIVE, &dd->flags); | 341 | set_bit(FLAGS_DMA_ACTIVE, &dd->flags); |
342 | 342 | ||
@@ -642,7 +642,7 @@ static void omap_sham_finish_req(struct ahash_request *req, int err) | |||
642 | 642 | ||
643 | if (!err) { | 643 | if (!err) { |
644 | omap_sham_copy_hash(req, 1); | 644 | omap_sham_copy_hash(req, 1); |
645 | if (test_bit(FLAGS_FINAL, &ctx->flags)) | 645 | if (test_bit(FLAGS_FINAL, &dd->flags)) |
646 | err = omap_sham_finish(req); | 646 | err = omap_sham_finish(req); |
647 | } else { | 647 | } else { |
648 | ctx->flags |= BIT(FLAGS_ERROR); | 648 | ctx->flags |= BIT(FLAGS_ERROR); |
@@ -1034,10 +1034,9 @@ static void omap_sham_done_task(unsigned long data) | |||
1034 | { | 1034 | { |
1035 | struct omap_sham_dev *dd = (struct omap_sham_dev *)data; | 1035 | struct omap_sham_dev *dd = (struct omap_sham_dev *)data; |
1036 | struct ahash_request *req = dd->req; | 1036 | struct ahash_request *req = dd->req; |
1037 | struct omap_sham_reqctx *ctx = ahash_request_ctx(req); | ||
1038 | int ready = 0, err = 0; | 1037 | int ready = 0, err = 0; |
1039 | 1038 | ||
1040 | if (test_and_clear_bit(FLAGS_OUTPUT_READY, &ctx->flags)) | 1039 | if (test_and_clear_bit(FLAGS_OUTPUT_READY, &dd->flags)) |
1041 | ready = 1; | 1040 | ready = 1; |
1042 | 1041 | ||
1043 | if (test_and_clear_bit(FLAGS_DMA_ACTIVE, &dd->flags)) { | 1042 | if (test_and_clear_bit(FLAGS_DMA_ACTIVE, &dd->flags)) { |
@@ -1067,14 +1066,8 @@ static void omap_sham_queue_task(unsigned long data) | |||
1067 | static irqreturn_t omap_sham_irq(int irq, void *dev_id) | 1066 | static irqreturn_t omap_sham_irq(int irq, void *dev_id) |
1068 | { | 1067 | { |
1069 | struct omap_sham_dev *dd = dev_id; | 1068 | struct omap_sham_dev *dd = dev_id; |
1070 | struct omap_sham_reqctx *ctx = ahash_request_ctx(dd->req); | ||
1071 | |||
1072 | if (!ctx) { | ||
1073 | dev_err(dd->dev, "unknown interrupt.\n"); | ||
1074 | return IRQ_HANDLED; | ||
1075 | } | ||
1076 | 1069 | ||
1077 | if (unlikely(test_bit(FLAGS_FINAL, &ctx->flags))) | 1070 | if (unlikely(test_bit(FLAGS_FINAL, &dd->flags))) |
1078 | /* final -> allow device to go to power-saving mode */ | 1071 | /* final -> allow device to go to power-saving mode */ |
1079 | omap_sham_write_mask(dd, SHA_REG_CTRL, 0, SHA_REG_CTRL_LENGTH); | 1072 | omap_sham_write_mask(dd, SHA_REG_CTRL, 0, SHA_REG_CTRL_LENGTH); |
1080 | 1073 | ||
@@ -1082,7 +1075,7 @@ static irqreturn_t omap_sham_irq(int irq, void *dev_id) | |||
1082 | SHA_REG_CTRL_OUTPUT_READY); | 1075 | SHA_REG_CTRL_OUTPUT_READY); |
1083 | omap_sham_read(dd, SHA_REG_CTRL); | 1076 | omap_sham_read(dd, SHA_REG_CTRL); |
1084 | 1077 | ||
1085 | set_bit(FLAGS_OUTPUT_READY, &ctx->flags); | 1078 | set_bit(FLAGS_OUTPUT_READY, &dd->flags); |
1086 | dd->err = 0; | 1079 | dd->err = 0; |
1087 | tasklet_schedule(&dd->done_task); | 1080 | tasklet_schedule(&dd->done_task); |
1088 | 1081 | ||