aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/cpufreq
diff options
context:
space:
mode:
authorDoug Smythies <dsmythies@telus.net>2014-05-30 13:10:57 -0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2014-06-02 06:46:01 -0400
commitbf8102228a8bf053051f311e5486042fe0542894 (patch)
tree67c29987588de6d24200039ac1574f8af9c6a301 /drivers/cpufreq
parentc4ee841f602e5eef8eab673295c49c5b49d7732b (diff)
intel_pstate: Improve initial busy calculation
This change makes the busy calculation using 64 bit math which prevents overflow for large values of aperf/mperf. Cc: 3.14+ <stable@vger.kernel.org> # 3.14+ Signed-off-by: Doug Smythies <dsmythies@telus.net> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq')
-rw-r--r--drivers/cpufreq/intel_pstate.c13
1 files changed, 8 insertions, 5 deletions
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 2a07588dcbac..db2e45b4808e 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -563,16 +563,19 @@ static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
563static inline void intel_pstate_calc_busy(struct cpudata *cpu, 563static inline void intel_pstate_calc_busy(struct cpudata *cpu,
564 struct sample *sample) 564 struct sample *sample)
565{ 565{
566 int32_t core_pct; 566 int64_t core_pct;
567 int32_t rem;
567 568
568 core_pct = div_fp(int_tofp((sample->aperf)), 569 core_pct = int_tofp(sample->aperf) * int_tofp(100);
569 int_tofp((sample->mperf))); 570 core_pct = div_u64_rem(core_pct, int_tofp(sample->mperf), &rem);
570 core_pct = mul_fp(core_pct, int_tofp(100)); 571
572 if ((rem << 1) >= int_tofp(sample->mperf))
573 core_pct += 1;
571 574
572 sample->freq = fp_toint( 575 sample->freq = fp_toint(
573 mul_fp(int_tofp(cpu->pstate.max_pstate * 1000), core_pct)); 576 mul_fp(int_tofp(cpu->pstate.max_pstate * 1000), core_pct));
574 577
575 sample->core_pct_busy = core_pct; 578 sample->core_pct_busy = (int32_t)core_pct;
576} 579}
577 580
578static inline void intel_pstate_sample(struct cpudata *cpu) 581static inline void intel_pstate_sample(struct cpudata *cpu)